This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][Darwin] Fix linker errors for check-asan
ClosedPublic

Authored by yln on Jul 31 2020, 4:21 PM.

Details

Summary

A recent change broke ninja check-asan on Darwin by causing an error
during linking of ASan unit tests [1].

Move the addition of -ObjC compiler flag outside of the new
if(COMPILER_RT_STANDALONE_BUILD) block. It doesn't add any global
flags (e.g, ${CMAKE_CXX_FLAGS}) and the decision to add is based
solely on source paths (${source_rpath}).

[1] 8b2fcc42b895, https://reviews.llvm.org/D84466

Diff Detail

Event Timeline

yln created this revision.Jul 31 2020, 4:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2020, 4:21 PM
Herald added subscribers: Restricted Project, mgorny, dberris. · View Herald Transcript
yln requested review of this revision.Jul 31 2020, 4:21 PM
aeubanks accepted this revision.Jul 31 2020, 4:26 PM

sorry for the breakage, thanks for the fix

This revision is now accepted and ready to land.Jul 31 2020, 4:26 PM
This revision was landed with ongoing or failed builds.Jul 31 2020, 4:45 PM
This revision was automatically updated to reflect the committed changes.
yln added a comment.Jul 31 2020, 4:45 PM

Thanks for the quick review! :)