User Details
- User Since
- Feb 20 2014, 7:30 PM (372 w, 4 d)
Mar 9 2021
I'm trying to commit it now, but I need some information first: What should I put in the Author: line in the commit?
Mar 3 2021
Actually, looks like this doesn't apply cleanly anymore. Sorry about that, can you rebase?
Apologies for the delay, not yet. I'm going to land it ~now.
Feb 16 2021
Feb 15 2021
PS. Do you need someone to land this for you?
Thanks for this!
Feb 9 2021
LGTM
LGTM
Dec 14 2020
LGTM
Oct 20 2020
LGTM -- thanks!
Oct 14 2020
Do you think we should fix this by handling the xray-never attribute in XRayInstrumentation, or having CodeGenFunction remove the threshold if xray-never is set?
Sep 24 2020
Okay, I think I understand the motivation a little bit more now (i.e. sampling seems to be a useful thing to do anyway, regardless of whether we have the other facilities).
There's two tensions I'm trying to resolve in my mind with this patch:
Sep 19 2020
LGTM
Aug 11 2020
LGTM from me if XRay actually does work on non-x86_64 macOS.
Jul 26 2020
LGTM -- thank you, and I'm happy this has been useful for your needs!
Jun 17 2020
LGTM
May 30 2020
Apr 21 2020
I'll defer to @MaskRay on the ARM bits.
LGTM for the x86_64 bits.
I'm not well versed in AArch64 assembler here, so I'll defer to @MaskRay who has more knowledge in this area.
LGTM -- thanks!
Apr 16 2020
Apr 14 2020
LGTM, but I'm concerned about the backwards compatibility story.
Apr 13 2020
Mar 31 2020
LGTM
Feb 1 2020
Jan 16 2020
Do you mind adding x86 tests too?
Jan 14 2020
I'm wondering how you're imbuing these attributes to the functions from the front-ends -- is this something you intend to support as a flag in Clang for example?
Dec 8 2019
Nov 10 2019
Nov 7 2019
LGTM
Oct 27 2019
Do you have any suggestions on how to achieve what the FIXME'ed areas are attempting to do?
LGTM with one nit. Thanks!
LGTM -- Thanks!
Aug 27 2019
LGTM from the XRay parts.
LGTM -- apologies for the delay, I hope this isn't too late.
Aug 25 2019
I don't see the XRay specific changes... is there something I specifically need to look at here? Looks like the patchable tail call stuff is untouched.
Jun 25 2019
LGTM -- really sorry for the delay here, for some reason I didn't get to this earlier. :(
Jun 23 2019
LGTM
Apr 25 2019
LGTM -- thanks for looking into this!
Feb 27 2019
Feb 26 2019
Feb 25 2019
This is a RFC because of the uint8_t CPU change.
That chance needs discussing.
Feb 24 2019
What I wish existed was a stateful JSON output stream implementation instead of the build-everything-in-memory model. Maybe someday. :)
Feb 12 2019
LGTM
Feb 11 2019
LGTM
Jan 31 2019
LGTM
Jan 24 2019
LGTM
Jan 17 2019
LGTM -- thanks! Yes, this should have been public all along.
Jan 7 2019
More updates to address some comments.
Address comments by @greened.
Jan 3 2019
Update description.
Jan 2 2019
Add link to new doc in index.
Dec 21 2018
Dec 20 2018
LGTM
Dec 19 2018
LGTM -- cannot reproduce the original issue with this patch.
Apologies for the delay, but I'm giving this a go now.
Dec 13 2018
LGTM
LGTM still, thanks @phosek!
Dec 11 2018
LGTM -- Thanks @MaskRay!
Dec 10 2018
Dec 6 2018
Rebase again. This is now ready for another look.
Dec 5 2018
Dec 4 2018
Rebase.
Addressing comment by @mboerger.