Page MenuHomePhabricator

dberris (Dean Michael Berris)
Software Engineer @ Google

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2014, 7:30 PM (349 w, 23 h)

Recent Activity

Tue, Oct 20

dberris accepted D89441: [xray] Honor xray-never function-instrument attribute.

LGTM -- thanks!

Tue, Oct 20, 5:02 AM · Restricted Project, Restricted Project

Wed, Oct 14

dberris added a comment to D89441: [xray] Honor xray-never function-instrument attribute.

Do you think we should fix this by handling the xray-never attribute in XRayInstrumentation, or having CodeGenFunction remove the threshold if xray-never is set?

Wed, Oct 14, 9:22 PM · Restricted Project, Restricted Project

Sep 24 2020

dberris accepted D87953: [xray] Function coverage groups.

Okay, I think I understand the motivation a little bit more now (i.e. sampling seems to be a useful thing to do anyway, regardless of whether we have the other facilities).

Sep 24 2020, 6:38 PM · Restricted Project, Restricted Project
dberris added a comment to D87953: [xray] Function coverage groups.

There's two tensions I'm trying to resolve in my mind with this patch:

Sep 24 2020, 4:01 PM · Restricted Project, Restricted Project

Sep 19 2020

dberris added inline comments to D87953: [xray] Function coverage groups.
Sep 19 2020, 7:53 PM · Restricted Project, Restricted Project
dberris accepted D87977: [XRay] Change mips to use version 2 sled (PC-relative address).

LGTM

Sep 19 2020, 7:47 PM · Restricted Project, Restricted Project

Aug 11 2020

dberris accepted D85773: [Driver][XRay][test] Update the macOS support check.

LGTM from me if XRay actually does work on non-x86_64 macOS.

Aug 11 2020, 5:01 PM · Restricted Project

Jul 26 2020

dberris accepted D84582: [XRay] Account: recursion detection.

LGTM -- thank you, and I'm happy this has been useful for your needs!

Jul 26 2020, 6:53 PM · Restricted Project

Jun 17 2020

dberris accepted D81995: [xray] Option to omit the function index.

LGTM

Jun 17 2020, 1:02 AM · Restricted Project, Restricted Project, Restricted Project

May 30 2020

dberris added a comment to D74362: Cheap Function Entry Instrumentation for Dead Code Detection.

A high-level comment: does this pass achieve something not doable with XRay, a mature instrumentation framework in LLVM?

May 30 2020, 6:34 PM · Restricted Project

Apr 21 2020

dberris added a comment to D78590: [XRay] Change ARM/AArch64/powerpc64le to use version 2 sled (PC-relative address).

@dberris xray_fn_idx is still using absolute relocations and thus must have the SHF_WRITE flag. If we are also going to make it read-only, how can we address compatibility issues in compiler-rt/lib/xray ?

Apr 21 2020, 8:01 PM · Restricted Project
dberris added a comment to D78595: [xray] Avoid text relocations in trampolines for ARM/AArch64.

I'll defer to @MaskRay on the ARM bits.

Apr 21 2020, 7:29 PM · Restricted Project
dberris accepted D78593: [xray] Use hidden symbol visibility for xray trampolines.

LGTM for the x86_64 bits.

Apr 21 2020, 7:29 PM · Restricted Project
dberris added a comment to D78596: [xray] Preserve x8 in trampoline on AArch64.

I'm not well versed in AArch64 assembler here, so I'll defer to @MaskRay who has more knowledge in this area.

Apr 21 2020, 7:29 PM · Restricted Project
dberris accepted D78082: [XRay] Change xray_instr_map sled addresses from absolute to PC relative for x86-64.

LGTM -- thanks!

Apr 21 2020, 3:12 AM · Restricted Project

Apr 16 2020

dberris added a comment to D78082: [XRay] Change xray_instr_map sled addresses from absolute to PC relative for x86-64.

LGTM, but I'm concerned about the backwards compatibility story.

We could pick a different section name. Do you have a suggestion? Doing that can change a lot of tests and I need some ack before moving toward that goal.

I want to avoid something like xray_instr_maps_ro because really the read-only section is commonplace, and I don't want to penalize the good readonly section name...

As I mentioned in the other inline comment, you can use the 'Version' field for each entry. If you increment the version number in the compiler, then you can change the runtime code to support some older versions. Doing that allows you to avoid renaming the section and maintaining some backwards compatibility.

Supporting two versions of Sled.Address can make the runtime overly complex I think?

--- a/compiler-rt/lib/xray/xray_interface.cpp
+++ b/compiler-rt/lib/xray/xray_interface.cpp
@@ -264,14 +264,14 @@ XRayPatchingStatus controlPatching(bool Enable) XRAY_NEVER_INSTRUMENT {
   // now we're assuming we can mprotect the whole section of text between the
   // minimum sled address and the maximum sled address (+ the largest sled
   // size).
-  auto MinSled = InstrMap.Sleds[0];
-  auto MaxSled = InstrMap.Sleds[InstrMap.Entries - 1];
+  auto *MinSled = &InstrMap.Sleds[0];
+  auto *MaxSled = &InstrMap.Sleds[InstrMap.Entries - 1];
   for (std::size_t I = 0; I < InstrMap.Entries; I++) {
     const auto &Sled = InstrMap.Sleds[I];
-    if (Sled.Address < MinSled.Address)
-      MinSled = Sled;
-    if (Sled.Address > MaxSled.Address)
-      MaxSled = Sled;
+    if (Sled.address() < MinSled->address())
+      MinSled = &Sled;
+    if (Sled.address() > MaxSled->address())
+      MaxSled = &Sled;
   }

One approach is to teach the member function about return Version < 1 ? Address : reinterpret_cast<uint64_t>(&Address) + Address; but this will impose overhead on every operation.

x86 CUSTOM_EVENT has used version 1. Bump versions of all SledKind's to 2?

--- a/llvm/lib/Target/X86/X86MCInstLower.cpp
+++ b/llvm/lib/Target/X86/X86MCInstLower.cpp
@@ -1510,7 +1510,7 @@ void X86AsmPrinter::LowerPATCHABLE_EVENT_CALL(const MachineInstr &MI,
   // Record the sled version. Older versions of this sled were spelled
   // differently, so we let the runtime handle the different offsets we're
   // using.
-  recordSled(CurSled, MI, SledKind::CUSTOM_EVENT, 1);
+  recordSled(CurSled, MI, SledKind::CUSTOM_EVENT, 2);
 }
Apr 16 2020, 6:23 PM · Restricted Project

Apr 14 2020

dberris added a comment to D78082: [XRay] Change xray_instr_map sled addresses from absolute to PC relative for x86-64.

LGTM, but I'm concerned about the backwards compatibility story.

We could pick a different section name. Do you have a suggestion? Doing that can change a lot of tests and I need some ack before moving toward that goal.

I want to avoid something like xray_instr_maps_ro because really the read-only section is commonplace, and I don't want to penalize the good readonly section name...

Apr 14 2020, 11:22 PM · Restricted Project
dberris added a comment to D78082: [XRay] Change xray_instr_map sled addresses from absolute to PC relative for x86-64.

LGTM, but I'm concerned about the backwards compatibility story.

Apr 14 2020, 8:40 PM · Restricted Project

Apr 13 2020

dberris accepted D77883: [llvm-xray][test] Combine two AArch64 tests.
Apr 13 2020, 10:44 AM · Restricted Project

Mar 31 2020

dberris accepted D77191: [clang][xray] Add xray attributes to functions without decls too.

LGTM

Mar 31 2020, 8:54 PM · Restricted Project

Feb 1 2020

dberris accepted D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs.
Feb 1 2020, 6:14 PM · Restricted Project

Jan 16 2020

dberris accepted D72890: [xray] Allow instrumenting only function entry and/or only function exit.

Do you mind adding x86 tests too?

Jan 16 2020, 6:43 PM · Restricted Project, Restricted Project

Jan 14 2020

dberris accepted D72659: [xray] Add xray-ignore-loops option.

I'm wondering how you're imbuing these attributes to the functions from the front-ends -- is this something you intend to support as a flag in Clang for example?

Jan 14 2020, 12:17 AM · Restricted Project

Dec 8 2019

dberris added a comment to D58621: [XRay][tools] Pack XRayRecord - reduce memory footprint by a third. (RFC).

Now, an alternative here is to migrate the Basic Mode implementation to use a more compact log record (i.e. using the FDR mode format), and use a different converter approach <..> This is a more intensive project but one that isn't terribly hard to accomplish. If you'd like to take that on, I'd be happy to review patches going in that direction instead

@dberris, is this still valid & desirable?
I would like to dip my toes into XRay/LLVM, and this seems like a good first mini project to me. :) This migration should also bring typed and custom events support for the basic mode, which is a nice bonus.

Dec 8 2019, 3:53 PM · Restricted Project

Nov 10 2019

dberris accepted D69461: [XRay] Sanitize DOT labels in graph output.

I compiled multiple older versions of dot and gave them a try (I went back to 2.30.1) but still didn't see this problem. I've been testing like this (mainly testing SVG and JSON):

tetsuo@garland-1572667608860-c-16-sgp1-01:~/dev/llvm-project$ build/bin/llvm-xray graph ./xray-log.a.out.uRHPKt -instr_map ./a.out | dot -Tsvg

@dberris Since I can't reproduce this, should I abandon this revision? Or would you still like the patch.

Nov 10 2019, 3:02 PM · Restricted Project

Nov 7 2019

dberris accepted D69967: [llvm-xray] Add AArch64 to llvm-xray extract.

LGTM

Nov 7 2019, 1:47 PM · Restricted Project

Oct 27 2019

dberris accepted D69365: [X86] Use 64-bit version of source register in LowerPATCHABLE_EVENT_CALL and LowerPATCHABLE_TYPED_EVENT_CALL.

Do you have any suggestions on how to achieve what the FIXME'ed areas are attempting to do?

Oct 27 2019, 3:09 PM · Restricted Project
dberris accepted D69461: [XRay] Sanitize DOT labels in graph output.

LGTM with one nit. Thanks!

Oct 27 2019, 3:06 PM · Restricted Project
dberris accepted D69386: [xray] Remove cl::sub from alias options.

LGTM -- Thanks!

Oct 27 2019, 3:06 PM · Restricted Project

Aug 27 2019

dberris accepted D66561: [X86] Remove encoding information from the TAILJMP instructions that are lowered by MCInstLowering. Fix LowerPATCHABLE_TAIL_CALL to also convert them to regular JMP/JCC instructions.

LGTM from the XRay parts.

Aug 27 2019, 2:15 AM · Restricted Project
dberris accepted D61758: [driver][xray] fix the macOS support checker by supporting -macos triple in addition to -darwin.

LGTM -- apologies for the delay, I hope this isn't too late.

Aug 27 2019, 2:00 AM · Restricted Project, Restricted Project
dberris added a comment to D63973: [MachineVerifier] Improve checks of target instructions operands..

Thanks, this LGTM. I quickly looked at the X86 tests, it seems that PATCHABLE_EVENT_CALL and PATCHABLE_TYPED_EVENT_CALL are always created with a register but expect immediates in Target.td. I'm not sure what was the intention so I'll leave it to @dberris.

Aug 27 2019, 1:45 AM · Restricted Project

Aug 25 2019

dberris added a comment to D66561: [X86] Remove encoding information from the TAILJMP instructions that are lowered by MCInstLowering. Fix LowerPATCHABLE_TAIL_CALL to also convert them to regular JMP/JCC instructions.

I don't see the XRay specific changes... is there something I specifically need to look at here? Looks like the patchable tail call stuff is untouched.

Aug 25 2019, 7:51 PM · Restricted Project

Jun 25 2019

dberris accepted D61946: [xray] Remove usage of procid_t.

LGTM -- really sorry for the delay here, for some reason I didn't get to this earlier. :(

Jun 25 2019, 11:43 PM · Restricted Project

Jun 23 2019

dberris accepted D63658: [compiler-rt] Rename lit.*.cfg.* -> lit.*.cfg.py.*.

LGTM

Jun 23 2019, 8:21 PM · Restricted Project, Restricted Project

Apr 25 2019

dberris accepted D61016: [lit][tests]Add libc++ to link XRay test cases if libc++ is used to build CLANG.

LGTM -- thanks for looking into this!

Apr 25 2019, 7:18 PM · Restricted Project

Feb 27 2019

dberris planned changes to D56383: [XRay][tools] Use symbols instead of function id.

Gentle ping for author, has this landed or still in the backlog? (If it's landed can you attach the commit and close it, please? Just trying to to avoid diffs on Phab going stale.)

Feb 27 2019, 2:40 PM · Restricted Project

Feb 26 2019

dberris added a comment to D58621: [XRay][tools] Pack XRayRecord - reduce memory footprint by a third. (RFC).

This is a RFC because of the uint8_t CPU change.
That chance needs discussing.

So, this is an accident of history, which should be changed, but to the other direction. I've learned some time ago that it turns out there are some platforms that can have enough CPU IDs which can't be represented by a uint8_t. For future-proofing, we really should change this to be larger (uint16_t) and change basic mode to store 16-bit CPU IDs.

Boo :)

Boo indeed. :)

Unfortunately that won't just cost that one extra byte, it will have ripple effect on the padding in this struct.
I'm not sure as to exact numbers.

I like the idea of reducing top-line memory requirements, but it shouldn't be at the cost of functionality. The current state is a bug that we're only using 8 bits for the CPU ID.

No, i totally understand.
That is why i said it's RFC and is only valid if it is actually
only ever 8 bits. (which it is, but only due to the bug elsewhere)
I think this is still worth it even with 16-bit CPU, i'll take a look.

Now, an alternative here is to migrate the Basic Mode implementation to use a more compact log record (i.e. using the FDR mode format), and use a different converter approach, one that doesn't require reconstituting the whole Trace consisting of XRayRecord instances. The FDR log loading libraries/framework allow us to do this now (see llvm-xray fdr-dump). This is a more intensive project but one that isn't terribly hard to accomplish. If you'd like to take that on, I'd be happy to review patches going in that direction instead (really the only difference between the current basic mode implementation and the FDR mode implementation is that, basic mode threads returning a buffer to the queue will write out the contents before returning the buffer to the central buffer queue). In that process we can migrate FDR mode to use 16-bit CPU IDs.

So it's basically three co-dependent steps:

  1. Teach xray convert to also work on FDR input
  2. Afterwards, switch the compiler-rt X-Ray basic log to output FDR log format.
  3. Finally, fix the truncation of CPU id in the compiler-rt xray code
Feb 26 2019, 1:17 PM · Restricted Project

Feb 25 2019

dberris added a comment to D58621: [XRay][tools] Pack XRayRecord - reduce memory footprint by a third. (RFC).

This is a RFC because of the uint8_t CPU change.
That chance needs discussing.

So, this is an accident of history, which should be changed, but to the other direction. I've learned some time ago that it turns out there are some platforms that can have enough CPU IDs which can't be represented by a uint8_t. For future-proofing, we really should change this to be larger (uint16_t) and change basic mode to store 16-bit CPU IDs.

Boo :)

Feb 25 2019, 5:18 PM · Restricted Project
dberris added a comment to D58621: [XRay][tools] Pack XRayRecord - reduce memory footprint by a third. (RFC).

This is a RFC because of the uint8_t CPU change.
That chance needs discussing.

Feb 25 2019, 1:15 PM · Restricted Project

Feb 24 2019

dberris accepted D58584: [XRay][tools] Revert "Use Support/JSON.h in llvm-xray convert".

What I wish existed was a stateful JSON output stream implementation instead of the build-everything-in-memory model. Maybe someday. :)

Feb 24 2019, 1:49 PM · Restricted Project

Feb 12 2019

dberris accepted D58144: [xray][tests][RHDTS] Add -lstdc++ after LLVM libs, resolving link error with RHDTS.

LGTM

Feb 12 2019, 2:42 PM · Restricted Project, Restricted Project

Feb 11 2019

dberris accepted D58086: [CMake][XRay] Silence llvm-config error when checking library support.

LGTM

Feb 11 2019, 5:03 PM · Restricted Project, Restricted Project

Jan 31 2019

dberris accepted D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests.

LGTM

Jan 31 2019, 2:09 PM · Restricted Project, Restricted Project

Jan 24 2019

dberris accepted D57181: Fix XRayTest link on FreeBSD (and likely NetBSD too).

LGTM

Jan 24 2019, 4:57 PM

Jan 17 2019

dberris accepted D56797: xray: Add missing header to list of installed headers..

LGTM -- thanks! Yes, this should have been public all along.

Jan 17 2019, 1:43 AM

Jan 7 2019

dberris updated the diff for D56244: [XRay][docs] XRay Framework Usage Guide.

More updates to address some comments.

Jan 7 2019, 9:26 PM
dberris added inline comments to D56244: [XRay][docs] XRay Framework Usage Guide.
Jan 7 2019, 9:07 PM
dberris updated the diff for D56244: [XRay][docs] XRay Framework Usage Guide.

Address comments by @greened.

Jan 7 2019, 9:07 PM
dberris created D56383: [XRay][tools] Use symbols instead of function id.
Jan 7 2019, 3:44 AM · Restricted Project

Jan 3 2019

dberris updated the diff for D56244: [XRay][docs] XRay Framework Usage Guide.

Update description.

Jan 3 2019, 6:46 PM

Jan 2 2019

dberris updated the diff for D56244: [XRay][docs] XRay Framework Usage Guide.

Add link to new doc in index.

Jan 2 2019, 10:05 PM
dberris created D56244: [XRay][docs] XRay Framework Usage Guide.
Jan 2 2019, 10:03 PM

Dec 21 2018

dberris added inline comments to D56000: [compiler-rt] [xray] Disable alignas() for thread_local objects on NetBSD.
Dec 21 2018, 4:10 PM

Dec 20 2018

dberris accepted D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully.

LGTM

Dec 20 2018, 6:59 PM · Restricted Project

Dec 19 2018

dberris accepted D55842: Let TableGen write output only if it changed, instead of doing so in cmake, attempt 2.

LGTM -- cannot reproduce the original issue with this patch.

Dec 19 2018, 1:42 AM · Restricted Project
dberris added a comment to D55842: Let TableGen write output only if it changed, instead of doing so in cmake, attempt 2.

Apologies for the delay, but I'm giving this a go now.

Dec 19 2018, 1:27 AM · Restricted Project

Dec 13 2018

dberris accepted D55691: [Object] Rename getRelrRelocationType to getRelativeRelocationType.

LGTM

Dec 13 2018, 11:46 PM
dberris accepted D55689: [llvm-xray] Store offset pointers in temporaries.

LGTM

Dec 13 2018, 9:34 PM
dberris accepted D55542: [llvm-xray] Support for PIE.

LGTM still, thanks @phosek!

Dec 13 2018, 5:19 PM

Dec 11 2018

dberris accepted D55548: [XRay] Add a helper function sortByKey to simplify code.

LGTM -- Thanks @MaskRay!

Dec 11 2018, 4:09 AM

Dec 10 2018

dberris accepted D55542: [llvm-xray] Support for PIE.

LGTM -- Thanks @phosek!

Dec 10 2018, 8:25 PM

Dec 6 2018

dberris committed rCRT348568: [XRay] Use preallocated memory for XRay profiling.
[XRay] Use preallocated memory for XRay profiling
Dec 6 2018, 10:26 PM
dberris committed rL348568: [XRay] Use preallocated memory for XRay profiling.
[XRay] Use preallocated memory for XRay profiling
Dec 6 2018, 10:26 PM
dberris closed D55249: [XRay] Use preallocated memory for XRay profiling.
Dec 6 2018, 10:26 PM
dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Rebase again. This is now ready for another look.

Dec 6 2018, 10:01 PM
dberris committed rCRT348563: Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 6 2018, 7:22 PM
dberris committed rL348563: Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 6 2018, 7:22 PM

Dec 5 2018

dberris committed rCRT348455: Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 5 2018, 7:32 PM
dberris committed rL348455: Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Revert "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 5 2018, 7:32 PM
dberris committed rL348449: [XRay] Use a local lvalue as arg to AppendEmplace(...).
[XRay] Use a local lvalue as arg to AppendEmplace(...)
Dec 5 2018, 6:58 PM
dberris committed rCRT348449: [XRay] Use a local lvalue as arg to AppendEmplace(...).
[XRay] Use a local lvalue as arg to AppendEmplace(...)
Dec 5 2018, 6:58 PM
dberris committed rCRT348445: [XRay] Use default-constructed struct as argument to Append(...).
[XRay] Use default-constructed struct as argument to Append(...)
Dec 5 2018, 5:59 PM
dberris committed rL348445: [XRay] Use default-constructed struct as argument to Append(...).
[XRay] Use default-constructed struct as argument to Append(...)
Dec 5 2018, 5:59 PM
dberris committed rCRT348438: Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 5 2018, 4:29 PM
dberris committed rL348438: Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array".
Re-land r348335 "[XRay] Move-only Allocator, FunctionCallTrie, and Array"
Dec 5 2018, 4:29 PM

Dec 4 2018

dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Rebase.

Dec 4 2018, 11:29 PM
dberris committed rL348338: [XRay] Use uptr instead of uintptr_t.
[XRay] Use uptr instead of uintptr_t
Dec 4 2018, 11:17 PM
dberris committed rCRT348338: [XRay] Use uptr instead of uintptr_t.
[XRay] Use uptr instead of uintptr_t
Dec 4 2018, 11:17 PM
dberris committed rL348336: [XRay] Use deallocateBuffer instead of deallocate.
[XRay] Use deallocateBuffer instead of deallocate
Dec 4 2018, 11:08 PM
dberris committed rCRT348336: [XRay] Use deallocateBuffer instead of deallocate.
[XRay] Use deallocateBuffer instead of deallocate
Dec 4 2018, 11:08 PM
dberris updated the diff for D55249: [XRay] Use preallocated memory for XRay profiling.

Addressing comment by @mboerger.

Dec 4 2018, 10:57 PM
dberris committed rL348335: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
[XRay] Move-only Allocator, FunctionCallTrie, and Array
Dec 4 2018, 10:48 PM
dberris committed rCRT348335: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
[XRay] Move-only Allocator, FunctionCallTrie, and Array
Dec 4 2018, 10:47 PM
dberris closed D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Dec 4 2018, 10:47 PM

Dec 3 2018

dberris created D55249: [XRay] Use preallocated memory for XRay profiling.
Dec 3 2018, 9:12 PM

Nov 28 2018

dberris added inline comments to D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Nov 28 2018, 12:33 AM
dberris updated the diff for D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.

Addressing comments by @mboerger.

Nov 28 2018, 12:32 AM

Nov 27 2018

dberris created D54989: [XRay] Move-only Allocator, FunctionCallTrie, and Array.
Nov 27 2018, 9:36 PM

Nov 21 2018

dberris accepted D54784: Use --push/pop-state with XRay link deps.

LGTM

Nov 21 2018, 6:51 PM · Restricted Project

Nov 20 2018

dberris committed rCRT347368: [XRay] Add a test for re-initialising FDR mode (NFC).
[XRay] Add a test for re-initialising FDR mode (NFC)
Nov 20 2018, 4:33 PM
dberris committed rL347368: [XRay] Add a test for re-initialising FDR mode (NFC).
[XRay] Add a test for re-initialising FDR mode (NFC)
Nov 20 2018, 4:33 PM

Nov 19 2018

dberris committed rCRT347286: [XRay] Add a test for allocator exhaustion.
[XRay] Add a test for allocator exhaustion
Nov 19 2018, 7:58 PM
dberris committed rL347286: [XRay] Add a test for allocator exhaustion.
[XRay] Add a test for allocator exhaustion
Nov 19 2018, 7:58 PM
dberris committed rCRT347280: [XRay] Move buffer extents back to the heap.
[XRay] Move buffer extents back to the heap
Nov 19 2018, 5:05 PM
dberris committed rL347280: [XRay] Move buffer extents back to the heap.
[XRay] Move buffer extents back to the heap
Nov 19 2018, 5:05 PM
dberris closed D54684: [XRay] Move buffer extents back to the heap.
Nov 19 2018, 5:05 PM
dberris updated the diff for D54684: [XRay] Move buffer extents back to the heap.

clang-format with LLVM style

Nov 19 2018, 3:38 PM
dberris added inline comments to D54684: [XRay] Move buffer extents back to the heap.
Nov 19 2018, 2:00 PM

Nov 18 2018

dberris created D54684: [XRay] Move buffer extents back to the heap.
Nov 18 2018, 9:33 PM