Page MenuHomePhabricator

Mark override to a function which overrides a virtual one
ClosedPublic

Authored by anhtuyen on Jul 28 2020, 1:14 PM.

Details

Summary

Function void run() on line 286 overrides a virtual function on line 92.
Not marking it override will cause a build failure when we use -Werror (every warning is treated as an error).

Diff Detail

Event Timeline

anhtuyen created this revision.Jul 28 2020, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 1:14 PM
anhtuyen requested review of this revision.Jul 28 2020, 1:14 PM
kbobyrev accepted this revision.Jul 28 2020, 3:54 PM

Thanks!

This revision is now accepted and ready to land.Jul 28 2020, 3:54 PM