Page MenuHomePhabricator

[X86] Merge disp8 and cdisp8 handling into a single helper function to reduce some code.
ClosedPublic

Authored by craig.topper on Jul 27 2020, 11:52 PM.

Details

Summary

We currently handle EVEX and non-EVEX separately in two places. By sinking the EVEX
check into the existing helper for CDisp8 we can simplify these two places.

Diff Detail

Unit TestsFailed

TimeTest
160 mslinux > Polly.ScopInfo::memcpy-raw-source.ll
Script: -- : 'RUN: at line 1'; opt -polly-process-unprofitable -polly-remarks-minimal -polly-use-llvm-names -polly-import-jscop-dir=/mnt/disks/ssd0/agent/llvm-project/polly/test/ScopInfo -polly-codegen-verify -basic-aa -scoped-noalias -tbaa -polly-scops -analyze < /mnt/disks/ssd0/agent/llvm-project/polly/test/ScopInfo/memcpy-raw-source.ll

Event Timeline

craig.topper created this revision.Jul 27 2020, 11:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2020, 11:52 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2020, 12:36 AM
Harbormaster failed remote builds in B65964: Diff 281124!
craig.topper requested review of this revision.Jul 28 2020, 6:04 AM
RKSimon accepted this revision.Jul 28 2020, 8:28 AM

LGTM

This revision is now accepted and ready to land.Jul 28 2020, 8:28 AM
This revision was landed with ongoing or failed builds.Jul 28 2020, 10:46 AM
This revision was automatically updated to reflect the committed changes.