Page MenuHomePhabricator

[clang-tidy][NFC] Replace comment by private method
ClosedPublic

Authored by hanneskaeufler on Sat, Jul 25, 2:34 PM.

Details

Summary

The comment is better served with a small private
method, helping scannability of the code and
hiding irrelevant details about the private members.

Diff Detail

Event Timeline

hanneskaeufler created this revision.Sat, Jul 25, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Jul 25, 2:34 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
hanneskaeufler retitled this revision from Replace comment by private method to [clang-tidy] Replace comment by private method.

Fix syntax error (add return type)

Eugene.Zelenko added a project: Restricted Project.
njames93 retitled this revision from [clang-tidy] Replace comment by private method to [clang-tidy][NFC] Replace comment by private method.Sun, Jul 26, 7:13 AM
This revision is now accepted and ready to land.Sun, Jul 26, 7:46 AM

LGTM!

Awesome, thanks!

LGTM!

Awesome, thanks!

Do you need someone to commit on your behalf? If so, can you give me the name and email address you'd like me to attribute the commit to (I've got Hannes Käufler <hannes.kaeufler@gmail.com>)?

LGTM!

Awesome, thanks!

Do you need someone to commit on your behalf? If so, can you give me the name and email address you'd like me to attribute the commit to (I've got Hannes Käufler <hannes.kaeufler@gmail.com>)?

Uh, yeah, I don't suppose I have commit rights. First time contributor here :) Name and E-Mail is correct!

LGTM!

Awesome, thanks!

Do you need someone to commit on your behalf? If so, can you give me the name and email address you'd like me to attribute the commit to (I've got Hannes Käufler <hannes.kaeufler@gmail.com>)?

Uh, yeah, I don't suppose I have commit rights. First time contributor here :) Name and E-Mail is correct!

Thank you for the patch! I've committed on your behalf in 3bbf3e026d3c692966583075ae6d12c4575e9d72.