Page MenuHomePhabricator

[mlir][NFC] Polish copy removal transform
ClosedPublic

Authored by dfki-ehna on Jul 24 2020, 6:48 AM.

Details

Summary

Address a few remaining comments in copy removal transform.

Diff Detail

Event Timeline

dfki-ehna created this revision.Jul 24 2020, 6:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2020, 6:48 AM

Is this an NFC patch?

mlir/lib/Transforms/CopyRemoval.cpp
81

Please !operations.empty() (doesn't make a difference for ArrayRef but in general).

herhut accepted this revision.Jul 27 2020, 2:12 AM

Maybe mark it as NFC. Looks good with @bondhugula's comment addressed.

This revision is now accepted and ready to land.Jul 27 2020, 2:12 AM

Address the comments.

dfki-ehna retitled this revision from [mlir] Polish copy removal transform to [mlir][NFC] Polish copy removal transform.Jul 27 2020, 11:32 PM
dfki-ehna marked an inline comment as done.
This revision was landed with ongoing or failed builds.Jul 27 2020, 11:36 PM
This revision was automatically updated to reflect the committed changes.