Page MenuHomePhabricator

pifon2a (Alexander Belyaev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2020, 1:48 AM (37 w, 3 d)

Recent Activity

Yesterday

pifon2a accepted D88083: [mlir] Add file to implement bufferization for shape ops..
Sat, Sep 26, 3:10 AM · Restricted Project

Thu, Sep 24

pifon2a committed rGa90d72127a81: [llvm] Use instead of in IRSimilarityIdentifierTest.cpp. (authored by pifon2a).
[llvm] Use instead of in IRSimilarityIdentifierTest.cpp.
Thu, Sep 24, 2:29 AM
pifon2a committed rG56ffb8d16979: [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp. (authored by pifon2a).
[mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp.
Thu, Sep 24, 2:17 AM
pifon2a closed D88147: [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp..
Thu, Sep 24, 2:16 AM · Restricted Project

Wed, Sep 23

pifon2a added inline comments to D88147: [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp..
Wed, Sep 23, 11:12 AM · Restricted Project
pifon2a updated the diff for D88147: [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp..

Removed todo

Wed, Sep 23, 8:33 AM · Restricted Project
pifon2a requested review of D88147: [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp..
Wed, Sep 23, 5:47 AM · Restricted Project

Tue, Sep 22

pifon2a added a comment to D88080: [MLIR][Linalg] Fix assertion in dependency analysis.

What does it mean for a linalg op to take unranked memref?
In particular, a linalg op has indexing_maps. of fixed rank.
How would that work with unranked stuff ?

Tue, Sep 22, 3:35 AM · Restricted Project
pifon2a accepted D88080: [MLIR][Linalg] Fix assertion in dependency analysis.
Tue, Sep 22, 3:05 AM · Restricted Project
pifon2a accepted D88079: Revert "Implement a new kind of Pass: dynamic pass pipeline".
Tue, Sep 22, 2:57 AM · Restricted Project

Mon, Sep 21

pifon2a added a reverting change for rG0345d88de654: [NFC][ScheduleDAG] Remove unused EntrySU SUnit: rG17dc729bd429: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".
Mon, Sep 21, 4:34 AM
pifon2a committed rG17dc729bd429: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit" (authored by pifon2a).
Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit"
Mon, Sep 21, 4:34 AM
pifon2a added a reverting change for D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit: rG17dc729bd429: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".
Mon, Sep 21, 4:34 AM · Restricted Project
pifon2a closed D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".
Mon, Sep 21, 4:34 AM · Restricted Project
pifon2a added a reviewer for D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit": bkramer.
Mon, Sep 21, 4:29 AM · Restricted Project
pifon2a updated the summary of D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".
Mon, Sep 21, 4:28 AM · Restricted Project
pifon2a updated the diff for D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".

Update description.

Mon, Sep 21, 4:27 AM · Restricted Project
pifon2a added a reverting change for rG0345d88de654: [NFC][ScheduleDAG] Remove unused EntrySU SUnit: D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".
Mon, Sep 21, 4:22 AM
pifon2a requested review of D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".
Mon, Sep 21, 4:22 AM · Restricted Project
pifon2a added a reverting change for D87867: [NFC][ScheduleDAG] Remove unused EntrySU SUnit: D88018: Revert "[NFC][ScheduleDAG] Remove unused EntrySU SUnit".
Mon, Sep 21, 4:22 AM · Restricted Project
pifon2a requested changes to D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Mon, Sep 21, 1:44 AM · Restricted Project
pifon2a added inline comments to D87756: [mlir] Refactored BufferPlacement transformation into BufferDeallocation and BufferHoisting..
Mon, Sep 21, 1:44 AM · Restricted Project

Wed, Sep 9

pifon2a abandoned D87377: [mlir][gpu] Fix `gpu.launch_func` arg promotion for LLVM Dialect args..
Wed, Sep 9, 9:54 AM · Restricted Project
pifon2a requested review of D87377: [mlir][gpu] Fix `gpu.launch_func` arg promotion for LLVM Dialect args..
Wed, Sep 9, 6:43 AM · Restricted Project

Mon, Sep 7

pifon2a accepted D87128: [mlir] Fix bug in copy removal.
Mon, Sep 7, 1:41 AM · Restricted Project

Aug 13 2020

pifon2a accepted D85899: [mlir] do not emit bitcasts between structs in StandardToLLVM.
Aug 13 2020, 11:14 AM · Restricted Project
pifon2a added a comment to D85899: [mlir] do not emit bitcasts between structs in StandardToLLVM.

Thank you, Alex. There are also a couple of redundant bitcasts in LHLO memref cast ops -> llvm conversion. That reminds me to clean them up as well.

Aug 13 2020, 11:14 AM · Restricted Project
pifon2a committed rGfed9ff511711: [mlir] Test CallOp STD->LLVM conversion. (authored by pifon2a).
[mlir] Test CallOp STD->LLVM conversion.
Aug 13 2020, 10:14 AM
pifon2a closed D85914: [mlir] Test CallOp STD->LLVM conversion..
Aug 13 2020, 10:14 AM · Restricted Project
pifon2a updated the summary of D85914: [mlir] Test CallOp STD->LLVM conversion..
Aug 13 2020, 9:57 AM · Restricted Project
pifon2a updated the summary of D85914: [mlir] Test CallOp STD->LLVM conversion..
Aug 13 2020, 9:57 AM · Restricted Project
pifon2a updated the summary of D85914: [mlir] Test CallOp STD->LLVM conversion..
Aug 13 2020, 9:56 AM · Restricted Project
pifon2a updated the summary of D85914: [mlir] Test CallOp STD->LLVM conversion..
Aug 13 2020, 9:56 AM · Restricted Project
pifon2a updated the summary of D85914: [mlir] Test CallOp STD->LLVM conversion..
Aug 13 2020, 9:55 AM · Restricted Project
pifon2a requested review of D85914: [mlir] Test CallOp STD->LLVM conversion..
Aug 13 2020, 9:54 AM · Restricted Project

Aug 7 2020

pifon2a committed rG9c9490832054: BEGIN_PUBLIC (authored by pifon2a).
BEGIN_PUBLIC
Aug 7 2020, 5:33 AM
pifon2a closed D85518: BEGIN_PUBLIC [mlir] Add support for unranked case for `tensor_store` and `tensor_load` ops. END_PUBLIC.
Aug 7 2020, 5:33 AM · Restricted Project
pifon2a updated the diff for D85518: BEGIN_PUBLIC [mlir] Add support for unranked case for `tensor_store` and `tensor_load` ops. END_PUBLIC.

Address the comments.

Aug 7 2020, 5:31 AM · Restricted Project
pifon2a requested review of D85518: BEGIN_PUBLIC [mlir] Add support for unranked case for `tensor_store` and `tensor_load` ops. END_PUBLIC.
Aug 7 2020, 5:02 AM · Restricted Project
pifon2a added inline comments to D85133: [mlir] Extend BufferAssignmentTypeConverter with result conversion callbacks.
Aug 7 2020, 3:19 AM · Restricted Project

Aug 6 2020

pifon2a committed rG3effc35015ce: [mlir] Lower DimOp to LLVM for unranked memrefs. (authored by pifon2a).
[mlir] Lower DimOp to LLVM for unranked memrefs.
Aug 6 2020, 2:46 AM
pifon2a closed D85361: [mlir] Lower DimOp to LLVM for unranked memrefs..
Aug 6 2020, 2:46 AM · Restricted Project
pifon2a added inline comments to D85361: [mlir] Lower DimOp to LLVM for unranked memrefs..
Aug 6 2020, 1:35 AM · Restricted Project
pifon2a updated the diff for D85361: [mlir] Lower DimOp to LLVM for unranked memrefs..

Address the comments and fix mlir-cpu-runner tests in cmake.

Aug 6 2020, 1:35 AM · Restricted Project
pifon2a updated the diff for D85361: [mlir] Lower DimOp to LLVM for unranked memrefs..

lint

Aug 6 2020, 12:16 AM · Restricted Project

Aug 5 2020

pifon2a requested review of D85361: [mlir] Lower DimOp to LLVM for unranked memrefs..
Aug 5 2020, 2:03 PM · Restricted Project
pifon2a committed rG9fdd0df9497e: [mlir][nfc] Rename `promoteMemRefDescriptors` to `promoteOperands`. (authored by pifon2a).
[mlir][nfc] Rename `promoteMemRefDescriptors` to `promoteOperands`.
Aug 5 2020, 11:25 AM
pifon2a closed D85325: [mlir][nfc] Rename `promoteMemRefDescriptors` to `promoteOperands`..
Aug 5 2020, 11:25 AM · Restricted Project
pifon2a accepted D85306: [MLIR][Shape] Add custom assembly format for `shape.any`.
Aug 5 2020, 10:54 AM · Restricted Project
pifon2a updated the summary of D85325: [mlir][nfc] Rename `promoteMemRefDescriptors` to `promoteOperands`..
Aug 5 2020, 9:44 AM · Restricted Project
pifon2a requested review of D85325: [mlir][nfc] Rename `promoteMemRefDescriptors` to `promoteOperands`..
Aug 5 2020, 9:43 AM · Restricted Project
pifon2a added a comment to D85192: [mlir] Fix adding wrong operand value in `promoteMemRefDescriptors`..

It looks like it would require using TestDialect and writing a test pass from test dialect to llvm. Could there be a simpler way of testing this?

How did you stumble upon this? I think this function is called when an std.call is converted, so it should be sufficient to test that an std.call to a function that takes a mix of memrefs and scalars as arguments.

Aug 5 2020, 9:38 AM · Restricted Project
pifon2a committed rGbc7456fd8a11: [mlir] Fix rank bitwidth in UnrankedMemRefType conversion. (authored by pifon2a).
[mlir] Fix rank bitwidth in UnrankedMemRefType conversion.
Aug 5 2020, 9:36 AM
pifon2a closed D85300: [mlir] Fix rank bitwidth in UnrankedMemRefType conversion..
Aug 5 2020, 9:35 AM · Restricted Project
pifon2a added a comment to D85192: [mlir] Fix adding wrong operand value in `promoteMemRefDescriptors`..

Can you add a test please?

Aug 5 2020, 9:26 AM · Restricted Project
pifon2a added inline comments to D85306: [MLIR][Shape] Add custom assembly format for `shape.any`.
Aug 5 2020, 7:47 AM · Restricted Project
pifon2a added inline comments to D85273: [mlir] Lower RankOp to LLVM for unranked memrefs..
Aug 5 2020, 6:31 AM · Restricted Project
pifon2a requested review of D85300: [mlir] Fix rank bitwidth in UnrankedMemRefType conversion..
Aug 5 2020, 6:31 AM · Restricted Project
pifon2a added inline comments to D85273: [mlir] Lower RankOp to LLVM for unranked memrefs..
Aug 5 2020, 6:02 AM · Restricted Project
pifon2a committed rGa3d427d30cd3: [mlir] Lower RankOp to LLVM for unranked memrefs. (authored by pifon2a).
[mlir] Lower RankOp to LLVM for unranked memrefs.
Aug 5 2020, 3:14 AM
pifon2a closed D85273: [mlir] Lower RankOp to LLVM for unranked memrefs..
Aug 5 2020, 3:14 AM · Restricted Project
pifon2a updated the diff for D85273: [mlir] Lower RankOp to LLVM for unranked memrefs..

Lint

Aug 5 2020, 3:13 AM · Restricted Project
pifon2a updated the diff for D85273: [mlir] Lower RankOp to LLVM for unranked memrefs..

Test

Aug 5 2020, 3:12 AM · Restricted Project
pifon2a updated the diff for D85273: [mlir] Lower RankOp to LLVM for unranked memrefs..

Address the comments.

Aug 5 2020, 3:11 AM · Restricted Project

Aug 4 2020

pifon2a requested review of D85273: [mlir] Lower RankOp to LLVM for unranked memrefs..
Aug 4 2020, 9:29 PM · Restricted Project
pifon2a committed rG8979a9cdf226: [mlir] Fix adding wrong operand value in `promoteMemRefDescriptors`. (authored by pifon2a).
[mlir] Fix adding wrong operand value in `promoteMemRefDescriptors`.
Aug 4 2020, 4:40 AM
pifon2a closed D85192: [mlir] Fix adding wrong operand value in `promoteMemRefDescriptors`..
Aug 4 2020, 4:40 AM · Restricted Project
pifon2a requested review of D85192: [mlir] Fix adding wrong operand value in `promoteMemRefDescriptors`..
Aug 4 2020, 4:35 AM · Restricted Project

Aug 3 2020

pifon2a accepted D85121: [MLIR][Shape] Expose extent tensor type builder.
Aug 3 2020, 4:48 AM · Restricted Project

Jul 31 2020

pifon2a added a comment to D84918: [mlir] Add TFFramework dialect to DialectSymbolRegistry..

If you are just experimenting with it, you can use one of the PRIVATE_EXPERIMENTAL one, otherwise this is intended to be "cheap" to add.

Jul 31 2020, 2:03 AM · Restricted Project
pifon2a committed rG4d6eec8e70fb: [mlir] Add TFFramework dialect to DialectSymbolRegistry. (authored by pifon2a).
[mlir] Add TFFramework dialect to DialectSymbolRegistry.
Jul 31 2020, 2:01 AM
pifon2a closed D84918: [mlir] Add TFFramework dialect to DialectSymbolRegistry..
Jul 31 2020, 2:01 AM · Restricted Project

Jul 30 2020

pifon2a committed rG6b8c641d8ea2: [mlir] NFC: Expose `getElementPtrType` and `getSizes` methods of… (authored by pifon2a).
[mlir] NFC: Expose `getElementPtrType` and `getSizes` methods of…
Jul 30 2020, 11:19 AM
pifon2a closed D84917: [mlir] NFC: Expose `getElementPtrType` and `getSizes` methods of AllocOpLowering..
Jul 30 2020, 11:18 AM · Restricted Project
pifon2a updated the diff for D84917: [mlir] NFC: Expose `getElementPtrType` and `getSizes` methods of AllocOpLowering..

Address the comments.

Jul 30 2020, 11:17 AM · Restricted Project
pifon2a updated the diff for D84917: [mlir] NFC: Expose `getElementPtrType` and `getSizes` methods of AllocOpLowering..

Fix linter.

Jul 30 2020, 5:39 AM · Restricted Project
pifon2a updated the diff for D84917: [mlir] NFC: Expose `getElementPtrType` and `getSizes` methods of AllocOpLowering..

Address the comments.

Jul 30 2020, 4:46 AM · Restricted Project
pifon2a updated the diff for D84917: [mlir] NFC: Expose `getElementPtrType` and `getSizes` methods of AllocOpLowering..

Split getSizes() into getMemRefDescriptorsizes and getCumulativeSizeInBytes.

Jul 30 2020, 4:06 AM · Restricted Project
pifon2a requested review of D84918: [mlir] Add TFFramework dialect to DialectSymbolRegistry..
Jul 30 2020, 1:47 AM · Restricted Project
pifon2a requested review of D84917: [mlir] NFC: Expose `getElementPtrType` and `getSizes` methods of AllocOpLowering..
Jul 30 2020, 1:45 AM · Restricted Project

Jul 23 2020

pifon2a accepted D84435: [MLIR][Shape] Allow `get_extent` to operate on extent tensors and indices.
Jul 23 2020, 9:55 AM · Restricted Project
pifon2a accepted D84436: [MLIR][Shape] Remove deprecated and unused lowerings.
Jul 23 2020, 9:54 AM · Restricted Project
pifon2a accepted D84437: [MLIR][Shape] Allow `shape.mul` to operate in indices.
Jul 23 2020, 9:54 AM · Restricted Project
pifon2a accepted D84438: [MLIR][Shape] Fold `shape.mul`.
Jul 23 2020, 9:54 AM · Restricted Project
pifon2a accepted D84439: [MLIR][Shape] Refactor verification.
Jul 23 2020, 9:53 AM · Restricted Project
pifon2a accepted D84441: [MLIR][Shape] Allow `shape.add` to operate on indices.
Jul 23 2020, 9:52 AM · Restricted Project
pifon2a accepted D84442: [MLIR][Shape] Remove type conversion from lowering to standard.
Jul 23 2020, 9:52 AM · Restricted Project
pifon2a accepted D84443: [MLIR][Shape] Limit shape to standard lowerings to their supported types.
Jul 23 2020, 9:51 AM · Restricted Project
pifon2a accepted D84444: [MLIR][Shape] Limit shape to SCF lowering patterns to their supported types.
Jul 23 2020, 9:51 AM · Restricted Project
pifon2a accepted D84445: [MLIR][Shape] Allow `num_elements` to operate on extent tensors.
Jul 23 2020, 9:50 AM · Restricted Project
pifon2a accepted D84431: [MLIR][Shape] Limit `shape.rank` lowering to its extent tensor variant.
Jul 23 2020, 9:35 AM · Restricted Project
pifon2a accepted D84433: [MLIR][Shape] Allow `shape.any` to operate on extent tensors.
Jul 23 2020, 9:34 AM · Restricted Project
pifon2a accepted D84430: [MLIR][Shape] Pass Ops instead of Operations in shape lowering.
Jul 23 2020, 9:32 AM · Restricted Project
pifon2a accepted D84429: [MLIR][Shape] Allow `shape.rank` to operate on extent tensors.
Jul 23 2020, 9:31 AM · Restricted Project
pifon2a accepted D84424: [MLIR][Shape] Clean up shape to standard lowering.
Jul 23 2020, 9:22 AM · Restricted Project
pifon2a accepted D84161: [MLIR][Shape] Simplify shape lowering.
Jul 23 2020, 9:20 AM · Restricted Project

Jul 20 2020

pifon2a accepted D84157: [MLIR][Shape] Generalize `shape.const_shape` to extent tensors.
Jul 20 2020, 6:02 AM · Restricted Project
pifon2a accepted D84158: [MLIR][Shape] Allow `shape.get_extent` to operate on extent tensors.
Jul 20 2020, 6:00 AM · Restricted Project
pifon2a accepted D84156: [MLIR][Shape] Allow `shape.rank` to accept extent tensors `tensor?xindex>`.
Jul 20 2020, 5:56 AM · Restricted Project
pifon2a accepted D82848: [MLIR][Shape] Lower `shape.const_shape` to `tensor_from_elements`.
Jul 20 2020, 5:55 AM · Restricted Project