Page MenuHomePhabricator

[Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer.
Needs ReviewPublic

Authored by alok on Jul 18 2020, 4:58 PM.

Details

Summary
This patch stems from D84112.
New dwarf operator DW_OP_LLVM_explicit_pointer is introduced (present only in LLVM IR)

Diff Detail

Event Timeline

alok created this revision.Jul 18 2020, 4:58 PM
jmorse added a subscriber: jmorse.Jul 30 2020, 5:39 AM

Similar story to the parent patch, could you put a file-comment into the test explaining it's a round-trip test?

alok updated this revision to Diff 282625.Aug 3 2020, 7:58 AM
alok retitled this revision from [Debuginfo] (2/N) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy). to [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_explicit_pointer..
alok added a reviewer: jmorse.

Incorporated comments from @jmorse .

alok added a comment.Aug 3 2020, 7:59 AM

Similar story to the parent patch, could you put a file-comment into the test explaining it's a round-trip test?

Thanks for your comment. Just incorporated your comments.

alok retitled this revision from [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_explicit_pointer. to [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..Aug 3 2020, 8:14 AM
alok added a comment.Aug 12 2020, 7:15 AM

@jmorse do you have any more comment on this ?

hmm, possibly more words in the patch description (& IR documentation). of this and the previous patch - what is implicit_pointer V explicit_pointer? Maybe some examples in the patch description and IR documentation about how they could be used?