Page MenuHomePhabricator

alok (Alok Kumar Sharma)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 13 2019, 9:52 PM (65 w, 6 d)

Recent Activity

Yesterday

alok committed rG104a9f99ccab: [Debuginfo][DW_OP_implicit_pointer] (1/7) Support for… (authored by alok).
[Debuginfo][DW_OP_implicit_pointer] (1/7) Support for…
Fri, Jan 15, 1:17 AM
alok closed D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Fri, Jan 15, 1:17 AM · debug-info, Restricted Project

Dec 5 2020

alok updated the summary of D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Dec 5 2020, 3:53 AM · debug-info, Restricted Project
alok updated the diff for D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.

Updated for comment from @jmorse

Dec 5 2020, 3:51 AM · debug-info, Restricted Project

Nov 27 2020

alok abandoned D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..
Nov 27 2020, 2:33 AM · debug-info, Restricted Project

Nov 26 2020

alok updated the diff for D84115: [Debuginfo][Codegen] (2/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..

Updated to incorporate comments from @djtodoro .

Nov 26 2020, 4:29 AM · Restricted Project, debug-info

Nov 23 2020

alok added a comment to D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.

Updated comments from @aprantl and @dblaikie (on other review).

Nov 23 2020, 12:14 AM · debug-info, Restricted Project

Nov 12 2020

alok added reviewers for D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer: jini.susan.george, SouraVX.
Nov 12 2020, 2:22 AM · debug-info, Restricted Project
alok added reviewers for D84120: [Debuginfo][SROA] (7/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: jmorse, aprantl, jini.susan.george, SouraVX.
Nov 12 2020, 1:58 AM · Restricted Project, debug-info
alok updated the diff for D84120: [Debuginfo][SROA] (7/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..

Updated to re-base.

Nov 12 2020, 1:58 AM · Restricted Project, debug-info
alok updated the diff for D84119: [Debuginfo][mem2reg] (6/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..

Updated to re-base.

Nov 12 2020, 1:57 AM · Restricted Project, debug-info
alok added reviewers for D84118: [Debuginfo][Salvaging] (5/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: jmorse, aprantl, jini.susan.george, SouraVX.
Nov 12 2020, 1:53 AM · Restricted Project, debug-info
alok updated the diff for D84118: [Debuginfo][Salvaging] (5/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..

Updated to re-base.

Nov 12 2020, 1:53 AM · Restricted Project, debug-info
alok updated the diff for D84117: [Debuginfo][FastISel] (4/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..

Updated to re-base.

Nov 12 2020, 1:51 AM · debug-info, Restricted Project
alok updated the diff for D84116: [Debuginfo][GlobalISel] (3/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..
Nov 12 2020, 1:49 AM · Restricted Project, debug-info
alok updated the diff for D84115: [Debuginfo][Codegen] (2/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..

Updated to re-base and include many comments from @jmorse .

Nov 12 2020, 1:46 AM · Restricted Project, debug-info
alok retitled D84115: [Debuginfo][Codegen] (2/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy). from [Debuginfo] (3/N) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy). to [Debuginfo][Codegen] (2/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..
Nov 12 2020, 1:42 AM · Restricted Project, debug-info
alok updated the diff for D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.

Updated comments from @aprantl and @dblaikie (on other review).

Nov 12 2020, 1:39 AM · debug-info, Restricted Project
alok retitled D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer from [Debuginfo] (1/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer to [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Nov 12 2020, 1:38 AM · debug-info, Restricted Project
alok added a comment to D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..

Where's the name "explicit" pointer come from? I'm not sure how to read/understand the naming distinction between the names "implicit pointer" and "explicit pointer". Maybe the name should be "LLVM_implicit_pointer" as distinct from the DWARF "implicit_pointer" - that they're roughly the same concept, but the LLVM one is a generalization of it? Or is there something in the implicit/explicit distinction that helps clarify the semantic distinction between the two?

We are using three operators DW_OP_LLVM_explicit_pointer, DW_OP_LLVM_implicit_pointer, DW_OP_implicit_pointer.
Last operator DW_OP_implicit_pointer is dumped to object file and is exact syntax as in DWARF document (DW_OP_implicit_pointer <DIE_reference> <offset_in_DIE>)
Second operator DW_OP_LLVM_implicit_pointer is little variation of DW_OP_implicit_pointer for use till the time the DIE reference is not available with the different syntax (DW_OP_LLVM_implicit_pointer <offset>), where one argument is implicit (first argument of dbg.value intrinsic).

OK, I'm with you so far, that sounds reasonable to me.

While last two operators refer to another variable (Metadata in DW_OP_LLVM_implicit_pointer and DIE reference in DW_OP_implicit_pointer), So this is the variable where we can get the value pointed to by pointer variable (implicit way of getting the value).
The first operator DW_OP_LLVM_explicit_pointer is different than other two operators. This operator is to represent the constant value itself than the other variable and it has the direct way of getting the value pointed to by pointer variable, so the name "explicit" is used.

Sorry, I don't think I'm understanding "This operator is to represent the constant value itself than the other variable and it has the direct way of getting the value pointed to by pointer variable"

Oh, this is for a case where, say, I wrote code like this:

const int *f1() {
  static const int x = 3;
  return x;
}
void f2() {
  const int *y = f1();
  ...
}

Why does that need a different DW_OP compared to DW_OP_LLVM_implicit_pointer? Presumably we use dbg.values for variables with constant values without needing extra operators? (so a variable with the constant value 3 is call void @llvm.dbg.value(metadata i32 3, metadata !11, metadata !DIExpression()) and a variable that /points to/ the constant value 3 would, I would've thought, be call void @llvm.dbg.value(metadata i32 3, metadata !11, metadata !DIExpression(DW_OP_LLVM_implicit_pointer))

though I am open to use any other name.

Nov 12 2020, 1:30 AM · debug-info, Restricted Project

Oct 30 2020

alok added inline comments to D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Oct 30 2020, 11:27 AM · debug-info, Restricted Project

Oct 29 2020

alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 29 2020, 5:39 AM · debug-info, Restricted Project
alok committed rGaa71874f6b9b: [DebugInfo] [NFCI] Additional test for support of DW_TAG_generic_subrange (authored by alok).
[DebugInfo] [NFCI] Additional test for support of DW_TAG_generic_subrange
Oct 29 2020, 5:37 AM
alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 29 2020, 3:51 AM · debug-info, Restricted Project
alok committed rG930a8c60b608: [DebugInfo] [NFCI] Adding a missed out line in support for… (authored by alok).
[DebugInfo] [NFCI] Adding a missed out line in support for…
Oct 29 2020, 3:49 AM
alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 29 2020, 3:17 AM · debug-info, Restricted Project

Oct 28 2020

alok committed rGa6dd01afa3d5: [DebugInfo] Support for DW_TAG_generic_subrange (authored by alok).
[DebugInfo] Support for DW_TAG_generic_subrange
Oct 28 2020, 1:09 PM
alok closed D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 28 2020, 1:09 PM · debug-info, Restricted Project
alok updated the diff for D89218: [DebugInfo] Support for DW_TAG_generic_subrange.

Addressed comments from @aprantl to specialize DIBuilder routine arguments and added tests.

Oct 28 2020, 7:41 AM · debug-info, Restricted Project

Oct 27 2020

alok added a comment to D90243: [NFC] [LLParser] Renaming LLParser routines to satisfy LLVM coding style.

It was huge. Thanks.

Oct 27 2020, 10:31 PM · debug-info, Restricted Project
alok committed rG467db11ccb1c: [NFC] [LLParser] Renaming LLParser routines to comply LLVM coding style (authored by alok).
[NFC] [LLParser] Renaming LLParser routines to comply LLVM coding style
Oct 27 2020, 8:30 PM
alok closed D90243: [NFC] [LLParser] Renaming LLParser routines to satisfy LLVM coding style.
Oct 27 2020, 8:29 PM · debug-info, Restricted Project
alok updated the summary of D90243: [NFC] [LLParser] Renaming LLParser routines to satisfy LLVM coding style.
Oct 27 2020, 9:08 AM · debug-info, Restricted Project
alok requested review of D90243: [NFC] [LLParser] Renaming LLParser routines to satisfy LLVM coding style.
Oct 27 2020, 9:07 AM · debug-info, Restricted Project
alok updated the diff for D89218: [DebugInfo] Support for DW_TAG_generic_subrange.

Addressed concern of @aprantl by getting rid of ConstantAsMetadata and using DIExpression to represent integer type of bounds.

Oct 27 2020, 5:57 AM · debug-info, Restricted Project

Oct 23 2020

alok added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Typed the attributes as DIExpression*, as suggested by @aprantl.

Oct 23 2020, 12:52 AM · Restricted Project

Oct 21 2020

alok added inline comments to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..
Oct 21 2020, 8:43 AM · Restricted Project
alok added a comment to D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..

Where's the name "explicit" pointer come from? I'm not sure how to read/understand the naming distinction between the names "implicit pointer" and "explicit pointer". Maybe the name should be "LLVM_implicit_pointer" as distinct from the DWARF "implicit_pointer" - that they're roughly the same concept, but the LLVM one is a generalization of it? Or is there something in the implicit/explicit distinction that helps clarify the semantic distinction between the two?

Oct 21 2020, 12:10 AM · debug-info, Restricted Project

Oct 20 2020

alok added a comment to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.

Cab you remind me why we are allowing ConstantAsMetadata nodes at all instead of allowing only DIExpressions?

Oct 20 2020, 11:19 PM · debug-info, Restricted Project

Oct 16 2020

alok committed rG0538353b3be3: [DebugInfo] Support for DWARF operator DW_OP_over (authored by alok).
[DebugInfo] Support for DWARF operator DW_OP_over
Oct 16 2020, 8:22 PM
alok closed D89208: [DebugInfo] Support for DWARF operator DW_OP_over.
Oct 16 2020, 8:22 PM · Restricted Project, debug-info

Oct 15 2020

alok added a comment to D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..

hmm, possibly more words in the patch description (& IR documentation). of this and the previous patch - what is implicit_pointer V explicit_pointer? Maybe some examples in the patch description and IR documentation about how they could be used?

Thanks for your comment. I shall update the patch description and IR documentation as well.

Oct 15 2020, 11:39 PM · debug-info, Restricted Project
alok updated the summary of D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..
Oct 15 2020, 11:38 PM · debug-info, Restricted Project
alok updated the diff for D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.

Updated to re-base and incorporate comment from @dblaikie .

Oct 15 2020, 11:29 PM · debug-info, Restricted Project

Oct 13 2020

alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 13 2020, 4:59 AM · debug-info, Restricted Project
alok updated the diff for D89218: [DebugInfo] Support for DW_TAG_generic_subrange.

Incorporated comments from @djtodoro and also removed function re-naming due to pre-built clang-tidy warnings.
Now all other format warning except first are corrected.

Oct 13 2020, 2:14 AM · debug-info, Restricted Project
alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 13 2020, 1:55 AM · debug-info, Restricted Project
alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 13 2020, 1:06 AM · debug-info, Restricted Project

Oct 12 2020

alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 12 2020, 11:59 PM · debug-info, Restricted Project
alok updated the diff for D89218: [DebugInfo] Support for DW_TAG_generic_subrange.

Updated to re-base, incorporate comment from @SouraVX and changes to pacify pre-built check which expects function names to start with small letter and Variable with capital letter, Newer added function gets created with macro. Changed macro and consequently had to change existing functions.

Oct 12 2020, 11:46 PM · debug-info, Restricted Project
alok added a comment to D89208: [DebugInfo] Support for DWARF operator DW_OP_over.

Can you add an assembler roundtrip test to test/Assembler to test the change to lib/IR?
It just can contain a single named node that holds a DIExpression.

Oct 12 2020, 11:34 PM · Restricted Project, debug-info
alok updated the diff for D89208: [DebugInfo] Support for DWARF operator DW_OP_over.

Updated to re-base and incorporate comment from @aprantl .

Oct 12 2020, 11:34 PM · Restricted Project, debug-info
alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 12 2020, 9:12 AM · debug-info, Restricted Project
alok added a comment to D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..

hmm, possibly more words in the patch description (& IR documentation). of this and the previous patch - what is implicit_pointer V explicit_pointer? Maybe some examples in the patch description and IR documentation about how they could be used?

Oct 12 2020, 2:34 AM · debug-info, Restricted Project
alok added inline comments to D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Oct 12 2020, 2:32 AM · debug-info, Restricted Project
alok added a reviewer for D89218: [DebugInfo] Support for DW_TAG_generic_subrange: djtodoro.
Oct 12 2020, 2:10 AM · debug-info, Restricted Project
alok updated the diff for D89218: [DebugInfo] Support for DW_TAG_generic_subrange.

Updated with comment from @djtodoro

Oct 12 2020, 2:08 AM · debug-info, Restricted Project
alok added inline comments to D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 12 2020, 1:54 AM · debug-info, Restricted Project

Oct 11 2020

alok requested review of D89218: [DebugInfo] Support for DW_TAG_generic_subrange.
Oct 11 2020, 11:30 PM · debug-info, Restricted Project
alok updated the diff for D89208: [DebugInfo] Support for DWARF operator DW_OP_over.

Re-based,

Oct 11 2020, 11:01 PM · Restricted Project, debug-info
alok requested review of D89208: [DebugInfo] Support for DWARF operator DW_OP_over.
Oct 11 2020, 10:19 AM · Restricted Project, debug-info

Oct 10 2020

alok committed rG96bd4d34a220: [DebugInfo] Support for DWARF attribute DW_AT_rank (authored by alok).
[DebugInfo] Support for DWARF attribute DW_AT_rank
Oct 10 2020, 5:43 AM
alok closed D89141: [DebugInfo] Support for DWARF attribute DW_AT_rank.
Oct 10 2020, 5:43 AM · Restricted Project, debug-info

Oct 9 2020

alok requested review of D89141: [DebugInfo] Support for DWARF attribute DW_AT_rank.
Oct 9 2020, 9:40 AM · Restricted Project, debug-info

Sep 16 2020

alok added a comment to D87500: [DebugInfo] DISubrange support for fortran assumed size array.

Thanks @aprantl for reviewing this. Any idea how to backport it and other fortran related commits to older version of LLVM (11, 10, 9) ?

Sep 16 2020, 1:57 AM · Restricted Project, debug-info
alok committed rG159abe09d25b: [DebugInfo][flang] DISubrange support for fortran assumed size array (authored by alok).
[DebugInfo][flang] DISubrange support for fortran assumed size array
Sep 16 2020, 1:46 AM
alok closed D87500: [DebugInfo] DISubrange support for fortran assumed size array.
Sep 16 2020, 1:46 AM · Restricted Project, debug-info

Sep 12 2020

alok updated the diff for D87500: [DebugInfo] DISubrange support for fortran assumed size array.

Incorporated comment from @aprantl .

Sep 12 2020, 11:46 AM · Restricted Project, debug-info
alok added inline comments to D87500: [DebugInfo] DISubrange support for fortran assumed size array.
Sep 12 2020, 11:07 AM · Restricted Project, debug-info

Sep 11 2020

alok updated the diff for D87500: [DebugInfo] DISubrange support for fortran assumed size array.

Updated to incorporate comment from @aprantl .

Sep 11 2020, 11:36 PM · Restricted Project, debug-info
alok added inline comments to D87500: [DebugInfo] DISubrange support for fortran assumed size array.
Sep 11 2020, 11:35 PM · Restricted Project, debug-info
alok updated the diff for D87500: [DebugInfo] DISubrange support for fortran assumed size array.

Updated to incorporate @aprantl 's comment.

Sep 11 2020, 10:59 AM · Restricted Project, debug-info
alok added inline comments to D87500: [DebugInfo] DISubrange support for fortran assumed size array.
Sep 11 2020, 10:54 AM · Restricted Project, debug-info
alok requested review of D87500: [DebugInfo] DISubrange support for fortran assumed size array.
Sep 11 2020, 2:33 AM · Restricted Project, debug-info
alok requested review of D87499: [DebugInfo] Flang should not emit DW_AT_main_subprogram for DWARF version lower than 4.
Sep 11 2020, 2:28 AM · Restricted Project, debug-info

Sep 10 2020

alok added a comment to D87406: [DebugInfo] Fixing CodeView assert related to lowerBound field of DISubrange..
In D87406#2266722, @rnk wrote:

I would ask you to add a test, but I can't recommend the existing test, llvm/test/DebugInfo/COFF/types-array.ll, as a good basis for a test. I'll look into rewriting it and adding coverage after you land.

Sep 10 2020, 10:48 PM · debug-info, Restricted Project
alok updated the diff for D87406: [DebugInfo] Fixing CodeView assert related to lowerBound field of DISubrange..
Sep 10 2020, 1:43 PM · debug-info, Restricted Project
alok added inline comments to D87406: [DebugInfo] Fixing CodeView assert related to lowerBound field of DISubrange..
Sep 10 2020, 1:13 PM · debug-info, Restricted Project
alok added a reviewer for D87406: [DebugInfo] Fixing CodeView assert related to lowerBound field of DISubrange.: rnk.
Sep 10 2020, 1:13 PM · debug-info, Restricted Project

Sep 9 2020

alok requested review of D87406: [DebugInfo] Fixing CodeView assert related to lowerBound field of DISubrange..
Sep 9 2020, 11:45 AM · debug-info, Restricted Project

Aug 12 2020

alok added a comment to D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..

@jmorse do you have any more comment on this ?

Aug 12 2020, 7:16 AM · debug-info, Restricted Project
alok added a comment to D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.

@jmorse Do you have any more comment on this ?

Aug 12 2020, 7:15 AM · debug-info, Restricted Project

Aug 3 2020

alok retitled D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer. from [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_explicit_pointer. to [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..
Aug 3 2020, 8:14 AM · debug-info, Restricted Project
alok added a comment to D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..

Similar story to the parent patch, could you put a file-comment into the test explaining it's a round-trip test?

Aug 3 2020, 7:59 AM · debug-info, Restricted Project
alok updated the diff for D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer..

Incorporated comments from @jmorse .

Aug 3 2020, 7:58 AM · debug-info, Restricted Project
alok updated the diff for D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.
Aug 3 2020, 7:38 AM · debug-info, Restricted Project
alok added a reviewer for D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer: jmorse.
Aug 3 2020, 4:06 AM · debug-info, Restricted Project
alok added a comment to D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer.

Thanks for your reviewing this.

Aug 3 2020, 4:05 AM · debug-info, Restricted Project

Jul 20 2020

alok updated the summary of D84112: [DebugInfo] Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy)..
Jul 20 2020, 10:43 PM · debug-info, Restricted Project

Jul 18 2020

Herald added a project to D84120: [Debuginfo][SROA] (7/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: Restricted Project.
Jul 18 2020, 5:14 PM · Restricted Project, debug-info
Herald added a project to D84119: [Debuginfo][mem2reg] (6/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: Restricted Project.
Jul 18 2020, 5:11 PM · Restricted Project, debug-info
Herald added a project to D84118: [Debuginfo][Salvaging] (5/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: Restricted Project.
Jul 18 2020, 5:09 PM · Restricted Project, debug-info
Herald added a project to D84117: [Debuginfo][FastISel] (4/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: Restricted Project.
Jul 18 2020, 5:06 PM · Restricted Project, debug-info
Herald added a project to D84116: [Debuginfo][GlobalISel] (3/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: Restricted Project.
Jul 18 2020, 5:04 PM · Restricted Project, debug-info
Herald added a project to D84115: [Debuginfo][Codegen] (2/7) Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: Restricted Project.
Jul 18 2020, 5:02 PM · Restricted Project, debug-info
Herald added a project to D84114: [Debuginfo] (2/8) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_explicit_pointer.: Restricted Project.
Jul 18 2020, 4:58 PM · Restricted Project, debug-info
Herald added a project to D84113: [Debuginfo] (1/7) [DW_OP_implicit_pointer/second strategy] Support for DW_OP_LLVM_implicit_pointer: Restricted Project.
Jul 18 2020, 4:54 PM · Restricted Project, debug-info
Herald added a project to D84112: [DebugInfo] Support for DW_OP_implicit_pointer for named and unnamed variables (second strategy).: Restricted Project.
Jul 18 2020, 4:21 PM · Restricted Project, debug-info

Jul 15 2020

alok updated the diff for D83544: [DebugInfo] Support for DW_AT_associated and DW_AT_allocated..

Incorporated comments from @aprantl .

Jul 15 2020, 11:16 AM · Restricted Project, debug-info
alok added a comment to D83544: [DebugInfo] Support for DW_AT_associated and DW_AT_allocated..

Mechanically, this looks great! it would be good to add a little more context to the LangRef documentation (see my inline comment).

Jul 15 2020, 9:45 AM · debug-info, Restricted Project