This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Generate CFI directives when probing in prologue
ClosedPublic

Authored by lkail on Jul 6 2020, 9:43 PM.

Details

Summary

Add missing CFI directives when probing in prologue if stack-clash-protection is enabled.

Diff Detail

Event Timeline

lkail created this revision.Jul 6 2020, 9:43 PM
lkail updated this revision to Diff 275906.Jul 6 2020, 10:19 PM
lkail updated this revision to Diff 275908.Jul 6 2020, 10:55 PM
jsji accepted this revision as: jsji.Jul 10 2020, 12:28 PM

LGTM.

llvm/lib/Target/PowerPC/PPCFrameLowering.cpp
1375

Can we add comments here about excluding AIX.

1451

We should merge this two CFIs into one.

llvm/test/CodeGen/PowerPC/stack-clash-prologue.ll
59

These CFIs are not generated in this patch, it would be better if we can pre-commit the testcase changed due to removing of nounwind attr first, so that we can see the real changes.

This revision is now accepted and ready to land.Jul 10 2020, 12:28 PM
lkail updated this revision to Diff 277325.Jul 12 2020, 9:59 PM

Address @jsji 's comments.

lkail updated this revision to Diff 277328.Jul 12 2020, 10:20 PM
lkail marked 3 inline comments as done.
jsji added a comment.Jul 13 2020, 7:10 AM

LG, Thanks.

This revision was automatically updated to reflect the committed changes.