This builds the mlir-linalg-ods-gen tool natively in the same way as tablegen
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
My sense is that this could be done more simply? Seems like complex code that shouldn't be proliferated in other places if we can avoid it.
mlir/CMakeLists.txt | ||
---|---|---|
58 | Is there a particular reason for moving this from the sub-directory? Can you comment on it in the commit log, if so? I suspect it's because of all the PARENT_SCOPE variable sets below? | |
mlir/tools/mlir-linalg-ods-gen/CMakeLists.txt | ||
22 | I assume ${target} here is copy-paste from add_tablegen()? it seems to me like this concept of "A host-tools executable' should be factored out... In fact, maybe this could be accomplished with add_tablegen(mlir-linalg-ods-gen MLIR_LINALG_ODS_GEN .....)? |
Is there a particular reason for moving this from the sub-directory? Can you comment on it in the commit log, if so? I suspect it's because of all the PARENT_SCOPE variable sets below?