Page MenuHomePhabricator

[mlir] Build a native mlir-linalg-ods-gen when cross-compiling
Needs RevisionPublic

Authored by isuruf on Jun 9 2020, 8:16 PM.

Details

Summary

This builds the mlir-linalg-ods-gen tool natively in the same way as tablegen

Diff Detail

Event Timeline

isuruf created this revision.Jun 9 2020, 8:16 PM
stephenneuendorffer requested changes to this revision.Jun 9 2020, 9:19 PM

My sense is that this could be done more simply? Seems like complex code that shouldn't be proliferated in other places if we can avoid it.

mlir/CMakeLists.txt
58

Is there a particular reason for moving this from the sub-directory? Can you comment on it in the commit log, if so? I suspect it's because of all the PARENT_SCOPE variable sets below?

mlir/tools/mlir-linalg-ods-gen/CMakeLists.txt
22

I assume ${target} here is copy-paste from add_tablegen()? it seems to me like this concept of "A host-tools executable' should be factored out... In fact, maybe this could be accomplished with add_tablegen(mlir-linalg-ods-gen MLIR_LINALG_ODS_GEN .....)?

This revision now requires changes to proceed.Jun 9 2020, 9:19 PM
nicolasvasilache resigned from this revision.Oct 2 2020, 1:25 AM