Page MenuHomePhabricator

[mlir][spirv] Handle debuginfo for control flow ops.
ClosedPublic

Authored by denis13 on May 14 2020, 3:30 AM.

Details

Summary

Handle debuginfo for control flow operations: spv.Selection,
spv.Loop, spv.BranchOp, spv.BranchConditional.

Diff Detail

Event Timeline

denis13 created this revision.May 14 2020, 3:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2020, 3:30 AM

Still working on it, will reply once it's ready to review.

Still working on it, will reply once it's ready to review.

Oh, I left the comment on a wrong patch, please ignore this. Sorry about that.

antiagainst accepted this revision.May 15 2020, 11:53 AM

Awesome, thanks Denis!

mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp
395

Super nit: can this be placed after the emitDebugInfo field? It's logically a field necessitated by emitDebugInfo so appearing after it would be nice. :)

This revision is now accepted and ready to land.May 15 2020, 11:53 AM
denis13 updated this revision to Diff 264345.May 15 2020, 2:40 PM

Addressed review comments.

denis13 marked an inline comment as done.May 15 2020, 2:41 PM
denis13 added inline comments.
mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp
395

Sure, thanks for review!

This revision was automatically updated to reflect the committed changes.