Page MenuHomePhabricator

[YAMLVFSWriter][Tests][NFC] Add couple tests
ClosedPublic

Authored by jkorous on May 6 2020, 10:06 PM.

Diff Detail

Event Timeline

jkorous created this revision.May 6 2020, 10:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2020, 10:06 PM
JDevlieghere accepted this revision.May 7 2020, 10:42 AM

We should!

llvm/unittests/Support/VirtualFileSystemTest.cpp
2278

What's an "embedded dir"? I'm not sure what makes this test different from the existing writer test. Could you add a small comment about what the test is testing?

This revision is now accepted and ready to land.May 7 2020, 10:42 AM
jkorous marked an inline comment as done.May 7 2020, 10:56 AM
jkorous added inline comments.
llvm/unittests/Support/VirtualFileSystemTest.cpp
2278

You're right, "nested" is probably a better word here.
This originally helped me to understand how the implementation handles empty directories and since position in the mapping mattered I wanted to have a clean, isolated "unit"-test.

This revision was automatically updated to reflect the committed changes.

The tests fail on Windows: http://45.33.8.238/win/14756/step_11.txt Please take a look, and revert if it takes a while to investigate.

This is failing stage two testing on my Fedora 32 (x86-64) Linux box. Can we please revert this or commit a quick fix?

FAIL: LLVM-Unit :: Support/./SupportTests/YAMLVFSWriterTest.HandleRootAsVPath (4384 of 63793)
******************** TEST 'LLVM-Unit :: Support/./SupportTests/YAMLVFSWriterTest.HandleRootAsVPath' FAILED ********************
Note: Google Test filter = YAMLVFSWriterTest.HandleRootAsVPath
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from YAMLVFSWriterTest
[ RUN      ] YAMLVFSWriterTest.HandleRootAsVPath
SupportTests: /home/dave/s/lp/llvm/lib/Support/VirtualFileSystem.cpp:1917: void llvm::vfs::YAMLVFSWriter::addEntry(llvm::StringRef, llvm::StringRef, bool): Assertion `sys::path::is_absolute(VirtualPath) && "virtual path not absolute"' failed.
 #0 0x00000000007503df llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x7503df)
 #1 0x000000000074e5c2 llvm::sys::RunSignalHandlers() (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x74e5c2)
 #2 0x00000000007506e5 SignalHandler(int) (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x7506e5)
 #3 0x00007ffff7fa6a90 __restore_rt (/lib64/libpthread.so.0+0x14a90)
 #4 0x00007ffff634fa25 raise (/lib64/libc.so.6+0x3ca25)
 #5 0x00007ffff6338895 abort (/lib64/libc.so.6+0x25895)
 #6 0x00007ffff6338769 _nl_load_domain.cold (/lib64/libc.so.6+0x25769)
 #7 0x00007ffff6347e86 (/lib64/libc.so.6+0x34e86)
 #8 0x000000000071d25e llvm::vfs::YAMLVFSWriter::addEntry(llvm::StringRef, llvm::StringRef, bool) (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x71d25e)
 #9 0x0000000000635d4c YAMLVFSWriterTest_HandleRootAsVPath_Test::TestBody() (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x635d4c)
#10 0x0000000000758cea testing::Test::Run() (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x758cea)
#11 0x0000000000759d40 testing::TestInfo::Run() (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x759d40)
#12 0x000000000075a3b7 testing::TestCase::Run() (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x75a3b7)
#13 0x0000000000762777 testing::internal::UnitTestImpl::RunAllTests() (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x762777)
#14 0x00000000007623df testing::UnitTest::Run() (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x7623df)
#15 0x000000000075129b main (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x75129b)
#16 0x00007ffff633a042 __libc_start_main (/lib64/libc.so.6+0x27042)
#17 0x00000000002ffede _start (/tmp/_update_lc/t/unittests/Support/./SupportTests+0x2ffede)

@davezarzycki Sorry about that! Reverted in e4e3e41905d and will take a look on Monday.

The test is failing on Windows again: http://45.33.8.238/win/16808/step_11.txt Please take a look and revert for now if it takes a while to investigate.

The test is failing on Windows again: http://45.33.8.238/win/16808/step_11.txt Please take a look and revert for now if it takes a while to investigate.

I reverted this in 3dad3907198b920f5531cedec154e79a72beeec4 to get bots green again (e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32749).