- User Since
- Sep 9 2014, 6:00 AM (332 w, 6 d)
Dec 18 2020
Apologies for the delay, I've had other things taking my time.
Nov 9 2020
Resigning as reviewer as I also work for Sony.
Nov 5 2020
Oct 28 2020
Apologies for the delay, I've had a few other things on.
Sep 23 2020
Sep 22 2020
I'm going to concentrate on the standalone port as I think that's the way forward. If I get that working then can work through the other issues.
Sep 17 2020
Sep 15 2020
One small comment. Apart from that, LGTM.
Sep 14 2020
Re-upload patch with G LLVM Github Monorepo set.
Sep 11 2020
Is there a good sanity check that it is actually using Scudo rather than silently using the standard alloc?
Fixup scudo (sanitizer based) to work on Windows.
Aug 28 2020
Thanks for catching that.
Aug 27 2020
Fix llvm-config test.
I assume something in lit is parsing and recognizing this? Should remove that too?
I'd also like to see how they (currently supported allocators) compare vs. SCUDO and vs. tcmalloc3, if someone is willing to port those on Windows.
I've applied this to the monorepo and made a few more changes to allow it to build LLVM on Windows here: https://reviews.llvm.org/D86694
Aug 4 2020
Jul 31 2020
Thanks for your work on this. I've just tried out this version with rpmalloc (1.4.0) checked out out at the top of llvm-project.
Fixed comments and added test.
Jul 30 2020
Jul 28 2020
It looks like is causing one of the debuginfo-tests: llgdb-tests/nrvo-string.cpp to fail, run on Linux. Failure as below. I don't think the debuginfo-tests are run on any bot (but probably should be!). I bisected the failure back to this change.
Jul 23 2020
Jul 1 2020
Jun 30 2020
I notice that the improvements to rpmalloc for LLVM are still under discussion (https://github.com/mjansson/rpmalloc/issues/150) and targetted at rpmalloc v1.4.1.
Jun 23 2020
Jun 4 2020
May 29 2020
May 28 2020
May 22 2020
May 15 2020
May 14 2020
Removed excess dashes in man page. Checked with:
Change to double dashes.
May 13 2020
May 12 2020
Apr 22 2020
LGTM, with a few small comments.
Apr 15 2020
LGTM, with assertion messages adjusted.
Apr 14 2020
Would be nice if the test could check that the pid was being set to something but not sure how you could do that (beyond checking that it's a number).
Mar 24 2020
Feb 12 2020
Feb 10 2020
This was submitted as the sequence of patches:
https://reviews.llvm.org/D70904 - Tidying up in TimeProfiler.cpp
https://reviews.llvm.org/D70950 - Add ProcName to TimeTraceProfiler
https://reviews.llvm.org/D71059 - [LLD][ELF] Add time-trace to ELF LLD (1/2) (multi-thread support in TimeProfiler)
https://reviews.llvm.org/D71060 - [LLD][ELF] Add time-trace to ELF LLD (2/2) (Add time trace to LLD)
Feb 6 2020
Jan 31 2020
Jan 29 2020
Additionally it allows Clang versions prior to 10 to compile current trunk.
Jan 28 2020
Jan 27 2020
Jan 24 2020
Thanks, added const.
Add consts to references in lambda functions.
Ping. Okay to land new version?
Jan 23 2020
Update to check for start of metadata.
Jan 22 2020
Jan 21 2020
Jan 15 2020
Ping. Is this okay to land, or have I missed something? Thanks.
Jan 10 2020