This is an archive of the discontinued LLVM Phabricator instance.

[clangd] don't rename on protobuf symbols.
ClosedPublic

Authored by hokein on Feb 5 2020, 3:35 AM.

Diff Detail

Event Timeline

hokein created this revision.Feb 5 2020, 3:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2020, 3:35 AM

Unit tests: unknown.

clang-tidy: unknown.

clang-format: unknown.

Build artifacts: console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

kadircet accepted this revision.Feb 6 2020, 5:41 AM
kadircet added inline comments.
clang-tools-extra/clangd/refactor/Rename.cpp
99

nit: I would put some comments on what and why this function blacklists, as the name is too generic.

This revision is now accepted and ready to land.Feb 6 2020, 5:41 AM
hokein updated this revision to Diff 242892.Feb 6 2020, 6:39 AM

address comments

This revision was automatically updated to reflect the committed changes.