This is an archive of the discontinued LLVM Phabricator instance.

Remove the LoopInstSimplify pass (-loop-instsimplify)
ClosedPublic

Authored by vsk on Mar 2 2018, 4:16 PM.

Details

Summary

AFAICT LoopInstSimplify is unused and untested. Reading through the
commit history the pass also seems to have a high maintenance burden.

Maybe it'd be best to retire the pass for now?

Diff Detail

Event Timeline

vsk created this revision.Mar 2 2018, 4:16 PM
fhahn added a subscriber: fhahn.Mar 3 2018, 11:33 AM
vsk added a comment.Mar 12 2018, 12:23 PM

Friendly ping. I kicked off a discussion on llvm-dev about this, and no one chimed to say they're using this pass.

mzolotukhin accepted this revision.Mar 12 2018, 1:09 PM

FWIW, I agree with what Philip said on the llvm-dev thread. That pass aligns with the overall design we'd like to get to, but we are not there yet. This pass is simple enough to recover whenever someone decides to work on it.

Thanks,
Michael

This revision is now accepted and ready to land.Mar 12 2018, 1:09 PM
This revision was automatically updated to reflect the committed changes.
lib/Passes/PassRegistry.def