This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: exp should not be in WQM mode
ClosedPublic

Authored by tpr on Aug 4 2017, 4:56 AM.

Details

Summary

A mrt exp with vm=1 must be in exact (non-WQM) mode, as it also exports
the exec mask as the valid mask to determine which pixels to render.

This commit marks any exp as needing to be in exact mode.

Actually, if there are multiple mrt exps, only one needs to have vm=1,
and only that one needs to be in exact mode. But that is an optimization
for another day.

Event Timeline

tpr created this revision.Aug 4 2017, 4:56 AM
tpr added a comment.Aug 17 2017, 9:27 AM

Ping (Nicolai and Matt).

michel.daenzer added a subscriber: michel.daenzer.EditedAug 17 2017, 7:23 PM

Never mind, I think I confused WQM and WWM.

tpr added a comment.Sep 1 2017, 8:31 AM

This has been open for a while. If no-one objects in the next couple of days, I'll commit it anyway.

tpr updated this revision to Diff 113854.Sep 5 2017, 7:36 AM

Rebased test changes.

This revision was automatically updated to reflect the committed changes.