Page MenuHomePhabricator

dstuttard (David Stuttard)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 25 2017, 7:29 AM (191 w, 1 d)

Recent Activity

Wed, Sep 23

dstuttard accepted D84779: [AMDGPU] Add amdgpu specific loop threshold metadata.

This change looks good to me, especially now that you've made the requested changes.

Wed, Sep 23, 3:56 AM · Restricted Project

Mon, Sep 21

dstuttard added inline comments to D86905: Flush bitcode incrementally for LTO output.
Mon, Sep 21, 1:28 AM · Restricted Project

Fri, Sep 18

dstuttard added a comment to D86905: Flush bitcode incrementally for LTO output.

See comment about a VC++ warning being generated.

Fri, Sep 18, 8:49 AM · Restricted Project

Aug 14 2020

dstuttard added a reviewer for D85667: Reset PAL metadata when AMDGPU traget stream finishes: tpr.

LGTM (minor comment typo), but I'm adding Tim who did most of the original code I think.

Aug 14 2020, 6:51 AM · Restricted Project

Jul 10 2020

dstuttard committed rG69a89b54c626: [NFC] Change isFPPredicate comparison to ignore lower bound (authored by dstuttard).
[NFC] Change isFPPredicate comparison to ignore lower bound
Jul 10 2020, 4:12 AM
dstuttard closed D83540: [NFC] Change isFPPredicate comparison to ignore lower bound.
Jul 10 2020, 4:12 AM · Restricted Project
dstuttard added reviewers for D83540: [NFC] Change isFPPredicate comparison to ignore lower bound: gchatelet, nhaehnle, serge-sans-paille.

D81662 started causing warnings for VS. This fixes those.

Jul 10 2020, 1:56 AM · Restricted Project
Herald added a project to D83540: [NFC] Change isFPPredicate comparison to ignore lower bound: Restricted Project.
Jul 10 2020, 1:53 AM · Restricted Project

Jun 24 2020

dstuttard committed rGe8775c8d817b: [AMDGPU] Make sure to fix implicit operands on insertBranch (authored by dstuttard).
[AMDGPU] Make sure to fix implicit operands on insertBranch
Jun 24 2020, 9:10 AM
dstuttard closed D82459: [AMDGPU] Make sure to fix implicit operands on insertBranch.
Jun 24 2020, 9:10 AM · Restricted Project
dstuttard added inline comments to D81364: AMDGPU: Correct prolog SP initialization logic.
Jun 24 2020, 9:09 AM · Restricted Project
dstuttard updated the diff for D82459: [AMDGPU] Make sure to fix implicit operands on insertBranch.

Made requested changes

Jun 24 2020, 8:36 AM · Restricted Project
dstuttard created D82459: [AMDGPU] Make sure to fix implicit operands on insertBranch.
Jun 24 2020, 6:27 AM · Restricted Project
dstuttard added reviewers for D82459: [AMDGPU] Make sure to fix implicit operands on insertBranch: foad, arsenm.
Jun 24 2020, 6:27 AM · Restricted Project

Jun 8 2020

dstuttard added a comment to D81070: [AMDGPU] Fixup use of StackPtrOffsetReg when not initialized.

I'm thinking that this fix may be taking the wrong approach now.

Jun 8 2020, 4:19 AM · Restricted Project
dstuttard created D81364: AMDGPU: Correct prolog SP initialization logic.
Jun 8 2020, 2:08 AM · Restricted Project
dstuttard added inline comments to D81364: AMDGPU: Correct prolog SP initialization logic.
Jun 8 2020, 2:08 AM · Restricted Project
dstuttard added reviewers for D81364: AMDGPU: Correct prolog SP initialization logic: scott.linder, arsenm.
Jun 8 2020, 2:08 AM · Restricted Project

Jun 3 2020

dstuttard abandoned D40297: [RegisterCoalescer] Add verification method to check LiveInterval Segments.
Jun 3 2020, 7:05 AM
dstuttard abandoned D34889: [ScheduleDAG] Fix bug in check for use of dead defs.
Jun 3 2020, 7:05 AM
dstuttard abandoned D40300: [RegisterCoalescer] Fix for SubRegJoin failures.
Jun 3 2020, 7:05 AM
dstuttard updated the diff for D81070: [AMDGPU] Fixup use of StackPtrOffsetReg when not initialized.

Rebase to get tests to pass

Jun 3 2020, 4:53 AM · Restricted Project
dstuttard updated the diff for D81070: [AMDGPU] Fixup use of StackPtrOffsetReg when not initialized.

Improved the test to include one that has a call provoking s32 to be initialized

Jun 3 2020, 2:43 AM · Restricted Project
dstuttard added a reviewer for D81070: [AMDGPU] Fixup use of StackPtrOffsetReg when not initialized: critson.
Jun 3 2020, 2:43 AM · Restricted Project
dstuttard added reviewers for D81070: [AMDGPU] Fixup use of StackPtrOffsetReg when not initialized: scott.linder, arsenm.
Jun 3 2020, 2:43 AM · Restricted Project
dstuttard created D81070: [AMDGPU] Fixup use of StackPtrOffsetReg when not initialized.
Jun 3 2020, 2:43 AM · Restricted Project

Jun 2 2020

dstuttard committed rG9244be7b0514: [TableGen] Avoid generating switch with just default (authored by dstuttard).
[TableGen] Avoid generating switch with just default
Jun 2 2020, 12:05 PM
dstuttard closed D81021: [TableGen] Avoid generating switch with just default.
Jun 2 2020, 12:05 PM · Restricted Project
dstuttard added a reviewer for D81021: [TableGen] Avoid generating switch with just default: dsanders.
Jun 2 2020, 11:32 AM · Restricted Project
dstuttard created D81021: [TableGen] Avoid generating switch with just default.
Jun 2 2020, 11:32 AM · Restricted Project

Apr 2 2020

dstuttard added a comment to D77245: [AMDGPU] Fix crash in SILoadStoreOptimizer.

My fix has been hanging around for a little while now - so my memory of it is a little hazy.

Apr 2 2020, 8:06 AM · Restricted Project

Mar 31 2020

dstuttard added a comment to D75741: AMDGPU: Add check to recompute merge-able instructions.

How would it invalidate the list? Isn't the analysis of which instructions can be moved done one list at a time?

Mar 31 2020, 7:44 AM · Restricted Project

Mar 19 2020

dstuttard accepted D76428: [cmake] Disable C4129 warning for MSVC..

Tested this in my environment and it fixed the issue.

Mar 19 2020, 7:33 AM · Restricted Project

Mar 17 2020

dstuttard added reviewers for D75741: AMDGPU: Add check to recompute merge-able instructions: arsenm, rampitec, foad.

Added more reviewers - anyone got an opinion on this one.

Mar 17 2020, 1:34 AM · Restricted Project

Mar 6 2020

dstuttard updated the diff for D75741: AMDGPU: Add check to recompute merge-able instructions.

Formatting fixes

Mar 6 2020, 9:18 AM · Restricted Project
dstuttard added a comment to D75741: AMDGPU: Add check to recompute merge-able instructions.

I encountered this issue with a test shader I was looking at. I did manage to create a reproducer, but a different fix to the triviallyDisjoint function meant that it stopped happening.
However, I still think the situation may occur, hence putting this change up for review.

Mar 6 2020, 7:09 AM · Restricted Project
dstuttard added a reviewer for D75741: AMDGPU: Add check to recompute merge-able instructions: tstellar.
Mar 6 2020, 7:09 AM · Restricted Project
dstuttard created D75741: AMDGPU: Add check to recompute merge-able instructions.
Mar 6 2020, 7:09 AM · Restricted Project

Mar 5 2020

dstuttard committed rGa74b33f61251: AMDGPU: Fix SMRD test in trivially disjoint mem access code (authored by dstuttard).
AMDGPU: Fix SMRD test in trivially disjoint mem access code
Mar 5 2020, 9:19 AM
dstuttard closed D75686: AMDGPU: Fix SMRD test in trivially disjoint mem access code.
Mar 5 2020, 9:19 AM · Restricted Project
dstuttard created D75686: AMDGPU: Fix SMRD test in trivially disjoint mem access code.
Mar 5 2020, 8:45 AM · Restricted Project
dstuttard added reviewers for D75686: AMDGPU: Fix SMRD test in trivially disjoint mem access code: arsenm, foad.
Mar 5 2020, 8:45 AM · Restricted Project

Dec 17 2019

dstuttard accepted D70975: [SDAG] remove use restriction in isNegatibleForFree() when called from getNegatedExpression().

Confirmed that this fix also solves my original problem per D70595

Dec 17 2019, 3:47 AM · Restricted Project

Dec 10 2019

dstuttard abandoned D70595: [TargetLowering] Allow constants with multiple uses.

Alternative fix D70975 works.

Dec 10 2019, 2:05 AM · Restricted Project
dstuttard accepted D70975: [SDAG] remove use restriction in isNegatibleForFree() when called from getNegatedExpression().

This fixes the issue I encountered for the original fix in D70595

Dec 10 2019, 2:05 AM · Restricted Project
dstuttard added a comment to D70595: [TargetLowering] Allow constants with multiple uses.

@dstuttard does D70975 cover the original problem motivating this patch?

Dec 10 2019, 2:05 AM · Restricted Project

Dec 4 2019

dstuttard committed rG46db60683422: AMDGPU: Avoid folding 2 constant operands into an SALU operation (authored by dstuttard).
AMDGPU: Avoid folding 2 constant operands into an SALU operation
Dec 4 2019, 2:44 AM
dstuttard closed D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.
Dec 4 2019, 2:44 AM · Restricted Project

Dec 3 2019

dstuttard added inline comments to D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.
Dec 3 2019, 3:27 AM · Restricted Project
dstuttard updated the diff for D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.

Made suggested changes

Dec 3 2019, 3:27 AM · Restricted Project

Dec 2 2019

dstuttard added reviewers for D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation: arsenm, foad.

I would have preferred to have put this check into isImmOperandLegal in SIInstrInfo.cpp - but that produced lots of lit regressions. Looks like commute operations use this function even when they are swapping rather than replacing the operand (which breaks).

Dec 2 2019, 5:16 AM · Restricted Project
dstuttard updated the diff for D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.

Formatting

Dec 2 2019, 5:07 AM · Restricted Project
dstuttard created D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.
Dec 2 2019, 5:06 AM · Restricted Project
dstuttard added a reviewer for D70781: AMDGPU: Fix handling of infinite loops in fragment shaders: critson.
Dec 2 2019, 1:56 AM · Restricted Project

Nov 28 2019

dstuttard committed rG943d8326dd35: AMDGPU: Fix lit test checks with dag option (authored by dstuttard).
AMDGPU: Fix lit test checks with dag option
Nov 28 2019, 2:06 AM
dstuttard closed D70531: AMDGPU: Fix lit test checks with dag option.
Nov 28 2019, 2:06 AM · Restricted Project

Nov 27 2019

dstuttard updated the diff for D70595: [TargetLowering] Allow constants with multiple uses.

Changed the implementation slightly.
Now the isNegatibleForFree includes a bool for allowing multi-use
constants. This is only set to true for calls from getNegatedExpression so it
only allows for the situation where a constant becomes multi-use during
getNegatedExpression recursive evaluation.

Nov 27 2019, 7:22 AM · Restricted Project

Nov 26 2019

dstuttard added a comment to D70531: AMDGPU: Fix lit test checks with dag option.

Matt - are you happy for this to proceed?

Nov 26 2019, 9:01 AM · Restricted Project
dstuttard updated the diff for D70595: [TargetLowering] Allow constants with multiple uses.

Added test updates for failing lit tests.

Nov 26 2019, 9:01 AM · Restricted Project

Nov 22 2019

dstuttard added inline comments to D70531: AMDGPU: Fix lit test checks with dag option.
Nov 22 2019, 7:09 AM · Restricted Project
dstuttard added a comment to D70595: [TargetLowering] Allow constants with multiple uses.

I'd like to see more of the regressions on other targets (x86 in particular) - in many cases this will cause a lot of extra constant pool entries.

Nov 22 2019, 5:56 AM · Restricted Project
dstuttard added a comment to D70595: [TargetLowering] Allow constants with multiple uses.

I've got some failures as a result of this change in X86 (haven't tried the other backends). I guess that the failures are probably due to the fneg propagation working better for constants - but I haven't investigated yet. There will need to be more test changes as a result of this change.
My question is - does the change look reasonable? If so I'll take a look at the lit regressions for other backends.

Nov 22 2019, 5:10 AM · Restricted Project
dstuttard updated the diff for D70595: [TargetLowering] Allow constants with multiple uses.

Included wrong version of the test initially

Nov 22 2019, 4:25 AM · Restricted Project
dstuttard added a reviewer for D70595: [TargetLowering] Allow constants with multiple uses: RKSimon.

Added @RKSimon to review as the last major modifier of the code here.

Nov 22 2019, 4:25 AM · Restricted Project
dstuttard added inline comments to D70595: [TargetLowering] Allow constants with multiple uses.
Nov 22 2019, 4:25 AM · Restricted Project
dstuttard created D70595: [TargetLowering] Allow constants with multiple uses.
Nov 22 2019, 4:07 AM · Restricted Project
dstuttard updated the diff for D70531: AMDGPU: Fix lit test checks with dag option.

Replace COUNT-n with n DAG versions (DAG-COUNT-n doesn't work)

Nov 22 2019, 3:29 AM · Restricted Project
dstuttard added inline comments to D70531: AMDGPU: Fix lit test checks with dag option.
Nov 22 2019, 2:42 AM · Restricted Project

Nov 21 2019

dstuttard added a reviewer for D70531: AMDGPU: Fix lit test checks with dag option: rampitec.
Nov 21 2019, 3:41 AM · Restricted Project
dstuttard created D70531: AMDGPU: Fix lit test checks with dag option.
Nov 21 2019, 3:41 AM · Restricted Project

Oct 25 2019

dstuttard added a comment to D69430: Disallow dpp combining for dpp instructions without Src2 operand (when Src2 is required).

Maybe put [AMDGPU] into the subject line of the commit message

Oct 25 2019, 5:04 AM · Restricted Project
dstuttard accepted D69430: Disallow dpp combining for dpp instructions without Src2 operand (when Src2 is required).

LGTM

Oct 25 2019, 4:58 AM · Restricted Project

Oct 16 2019

dstuttard committed rG2d6a2303f83d: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands (authored by dstuttard).
[AMDGPU] Fix-up cases where writelane has 2 SGPR operands
Oct 16 2019, 7:40 AM
dstuttard closed D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.
Oct 16 2019, 7:40 AM · Restricted Project
dstuttard committed rL375004: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.
[AMDGPU] Fix-up cases where writelane has 2 SGPR operands
Oct 16 2019, 7:40 AM

Oct 7 2019

dstuttard added a comment to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

ping

Oct 7 2019, 12:41 AM · Restricted Project

Sep 30 2019

dstuttard added a comment to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

Matt - are you now happy for me to submit this? (It is tagged as approved, but since you've made some extra comments I'm waiting for you to agree with the latest changes).

Sep 30 2019, 12:49 AM · Restricted Project

Sep 23 2019

dstuttard added a comment to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

Made suggested changes - is this more in line with what you were thinking Matt?

Sep 23 2019, 1:59 AM · Restricted Project
dstuttard updated the diff for D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

Updates in light of review comments

Sep 23 2019, 1:59 AM · Restricted Project

Sep 19 2019

dstuttard added inline comments to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.
Sep 19 2019, 10:18 AM · Restricted Project
dstuttard updated the diff for D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

Made some changes based on review

Sep 19 2019, 10:12 AM · Restricted Project

Sep 18 2019

dstuttard updated the diff for D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

GFX10 support has gone in since this change was approved - gfx10 allows 2 sgprs
on the constant bus. Implementation updated to allow for this.

Sep 18 2019, 7:49 AM · Restricted Project

Sep 4 2019

dstuttard committed rL370873: Request commit access for dstuttard.
Request commit access for dstuttard
Sep 4 2019, 3:52 AM

Jul 29 2019

dstuttard committed rG20235ef3e751: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions (authored by dstuttard).
[AMDGPU] Enable v4f16 and above for v_pk_fma instructions
Jul 29 2019, 8:16 AM
dstuttard committed rL367206: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.
[AMDGPU] Enable v4f16 and above for v_pk_fma instructions
Jul 29 2019, 8:16 AM
dstuttard closed D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.
Jul 29 2019, 8:16 AM · Restricted Project

Jul 26 2019

dstuttard updated the diff for D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.

Managed to get the fmac test to keep using fmac
Also updated the test to use non-anonymous values

Jul 26 2019, 9:41 AM · Restricted Project
dstuttard updated the diff for D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.

Changed test to use fma intrinsic

Jul 26 2019, 7:21 AM · Restricted Project
dstuttard added a reviewer for D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions: rampitec.

+Stas to comment on the v_fmac_f16 test change.
Is it acceptable to change the result to look for v_pk_fma_f16 rather than 2 v_fmac_f16 instructions? If not, any suggestions on how to get the compiler to generate 2 x fmac instead?

Jul 26 2019, 5:13 AM · Restricted Project
dstuttard added reviewers for D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions: arsenm, piotr.
Jul 26 2019, 3:39 AM · Restricted Project
dstuttard created D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.
Jul 26 2019, 3:38 AM · Restricted Project

Jul 17 2019

dstuttard abandoned D63639: [AMDGPU] Prevent backend override of WGP when using PAL.

I might revisit this one - setting cumode seems messy to enable driver control of the WGP setting, but seems the most pragmatic at the moment.

Jul 17 2019, 1:31 AM · Restricted Project
dstuttard added inline comments to D63639: [AMDGPU] Prevent backend override of WGP when using PAL.
Jul 17 2019, 1:31 AM · Restricted Project

Jul 15 2019

dstuttard added a comment to D63639: [AMDGPU] Prevent backend override of WGP when using PAL.

ping

Jul 15 2019, 1:21 AM · Restricted Project

Jun 21 2019

dstuttard added inline comments to D63639: [AMDGPU] Prevent backend override of WGP when using PAL.
Jun 21 2019, 7:10 AM · Restricted Project
dstuttard added reviewers for D63639: [AMDGPU] Prevent backend override of WGP when using PAL: tpr, rampitec.
Jun 21 2019, 2:38 AM · Restricted Project
dstuttard created D63639: [AMDGPU] Prevent backend override of WGP when using PAL.
Jun 21 2019, 2:36 AM · Restricted Project

May 9 2019

dstuttard committed rG411488b11edf: [CodeGenPrepare] Limit recursion depth for collectBitParts (authored by dstuttard).
[CodeGenPrepare] Limit recursion depth for collectBitParts
May 9 2019, 8:00 AM
dstuttard committed rL360347: [CodeGenPrepare] Limit recursion depth for collectBitParts.
[CodeGenPrepare] Limit recursion depth for collectBitParts
May 9 2019, 8:00 AM
dstuttard closed D61728: [CodeGenPrepare] Limit recursion depth for collectBitParts.
May 9 2019, 7:59 AM · Restricted Project