This is an archive of the discontinued LLVM Phabricator instance.

[PPC CodeGen] Expand the bitreverse.i64 intrinsic.
ClosedPublic

Authored by jtony on Jun 30 2017, 2:08 PM.

Diff Detail

Event Timeline

jtony created this revision.Jun 30 2017, 2:08 PM
hfinkel accepted this revision.Jun 30 2017, 3:17 PM

LGTM

Do we have anything in the test suite that will check this code for correctness and track performance? It would be good to add a small benchmark there, for bit reversal and for byte swap. I'd like this because, in part, if some change causes us to need to regenerate the match lines on this test, I doubt anyone would notice a subtle bug.

Also, in follow-up, I think it would be nice to move all of the TableGen code for this into its own .td file (which you can just include in the present file using an include directive).

This revision is now accepted and ready to land.Jun 30 2017, 3:17 PM
This revision was automatically updated to reflect the committed changes.