[Assembler] Inline assembly diagnostics test.

[sanwou01]

Summary

Add a test for improved inline assembly diagnostics in llvm.

[sanwou01]

This tests the improved inline asm diagnostics from D29769.

[rnk]

test/Misc/inline-asm-diags.c

2

Use clang -cc1 -S -o /dev/null -verify to test this.

[echristo]

Can we not get llc to use the diags interfaces here?

[sanwou01]

Use clang_cc1 -verify for testing as suggested by @rnk.

@echristo, llc does use the same diags interfaces as clang, however, it is
lacking the infrastructure to make use of LocCookies.

In any case, I think this test is useful to prevent regressions in inline
assembly diagnostics in clang.

[echristo]

In D29770#674961, @sanwou01 wrote:

Use clang_cc1 -verify for testing as suggested by @rnk.

@echristo, llc does use the same diags interfaces as clang, however, it is
lacking the infrastructure to make use of LocCookies.

In any case, I think this test is useful to prevent regressions in inline
assembly diagnostics in clang.

The point is that we typically do not want end to end tests (of which this is one) in clang if there's any way to avoid it. In this case we could test the same interfaces by adding support to llc for them (and it would arguably be useful in llc mode anyhow).

[grosbach]

Eric is correct. These tests would be more suitable in llc. The clang tests should check that the inline asm is inserted into the IR in the correct form if there's any difference pre and post patch (I don't think there is?).

[sanwou01]

Please see D30167 for an attempt to test this from llc.

test/Misc/inline-asm-diags.c

+// RUN: %clang_cc1 -S -emit-obj -triple armv7a-arm-none-eabi %s -o /dev/null -verify
+
+void foo2() {
+  asm(" wibble"); // expected-error{{invalid instruction}}
+}
+
+void foo() {
+  asm(" .word -bar");  // expected-error {{expected relocatable expression}}
+  asm(" .word -foo");  // expected-error {{expected relocatable expression}}
+}
+
+// expected-note@1 {{instantiated into assembly here}}
+// expected-note@1 {{instantiated into assembly here}}
+// expected-note@1 {{instantiated into assembly here}}