Page MenuHomePhabricator

sanwou01 (Sanne Wouda)
Senior Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Jan 12 2017, 6:15 AM (202 w, 2 d)

Recent Activity

Tue, Nov 10

sanwou01 committed rGdd03881bd504: Add loop distribution to the LTO pipeline (authored by sanwou01).
Add loop distribution to the LTO pipeline
Tue, Nov 10, 4:04 AM
sanwou01 closed D89896: Add loop distribution to the LTO pipeline.
Tue, Nov 10, 4:04 AM · Restricted Project

Mon, Nov 9

sanwou01 committed rGf4f256fb7b7e: Reland "Precommit LTO pipeline test" (authored by sanwou01).
Reland "Precommit LTO pipeline test"
Mon, Nov 9, 3:37 AM

Fri, Nov 6

sanwou01 added a comment to D88126: [Machinesink] add more profitable pattern if target bb register pressure is not too high.

Hi, this is regressing a few internal workloads (physics simulations, AArch64) by a few percent. Did you do any performance measurements for this change?

Fri, Nov 6, 7:16 AM · Restricted Project

Tue, Nov 3

sanwou01 reopened D89896: Add loop distribution to the LTO pipeline.

Reverted due to new test failing on a bunch of buildbots. I'll try again tomorrow, looks like the other pipeline tests manage to work around it.

Tue, Nov 3, 1:03 PM · Restricted Project
sanwou01 added a reverting change for rG5a72a1623e4a: Precommit LTO pipeline test: rGe969ab43202e: Revert "Precommit LTO pipeline test".
Tue, Nov 3, 11:30 AM
sanwou01 committed rGe969ab43202e: Revert "Precommit LTO pipeline test" (authored by sanwou01).
Revert "Precommit LTO pipeline test"
Tue, Nov 3, 11:30 AM
sanwou01 added a reverting change for rG6e80318eecde: Add loop distribution to the LTO pipeline: rG2ec26d3a2315: Revert "Add loop distribution to the LTO pipeline".
Tue, Nov 3, 11:29 AM
sanwou01 committed rG2ec26d3a2315: Revert "Add loop distribution to the LTO pipeline" (authored by sanwou01).
Revert "Add loop distribution to the LTO pipeline"
Tue, Nov 3, 11:29 AM
sanwou01 added a reverting change for D89896: Add loop distribution to the LTO pipeline: rG2ec26d3a2315: Revert "Add loop distribution to the LTO pipeline".
Tue, Nov 3, 11:29 AM · Restricted Project
sanwou01 committed rG6e80318eecde: Add loop distribution to the LTO pipeline (authored by sanwou01).
Add loop distribution to the LTO pipeline
Tue, Nov 3, 10:54 AM
sanwou01 committed rG5a72a1623e4a: Precommit LTO pipeline test (authored by sanwou01).
Precommit LTO pipeline test
Tue, Nov 3, 10:54 AM
sanwou01 closed D89896: Add loop distribution to the LTO pipeline.
Tue, Nov 3, 10:54 AM · Restricted Project

Oct 21 2020

sanwou01 added a comment to D89896: Add loop distribution to the LTO pipeline.

@SjoerdMeijer yeaahhh these pipeline tests are a bit of a pain, but nothing some big-brain sed scripting can't solve.

Oct 21 2020, 1:06 PM · Restricted Project
sanwou01 updated the diff for D89896: Add loop distribution to the LTO pipeline.

Added LTO pipeline test

Oct 21 2020, 1:04 PM · Restricted Project
sanwou01 added reviewers for D89896: Add loop distribution to the LTO pipeline: SjoerdMeijer, dmgreen, anemet, efriedma.
Oct 21 2020, 10:19 AM · Restricted Project
sanwou01 requested review of D89896: Add loop distribution to the LTO pipeline.
Oct 21 2020, 10:12 AM · Restricted Project

Sep 29 2020

sanwou01 abandoned D88423: Fix llvm-link assert failure in BitCodeWriter.
Sep 29 2020, 2:09 AM · Restricted Project
sanwou01 added a comment to D88241: OpaquePtr: Add type to sret attribute.

Thanks @tpopp, that'll unblock all of us.

Sep 29 2020, 2:09 AM · Restricted Project
sanwou01 added inline comments to D88423: Fix llvm-link assert failure in BitCodeWriter.
Sep 29 2020, 1:52 AM · Restricted Project

Sep 28 2020

sanwou01 added inline comments to D88423: Fix llvm-link assert failure in BitCodeWriter.
Sep 28 2020, 12:28 PM · Restricted Project
sanwou01 added a comment to D88423: Fix llvm-link assert failure in BitCodeWriter.

I'm not sure I understand the reason behind moving the EnumerateType call from incorporateFunction to the ValueEnumerator constructor. We don't walk the attributes before that, do we?

Sep 28 2020, 11:54 AM · Restricted Project
sanwou01 closed D87231: [AArch64] Match pairwise add/fadd pattern.

Committed as d5fd3d9b903e

Sep 28 2020, 9:49 AM · Restricted Project
sanwou01 added reviewers for D88423: Fix llvm-link assert failure in BitCodeWriter: arsenm, t.p.northover, dblaikie, efriedma.
Sep 28 2020, 8:33 AM · Restricted Project
sanwou01 requested review of D88423: Fix llvm-link assert failure in BitCodeWriter.
Sep 28 2020, 8:32 AM · Restricted Project

Sep 22 2020

sanwou01 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

SPEC 2017 on AArch64 is neutral on the geomean. The only slight worry is omnetpp with a 1% regression, but this is balanced by a .8% improvement on mcf. Other changes are in the noise.

Sep 22 2020, 6:54 AM · Restricted Project, Restricted Project

Sep 18 2020

sanwou01 added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

I know this has already been reverted but just FYI that I've bisected a ~2% regression in SPEC2017 x264_r on AArch64 to this commit. Presumably this is due to the extra unrolling / cost modelling issue already mentioned?

Sep 18 2020, 8:44 AM · Restricted Project, Restricted Project

Sep 17 2020

sanwou01 committed rGd5fd3d9b903e: [AArch64] Match pairwise add/fadd pattern (authored by sanwou01).
[AArch64] Match pairwise add/fadd pattern
Sep 17 2020, 8:28 AM
sanwou01 committed rG3ee87a976d52: Precommit test updates (authored by sanwou01).
Precommit test updates
Sep 17 2020, 8:28 AM
sanwou01 added inline comments to D87231: [AArch64] Match pairwise add/fadd pattern.
Sep 17 2020, 7:00 AM · Restricted Project
sanwou01 updated the diff for D87231: [AArch64] Match pairwise add/fadd pattern.

Fix for when there is no fp16 faddp + testing

Sep 17 2020, 6:56 AM · Restricted Project
sanwou01 accepted D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage.

LGTM, thanks for fixing this! Could you wait a day or two before committing to allow others to comment?

Sep 17 2020, 1:42 AM · Restricted Project

Sep 16 2020

sanwou01 retitled D87231: [AArch64] Match pairwise add/fadd pattern from [AArch64] Match pairwise fadd pattern to [AArch64] Match pairwise add/fadd pattern.
Sep 16 2020, 5:52 AM · Restricted Project
sanwou01 updated the diff for D87231: [AArch64] Match pairwise add/fadd pattern.

Extend to f16, f32, f64 and i64

Sep 16 2020, 5:50 AM · Restricted Project
sanwou01 added inline comments to D87231: [AArch64] Match pairwise add/fadd pattern.
Sep 16 2020, 3:29 AM · Restricted Project
sanwou01 retitled D87231: [AArch64] Match pairwise add/fadd pattern from [AArch64] ExtractElement is free when combined with pairwise add to [AArch64] Match pairwise fadd pattern.
Sep 16 2020, 2:41 AM · Restricted Project
sanwou01 updated the diff for D87231: [AArch64] Match pairwise add/fadd pattern.

Rework to match faddp in AArch64 ISel lowering

Sep 16 2020, 2:41 AM · Restricted Project
sanwou01 added a comment to D87231: [AArch64] Match pairwise add/fadd pattern.

Thanks for the feedback. I agree that ideally we'd be generating reduction intrinsics in IR and matching that in the backends. I don't think the pairwise add can be represented with the current intrinsics though: we'd need a <2 x float> variant, or a predicated version of the <4 x float> intrinsic to do this for strict FP math, I believe.

Sep 16 2020, 2:39 AM · Restricted Project

Sep 8 2020

sanwou01 added a comment to D87231: [AArch64] Match pairwise add/fadd pattern.

Thanks @spatel . You're right that we miss that pattern, but, so does x86 currently it seems (I don't read x86 very well so I might be wrong). Using your faddp example:

Sep 8 2020, 2:34 AM · Restricted Project

Sep 7 2020

sanwou01 added reviewers for D87231: [AArch64] Match pairwise add/fadd pattern: samparker, SjoerdMeijer, dmgreen, spatel, lebedev.ri, RKSimon, jgorbe.
Sep 7 2020, 5:02 AM · Restricted Project
sanwou01 requested review of D87231: [AArch64] Match pairwise add/fadd pattern.
Sep 7 2020, 5:00 AM · Restricted Project

Jul 23 2020

sanwou01 added a comment to D84349: [llvm][NFC] Remove definition from build system of LLVM_HAVE_TF_AOT.

huh. How does include/llvm/Support/Windows/WindowsSupport.h include llvm/Config/config.h though... weird. In any case, I'll move the _AOT definition to llvm_config.h.cmake. Sorry for the trouble!

Jul 23 2020, 9:13 AM · Restricted Project
sanwou01 added a comment to D84349: [llvm][NFC] Remove definition from build system of LLVM_HAVE_TF_AOT.

Are you sure you can include config.h in an installed header file? AFAICT, config.h isn't installed, but llvm-config.h is.

Jul 23 2020, 2:21 AM · Restricted Project

Jul 13 2020

sanwou01 committed rG4d3e8dc215d1: Fix llvm-test-suite failure introduced by D82550/D83122 (authored by sanwou01).
Fix llvm-test-suite failure introduced by D82550/D83122
Jul 13 2020, 8:14 AM
sanwou01 committed rG13fec93a77fa: [NFC] rename to reflect F is not necessarily an Intrinsic (authored by sanwou01).
[NFC] rename to reflect F is not necessarily an Intrinsic
Jul 13 2020, 7:30 AM
sanwou01 committed rG7b84045565bd: [SLPVectorizer] handle vectorizeable library functions (authored by sanwou01).
[SLPVectorizer] handle vectorizeable library functions
Jul 13 2020, 7:30 AM
sanwou01 committed rGe909f6bc48ee: Pre-commit tests (authored by sanwou01).
Pre-commit tests
Jul 13 2020, 7:30 AM
sanwou01 committed rG2e58004fe187: Fix crash when getVFABIMappings is called with an indirect call instruction (authored by sanwou01).
Fix crash when getVFABIMappings is called with an indirect call instruction
Jul 13 2020, 7:30 AM
sanwou01 closed D82550: [SLPVectorizer] handle vectorized lib functions.
Jul 13 2020, 7:30 AM · Restricted Project
sanwou01 closed D83122: Fix crash when getVFABIMappings is called with an indirect call instruction.
Jul 13 2020, 7:30 AM · Restricted Project

Jul 10 2020

sanwou01 added inline comments to D82550: [SLPVectorizer] handle vectorized lib functions.
Jul 10 2020, 8:34 AM · Restricted Project
sanwou01 updated the diff for D82550: [SLPVectorizer] handle vectorized lib functions.

Updates to address feedback, in particular:

Jul 10 2020, 8:34 AM · Restricted Project
sanwou01 requested review of D83122: Fix crash when getVFABIMappings is called with an indirect call instruction.
Jul 10 2020, 2:25 AM · Restricted Project

Jul 6 2020

sanwou01 added inline comments to D82550: [SLPVectorizer] handle vectorized lib functions.
Jul 6 2020, 9:36 AM · Restricted Project
sanwou01 updated the diff for D82550: [SLPVectorizer] handle vectorized lib functions.

Addressed comments.

Jul 6 2020, 7:47 AM · Restricted Project
sanwou01 added a comment to D82550: [SLPVectorizer] handle vectorized lib functions.

Comments inline.

Jul 6 2020, 3:31 AM · Restricted Project

Jul 3 2020

sanwou01 updated the diff for D82550: [SLPVectorizer] handle vectorized lib functions.

Split out NFC rename

Jul 3 2020, 4:49 AM · Restricted Project
sanwou01 added inline comments to D82550: [SLPVectorizer] handle vectorized lib functions.
Jul 3 2020, 4:49 AM · Restricted Project
sanwou01 added reviewers for D83122: Fix crash when getVFABIMappings is called with an indirect call instruction: fhahn, fpetrogalli, dmgreen, SjoerdMeijer, samparker.
Jul 3 2020, 3:12 AM · Restricted Project
sanwou01 added a comment to D82550: [SLPVectorizer] handle vectorized lib functions.

ping?

Jul 3 2020, 3:12 AM · Restricted Project
sanwou01 added reviewers for D82550: [SLPVectorizer] handle vectorized lib functions: dmgreen, SjoerdMeijer, samparker.
Jul 3 2020, 3:12 AM · Restricted Project
sanwou01 created D83122: Fix crash when getVFABIMappings is called with an indirect call instruction.
Jul 3 2020, 3:12 AM · Restricted Project

Jun 25 2020

sanwou01 updated the diff for D82550: [SLPVectorizer] handle vectorized lib functions.

Now with test changes

Jun 25 2020, 8:34 AM · Restricted Project
sanwou01 added a comment to D82550: [SLPVectorizer] handle vectorized lib functions.

Ah, I missed the test changes this time round. Incoming.

Jun 25 2020, 8:34 AM · Restricted Project
sanwou01 added inline comments to D82550: [SLPVectorizer] handle vectorized lib functions.
Jun 25 2020, 8:34 AM · Restricted Project
sanwou01 updated the diff for D82550: [SLPVectorizer] handle vectorized lib functions.

Addressed comments

Jun 25 2020, 8:34 AM · Restricted Project
sanwou01 created D82550: [SLPVectorizer] handle vectorized lib functions.
Jun 25 2020, 7:26 AM · Restricted Project

May 28 2020

sanwou01 added a comment to D77524: [TargetPassConfig] Add CanonicalizeFreezeInLoops before LSR.

@aqjune thanks again for working on this pass. I can confirm that the regression in mcf we originally reported on D76483 is now resolved!

May 28 2020, 10:23 AM · Restricted Project

May 26 2020

sanwou01 committed rG5bd97eb28aff: Fix MemoryLocation.h use without Instructions.h (authored by sanwou01).
Fix MemoryLocation.h use without Instructions.h
May 26 2020, 9:45 AM

May 7 2020

sanwou01 added a comment to D68911: [AArch64] enable (v)select to math TLI hook (WIP).

I'm running SPEC CPU intrate for this patch as well as this patch in combination with D78880.

May 7 2020, 5:03 AM · Restricted Project

May 6 2020

sanwou01 added a comment to D78880: [InstCombine] use select-of-constants with set/clear bit mask patterns.

Do you think D68911 has a good chance of helping here? I can do a quick test run (quicker than finding a good reproducer) to see if improves.

May 6 2020, 9:07 AM · Restricted Project
sanwou01 added a comment to D78880: [InstCombine] use select-of-constants with set/clear bit mask patterns.

Hi, we're seeing a small (1.0%) regression in omnetpp_r in SPEC INT 2017 on AArch64 with LTO enabled that bisects to this patch. I should be able to reduce omnetpp_r to a small IR example that shows the changed AArch64 codegen, if that's useful. A revert is probably not necessary if all we need is an additional pattern or two in the AArch64 backend.

May 6 2020, 8:02 AM · Restricted Project

Apr 17 2020

sanwou01 added a comment to D77523: Add CanonicalizeFreezeInLoops pass.

I can report that in our testing on SPEC 2017, this pass fixes the regression to mcf introduced with D76483.

Apr 17 2020, 4:49 AM · Restricted Project

Mar 31 2020

sanwou01 added a comment to D76483: [DivRemPairs] Freeze operands if they can be undef values.

Thanks, much appreciated!

Mar 31 2020, 9:24 AM · Restricted Project
sanwou01 added a comment to D76483: [DivRemPairs] Freeze operands if they can be undef values.

[...] It looks like SCEV can't see "through" the freeze node. [...]

I see. This link might be helpful: https://reviews.llvm.org/D70623

Mar 31 2020, 6:04 AM · Restricted Project

Mar 30 2020

sanwou01 added a comment to D76483: [DivRemPairs] Freeze operands if they can be undef values.

Hi, I can confirm that D76010 unfortunately doesn't fix the regression.

Mar 30 2020, 11:24 AM · Restricted Project

Mar 27 2020

sanwou01 added a comment to D76483: [DivRemPairs] Freeze operands if they can be undef values.

Hi, we're seeing a performance drop of 1.3% on SPEC 2017 mcf_r (compiled with LTO enabled) on AArch64 that bisects down to this patch. I'm testing whether D76010 happens to fix this regression (I'll comment when I get the results), but if not then this might need some investigation to see what's going on.

Mar 27 2020, 1:10 PM · Restricted Project

Jan 29 2020

sanwou01 abandoned D70674: [AArch64] Precommit tests for over-eager MUL/ADD fusing fix.

Committed as https://reviews.llvm.org/rG970d9719ea0d15795694d7686d4d8eb524bba379

Jan 29 2020, 5:49 AM · Restricted Project
sanwou01 committed rG2939fc13c8f6: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q) (authored by sanwou01).
[AArch64] Add IR intrinsics for sq(r)dmulh_lane(q)
Jan 29 2020, 5:41 AM
sanwou01 closed D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q).
Jan 29 2020, 5:41 AM · Restricted Project, Restricted Project
sanwou01 committed rGcbc45e4e7521: Regenerate aarch64-neon-2velem.c CHECK lines (authored by sanwou01).
Regenerate aarch64-neon-2velem.c CHECK lines
Jan 29 2020, 5:05 AM
sanwou01 committed rG4ec2a2673211: Fix clang test build (authored by sanwou01).
Fix clang test build
Jan 29 2020, 5:04 AM

Jan 28 2020

sanwou01 updated the diff for D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q).

Address Eli's feedback; clarified commit message.

Jan 28 2020, 9:21 AM · Restricted Project, Restricted Project
sanwou01 added a comment to D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q).

Thanks Eli.

Jan 28 2020, 8:15 AM · Restricted Project, Restricted Project

Jan 17 2020

sanwou01 committed rGecfd6d3e8418: [clang] Set function attributes on SEH filter functions correctly. (authored by sanwou01).
[clang] Set function attributes on SEH filter functions correctly.
Jan 17 2020, 10:13 AM
sanwou01 closed D72786: [clang] Set function attributes on SEH filter functions correctly..
Jan 17 2020, 10:13 AM · Restricted Project

Jan 16 2020

sanwou01 added a comment to D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q).

ping?

Jan 16 2020, 2:35 AM · Restricted Project, Restricted Project
sanwou01 added reviewers for D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q): rovka, rengolin, efriedma.
Jan 16 2020, 2:35 AM · Restricted Project, Restricted Project
sanwou01 updated the diff for D72786: [clang] Set function attributes on SEH filter functions correctly..

Fix tests, thanks rnk

Jan 16 2020, 1:58 AM · Restricted Project

Jan 15 2020

sanwou01 created D72786: [clang] Set function attributes on SEH filter functions correctly..
Jan 15 2020, 10:03 AM · Restricted Project

Jan 14 2020

sanwou01 committed rG1cc8fff420a7: [AArch64] Fix save register pairing for Windows AAPCS (authored by sanwou01).
[AArch64] Fix save register pairing for Windows AAPCS
Jan 14 2020, 7:15 AM
sanwou01 closed D71754: [AArch64] Fix save register pairing for Windows AAPCS.
Jan 14 2020, 7:15 AM · Restricted Project

Dec 23 2019

sanwou01 added inline comments to D71754: [AArch64] Fix save register pairing for Windows AAPCS.
Dec 23 2019, 9:25 AM · Restricted Project

Dec 20 2019

sanwou01 created D71754: [AArch64] Fix save register pairing for Windows AAPCS.
Dec 20 2019, 5:38 AM · Restricted Project

Dec 13 2019

sanwou01 added reviewers for D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q): SjoerdMeijer, dmgreen, t.p.northover.
Dec 13 2019, 8:06 AM · Restricted Project, Restricted Project
sanwou01 created D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q).
Dec 13 2019, 8:06 AM · Restricted Project, Restricted Project

Dec 5 2019

sanwou01 committed rGe503fee904d8: [AArch64] Fix MUL/SUB fusing (authored by sanwou01).
[AArch64] Fix MUL/SUB fusing
Dec 5 2019, 10:15 AM
sanwou01 closed D71067: [AArch64] Fix MUL/SUB fusing.
Dec 5 2019, 10:15 AM · Restricted Project
sanwou01 added a comment to D71067: [AArch64] Fix MUL/SUB fusing.

Great, thanks for confirming.

Dec 5 2019, 10:15 AM · Restricted Project
sanwou01 created D71067: [AArch64] Fix MUL/SUB fusing.
Dec 5 2019, 7:33 AM · Restricted Project