This new test tests that functions are capable of being imported, rather than
that the import pass is run. This new test is compatible with the approach
being developed in D20268 which runs the importer on its own rather than in
a pass.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
LGTM but with one question: Any issue with IR tests in clang tests? I noticed that there are very few (although there is already one existing .ll in test/CodeGen).
Should be fine. This is testing an unusual feature of clang that takes IR as input, so IR is the appropriate input type here.
This is testing a clang feature that reads IR and runs the ThinLTO backend. This feature is part of ThinLTO's distributed build support (search for "Distributed Build Support" in http://blog.llvm.org/2016/06/thinlto-scalable-and-incremental-lto.html).
In a future change I want to replace the clang-side code here with a client of a new LTO interface that takes IR and produces object files (see D21545). So I think testing the object file is the right approach here.