This is an archive of the discontinued LLVM Phabricator instance.

Revise RenderScript attribute declaration
ClosedPublic

Authored by pirama on Jun 10 2016, 1:51 PM.

Details

Summary

Address post-patch comments to r272342.

  • Rename the 'kernel' attribute's name
  • Idiomatically restrict the attribute to the 'RenderScript' LangOpt.

Diff Detail

Event Timeline

pirama updated this revision to Diff 60397.Jun 10 2016, 1:51 PM
pirama retitled this revision from to Revise RenderScript attribute declaration.
pirama updated this object.
pirama added reviewers: aaron.ballman, rsmith.
pirama added subscribers: srhines, cfe-commits.
pirama added inline comments.Jun 10 2016, 1:56 PM
include/clang/Basic/Attr.td
735

This still says 'Undocumented'. I'll rebase this on top of D21212 once that is submitted (or vice versa).

aaron.ballman accepted this revision.Jun 10 2016, 2:51 PM
aaron.ballman edited edge metadata.

LGTM, thank you!

include/clang/Basic/Attr.td
735

That's fine by me.

This revision is now accepted and ready to land.Jun 10 2016, 2:51 PM
This revision was automatically updated to reflect the committed changes.