This is an archive of the discontinued LLVM Phabricator instance.

Add documentation for RenderScript changes
ClosedPublic

Authored by pirama on Jun 9 2016, 4:42 PM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

pirama updated this revision to Diff 60280.Jun 9 2016, 4:42 PM
pirama retitled this revision from to Add documentation for RenderScript changes.
pirama updated this object.
pirama added a reviewer: rsmith.
pirama added subscribers: srhines, cfe-commits.
aaron.ballman added inline comments.Jun 10 2016, 7:45 AM
include/clang/Basic/AttrDocs.td
2440 ↗(On Diff #60280)

A little bit more information would be appreciated. I know you link to the RenderScript documentation, but there should be at least enough information here so that a reader has an idea what a kernel function is for render script.

pirama updated this revision to Diff 60394.Jun 10 2016, 1:24 PM

Expand description of RenderScript kernel functions.

pirama updated this revision to Diff 60412.Jun 10 2016, 3:01 PM

Rebase after submission of D21240.

aaron.ballman accepted this revision.Jun 21 2016, 6:15 AM
aaron.ballman edited edge metadata.

LGTM with a tiny wording nit.

include/clang/Basic/AttrDocs.td
2444 ↗(On Diff #60412)

computations

This revision is now accepted and ready to land.Jun 21 2016, 6:15 AM
pirama updated this revision to Diff 61390.Jun 21 2016, 9:14 AM
pirama edited edge metadata.

computation -> computations.

This revision was automatically updated to reflect the committed changes.