This is an archive of the discontinued LLVM Phabricator instance.

Extract renaming from D19181
ClosedPublic

Authored by deadalnix on May 19 2016, 1:02 AM.

Details

Summary

This needs to get in before anything is released concerning attribute. If the old name gets in the wild, then we are stuck with it forever. Putting it in its own diff should getting that part at least in fast.

Diff Detail

Event Timeline

deadalnix updated this revision to Diff 57743.May 19 2016, 1:02 AM
deadalnix retitled this revision from to Extract renaming from D19181.
deadalnix updated this object.
deadalnix added a subscriber: llvm-commits.
Wallbraker edited edge metadata.May 23 2016, 2:58 AM

Considering how long the other Attribute review is taking just remove the function all together, and put it in once we actually have the finished interface down.

Cheers, Jakob.

whitequark accepted this revision.May 23 2016, 5:43 AM
whitequark edited edge metadata.

LGTM.

This revision is now accepted and ready to land.May 23 2016, 5:43 AM

@Walbraker as long as there is no date for the branch cut, I don't think we should make assumptions.

This revision was automatically updated to reflect the committed changes.