[scan-build] fix dead store warnings emitted on LLVM AMDGPU code base

[apelete]

Summary

his fixes dead store warnings of the type "dead assignment" reported
by Clang Static Analyzer on the following file:

• lib/Target/AMDGPU/SIISelLowering.cpp.

Signed-off-by: Apelete Seketeli <[e-mail]>

[rivanvx]

LGTM

[apelete]

[scan-build] fix dead store warnings emitted on LLVM AMDGPU code base

Changes since last revision:

• rebased patch on trunk and validated against test suite.

[apelete]

In D19833#420439, @rivanvx wrote:

LGTM

I don't have commit access so please go ahead and commit this for me when you're ready.

[rivanvx]

@apelete neither do I. @tstellarAMD, can you please commit this?

[arsenm]

LGTM

[Eugene.Zelenko]

Looks like patch was not committed.

[arsenm]

8aadb442d1db65fc01d85059ebb86929ddbf771b

lib/Target/AMDGPU/SIISelLowering.cpp

SDValue SITargetLowering::LowerBRCOND(SDValue BRCOND,
   if (BR) {
     // Give the branch instruction our target
     SDValue Ops[] = {
       BR->getOperand(0),
       BRCOND.getOperand(2)
     };
     SDValue NewBR = DAG.getNode(ISD::BR, DL, BR->getVTList(), Ops);
     DAG.ReplaceAllUsesWith(BR, NewBR.getNode());
-    BR = NewBR.getNode();
   }
 
   SDValue Chain = SDValue(Result, Result->getNumValues() - 1);
 
   // Copy the intrinsic results to registers
   for (unsigned i = 1, e = Intr->getNumValues() - 1; i != e; ++i) {
     SDNode *CopyToReg = findUser(SDValue(Intr, i), ISD::CopyToReg);
     if (!CopyToReg)