Page MenuHomePhabricator

apelete (Apelete Seketeli)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2016, 1:11 AM (290 w, 1 d)

Recent Activity

May 21 2016

apelete abandoned D19971: [scan-build] fix warnings emitted on LLVM TargetRecip code base.
May 21 2016, 5:41 AM

May 18 2016

apelete updated the diff for D19084: [scan-build] fix warnings emitted on Clang AST code base.

[scan-build] fix warnings emitted on Clang AST code base

May 18 2016, 1:13 AM

May 17 2016

apelete retitled D19829: [scan-build] fix dead store warnings emitted on Clang Sema code base from [scan-build] fix dead store warnings emitted on clang code base to [scan-build] fix dead store warnings emitted on Clang Sema code base.
May 17 2016, 10:25 PM
apelete updated the diff for D19829: [scan-build] fix dead store warnings emitted on Clang Sema code base.

[scan-build] fix dead store warnings emitted on clang code base

May 17 2016, 10:23 PM
apelete added a comment to D19972: [scan-build] fix warnings emitted on LLVM dsymutil code base.

Attr can never be null here because one of Loc or Block will be non-null. This looks like a deficiency of the static analyzer. I'd rather initialize Attr in each of the branches of the if above if that helps.

May 17 2016, 12:52 PM

May 12 2016

apelete added a comment to D19900: [scan-build] fix dead store warnings emitted on LLVM Hexagon code base.

LGTM. Thanks!

May 12 2016, 5:10 PM
apelete updated the diff for D19900: [scan-build] fix dead store warnings emitted on LLVM Hexagon code base.

[scan-build] fix dead store warnings emitted on LLVM Hexagon code base

May 12 2016, 5:06 PM
apelete added a comment to D19833: [scan-build] fix dead store warnings emitted on LLVM AMDGPU code base.

LGTM

May 12 2016, 4:46 PM
apelete added a comment to D19810: [scan-build] fix logic error warning in LLVM AMDGPU target code base.

LGTM. Thanks!

May 12 2016, 4:45 PM
apelete added a comment to D19632: [scan-build] fix logic error warnings emitted on llvm code base.

Thanks for making the update, XCore changes look good to me.

May 12 2016, 4:45 PM
apelete updated the diff for D19833: [scan-build] fix dead store warnings emitted on LLVM AMDGPU code base.

[scan-build] fix dead store warnings emitted on LLVM AMDGPU code base

May 12 2016, 4:18 PM
apelete updated the diff for D19810: [scan-build] fix logic error warning in LLVM AMDGPU target code base.

[scan-build] fix logic error warning in LLVM AMDGPU target code base

May 12 2016, 4:05 PM
apelete updated the diff for D19632: [scan-build] fix logic error warnings emitted on llvm code base.

[scan-build] fix logic error warnings emitted on llvm code base

May 12 2016, 3:50 PM
apelete added a comment to D19964: [scan-build] fix warnings emiited on LLVM Analysis code base.

Thanks, LGTM!

-Silviu

May 12 2016, 11:50 AM
apelete added inline comments to D19084: [scan-build] fix warnings emitted on Clang AST code base.
May 12 2016, 10:07 AM
apelete updated the diff for D19964: [scan-build] fix warnings emiited on LLVM Analysis code base.

[scan-build] fix warnings emiited on LLVM Analysis code base

May 12 2016, 6:54 AM

May 11 2016

apelete added inline comments to D19964: [scan-build] fix warnings emiited on LLVM Analysis code base.
May 11 2016, 3:07 PM
apelete added inline comments to D19964: [scan-build] fix warnings emiited on LLVM Analysis code base.
May 11 2016, 8:57 AM
apelete updated D19410: [scan-build] fix warnings emitted on LLVM ARM code base.
May 11 2016, 1:11 AM
apelete added a comment to D19410: [scan-build] fix warnings emitted on LLVM ARM code base.

Thanks Apelete,

Assuming this change passes "make check-all", I'm happy with them.

May 11 2016, 1:10 AM
apelete updated the diff for D19410: [scan-build] fix warnings emitted on LLVM ARM code base.

[scan-build] fix warnings emitted on LLVM ARM code base

May 11 2016, 1:05 AM

May 9 2016

apelete added inline comments to D19971: [scan-build] fix warnings emitted on LLVM TargetRecip code base.
May 9 2016, 11:58 AM
apelete added inline comments to D19971: [scan-build] fix warnings emitted on LLVM TargetRecip code base.
May 9 2016, 9:57 AM
apelete updated the diff for D19964: [scan-build] fix warnings emiited on LLVM Analysis code base.

[scan-build] fix warnings emiited on LLVM Analysis code base

May 9 2016, 9:34 AM
apelete updated the diff for D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base.

[scan-build] fix warnings emitted on Clang StaticAnalyzer code base

May 9 2016, 5:19 AM
apelete added inline comments to D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base.
May 9 2016, 5:15 AM
apelete added inline comments to D19960: [scan-build] fix warnings emitted on Clang CodeGen code base.
May 9 2016, 4:38 AM
apelete updated D19410: [scan-build] fix warnings emitted on LLVM ARM code base.
May 9 2016, 4:14 AM
apelete updated the diff for D19410: [scan-build] fix warnings emitted on LLVM ARM code base.

[scan-build] fix warnings emitted on LLVM ARM code base

May 9 2016, 4:12 AM
apelete updated the diff for D19410: [scan-build] fix warnings emitted on LLVM ARM code base.

[scan-build] fix warnings emitted on LLVM ARM code base

May 9 2016, 3:19 AM

May 5 2016

apelete abandoned D19498: [scan-build] fix logic error warnings emitted on llvm code base.

This patch was split into D19083, D19410, D19966, D19968, D19973 and D19975 to ease review process.

May 5 2016, 4:07 PM
apelete updated the diff for D19975: [scan-build] fix warning emitted on LLVM Bitcode code base.

[scan-build] fix warning emitted on LLVM Bitcode code base

May 5 2016, 3:48 PM
apelete updated D19975: [scan-build] fix warning emitted on LLVM Bitcode code base.
May 5 2016, 3:17 PM
apelete added inline comments to D19975: [scan-build] fix warning emitted on LLVM Bitcode code base.
May 5 2016, 3:16 PM
apelete added inline comments to D19968: [scan-build] fix warnings emitted on LLVM Hexagon code base.
May 5 2016, 2:22 PM
apelete updated the diff for D19632: [scan-build] fix logic error warnings emitted on llvm code base.

[scan-build] fix logic error warnings emitted on llvm code base

May 5 2016, 2:00 PM
apelete added a comment to D19970: [scan-build] fix warnings emitted on LLVM MachineCode code base.

But is the static analyzer correct?

Cheers,
Rafael

May 5 2016, 8:16 AM
apelete retitled D19969: [scan-build] fix warnings emitted on LLVM NVPTX code base from [scan-build] fix warnings emitted on LLVM NVPTX code base Fix logic error warnings of the type "called C++ object pointer is null" emitted by Clang Static Analyzer on the following file: lib/Target/NVPTX/NVPTXInstrInfo.cpp. to [scan-build] fix warnings emitted on LLVM NVPTX code base.
May 5 2016, 7:46 AM
apelete retitled D19970: [scan-build] fix warnings emitted on LLVM MachineCode code base from [scan-build] fix warnings emitted on LLVM MachineCode code base Fix logic error warnings of the type "called C++ object pointer is null" emitted by Clang Static Analyzer on the following file: - lib/MC/MCParser/AsmParser.cpp. to [scan-build] fix warnings emitted on LLVM MachineCode code base.
May 5 2016, 7:46 AM
apelete retitled D19975: [scan-build] fix warning emitted on LLVM Bitcode code base from [scan-build] fix warning emitted on LLVM Bitcode code base Fix a logic error warning of the type "called C++ object pointer is null" emitted by Clang Static Analyzer on the following file: - lib/Bitcode/Writer/BitcodeWriter.cpp. to [scan-build] fix warning emitted on LLVM Bitcode code base.
May 5 2016, 7:45 AM
apelete retitled D19971: [scan-build] fix warnings emitted on LLVM TargetRecip code base from [scan-build] fix warnings emitted on LLVM TargetRecip code base Fix logic error warnings of the type "called C++ object pointer is null" emitted by Clang Static Analyzer on the following files: - lib/Target/TargetRecip.cpp. to [scan-build] fix warnings emitted on LLVM TargetRecip code base.
May 5 2016, 7:44 AM
apelete retitled D19975: [scan-build] fix warning emitted on LLVM Bitcode code base from to [scan-build] fix warning emitted on LLVM Bitcode code base Fix a logic error warning of the type "called C++ object pointer is null" emitted by Clang Static Analyzer on the following file: - lib/Bitcode/Writer/BitcodeWriter.cpp..
May 5 2016, 7:42 AM
apelete added a reviewer for D19973: [scan-build] fix warning emitted on LLVM X86 code base: m_zuckerman.
May 5 2016, 7:35 AM
apelete retitled D19973: [scan-build] fix warning emitted on LLVM X86 code base from to [scan-build] fix warning emitted on LLVM X86 code base.
May 5 2016, 7:34 AM
apelete retitled D19972: [scan-build] fix warnings emitted on LLVM dsymutil code base from to [scan-build] fix warnings emitted on LLVM dsymutil code base.
May 5 2016, 7:04 AM
apelete retitled D19971: [scan-build] fix warnings emitted on LLVM TargetRecip code base from to [scan-build] fix warnings emitted on LLVM TargetRecip code base Fix logic error warnings of the type "called C++ object pointer is null" emitted by Clang Static Analyzer on the following files: - lib/Target/TargetRecip.cpp..
May 5 2016, 6:51 AM
apelete retitled D19970: [scan-build] fix warnings emitted on LLVM MachineCode code base from to [scan-build] fix warnings emitted on LLVM MachineCode code base Fix logic error warnings of the type "called C++ object pointer is null" emitted by Clang Static Analyzer on the following file: - lib/MC/MCParser/AsmParser.cpp..
May 5 2016, 6:44 AM
apelete retitled D19969: [scan-build] fix warnings emitted on LLVM NVPTX code base from to [scan-build] fix warnings emitted on LLVM NVPTX code base Fix logic error warnings of the type "called C++ object pointer is null" emitted by Clang Static Analyzer on the following file: lib/Target/NVPTX/NVPTXInstrInfo.cpp..
May 5 2016, 6:34 AM
apelete retitled D19968: [scan-build] fix warnings emitted on LLVM Hexagon code base from to [scan-build] fix warnings emitted on LLVM Hexagon code base.
May 5 2016, 6:21 AM
apelete retitled D19966: [scan-build] fix warnings emitted on LLVM Transforms code base from to [scan-build] fix warnings emitted on LLVM Transforms code base.
May 5 2016, 6:10 AM
apelete retitled D19083: [scan-build] fix warnings emitted on LLVM CodeGen code base from [clang-analyzer] fix warnings emitted on llvm code base to [scan-build] fix warnings emitted on LLVM CodeGen code base.
May 5 2016, 5:33 AM
apelete updated the diff for D19083: [scan-build] fix warnings emitted on LLVM CodeGen code base.

[scan-build] fix warnings emitted on LLVM CodeGen code base

May 5 2016, 5:21 AM
apelete retitled D19965: [scan-build] fix warnings emitted on LLVM IR code base from to [scan-build] fix warnings emitted on LLVM IR code base.
May 5 2016, 4:59 AM
apelete retitled D19964: [scan-build] fix warnings emiited on LLVM Analysis code base from to [scan-build] fix warnings emiited on LLVM Analysis code base.
May 5 2016, 4:49 AM
apelete retitled D19410: [scan-build] fix warnings emitted on LLVM ARM code base from [scan-build] fix logic error warnings emitted on llvm code base to [scan-build] fix warnings emitted on LLVM ARM code base.
May 5 2016, 4:38 AM
apelete updated the diff for D19410: [scan-build] fix warnings emitted on LLVM ARM code base.

[scan-build] fix warnings emitted on LLVM ARM code base

May 5 2016, 4:36 AM
apelete retitled D19963: [scan-build] fix warnings emitted on Clang Frontend code base from [scan-build] fix warnings emitted on Clang Frontend code base Fix "Logic error" warnings of the type "Called C++ object pointer is null" reported by Clang Static Analyzer on the following file: lib/Frontend/CompilerInstance.cpp. to [scan-build] fix warnings emitted on Clang Frontend code base.
May 5 2016, 3:54 AM
apelete retitled D19963: [scan-build] fix warnings emitted on Clang Frontend code base from to [scan-build] fix warnings emitted on Clang Frontend code base Fix "Logic error" warnings of the type "Called C++ object pointer is null" reported by Clang Static Analyzer on the following file: lib/Frontend/CompilerInstance.cpp..
May 5 2016, 3:53 AM
apelete retitled D19385: [scan-build] fix warnings emitted on Clang Format code base from [scan-build] fix logic error warnings emitted on clang code base to [scan-build] fix warnings emitted on Clang Format code base.
May 5 2016, 3:43 AM
apelete updated the diff for D19385: [scan-build] fix warnings emitted on Clang Format code base.

[scan-build] fix warnings emitted on Clang Format code base

May 5 2016, 3:40 AM
apelete retitled D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base from to [scan-build] fix warnings emitted on Clang StaticAnalyzer code base.
May 5 2016, 3:27 AM
apelete retitled D19960: [scan-build] fix warnings emitted on Clang CodeGen code base from to [scan-build] fix warnings emitted on Clang CodeGen code base.
May 5 2016, 3:15 AM
apelete updated subscribers of D19278: [scan-build] fix warnings emitted on Clang Sema code base.
May 5 2016, 3:08 AM
apelete retitled D19278: [scan-build] fix warnings emitted on Clang Sema code base from [scan-build] fix logic error warnings emitted on clang code base to [scan-build] fix warnings emitted on Clang Sema code base.
May 5 2016, 3:07 AM
apelete updated the diff for D19278: [scan-build] fix warnings emitted on Clang Sema code base.

[scan-build] fix warnings emitted on Clang Sema code base

May 5 2016, 2:57 AM
apelete retitled D19959: [scan-build] fix warning emitted on Clang Driver code base from [scan-build] fix warning emitted on Clang Driver code base Fix a "logic error" warning of the type Called c++ object pointer is null" reported by Clang Static Analyzer on the file: - lib/Driver/Tools.cpp. to [scan-build] fix warning emitted on Clang Driver code base.
May 5 2016, 2:36 AM
apelete retitled D19959: [scan-build] fix warning emitted on Clang Driver code base from to [scan-build] fix warning emitted on Clang Driver code base Fix a "logic error" warning of the type Called c++ object pointer is null" reported by Clang Static Analyzer on the file: - lib/Driver/Tools.cpp..
May 5 2016, 2:34 AM
apelete retitled D19084: [scan-build] fix warnings emitted on Clang AST code base from [clang-analyzer] fix warnings emitted on clang code base to [scan-build] fix warnings emitted on Clang AST code base .
May 5 2016, 2:25 AM
apelete updated the diff for D19084: [scan-build] fix warnings emitted on Clang AST code base.

[scan-build] fix warnings emitted on Clang AST code base

May 5 2016, 2:21 AM

May 4 2016

apelete updated the diff for D19900: [scan-build] fix dead store warnings emitted on LLVM Hexagon code base.

[scan-build] fix dead store warnings emitted on LLVM Hexagon code base

May 4 2016, 10:32 AM
apelete added inline comments to D19900: [scan-build] fix dead store warnings emitted on LLVM Hexagon code base.
May 4 2016, 8:10 AM

May 3 2016

apelete retitled D19900: [scan-build] fix dead store warnings emitted on LLVM Hexagon code base from to [scan-build] fix dead store warnings emitted on LLVM Hexagon code base.
May 3 2016, 10:26 PM
apelete added a comment to D19831: [scan-build] fix dead store warnings emitted on clang code base.

Thanks - do you need someone (me) to commit this, or do you have commit
access?

May 3 2016, 2:49 PM
apelete updated the diff for D19831: [scan-build] fix dead store warnings emitted on clang code base.

[scan-build] fix dead store warnings emitted on clang code base

May 3 2016, 1:32 PM
apelete added a comment to D19810: [scan-build] fix logic error warning in LLVM AMDGPU target code base.

LGTM. Thanks!

May 3 2016, 12:27 PM
apelete added a comment to D19632: [scan-build] fix logic error warnings emitted on llvm code base.

Adding these asserts seems harmless.

May 3 2016, 12:26 PM
apelete added a comment to D19831: [scan-build] fix dead store warnings emitted on clang code base.

Looks good to me - go ahead & commit whenever you're ready.

May 3 2016, 12:12 PM
apelete updated the diff for D19831: [scan-build] fix dead store warnings emitted on clang code base.

[scan-build] fix dead store warnings emitted on clang code base

May 3 2016, 12:08 PM
apelete added inline comments to D19831: [scan-build] fix dead store warnings emitted on clang code base.
May 3 2016, 12:05 PM

May 2 2016

apelete updated the diff for D19831: [scan-build] fix dead store warnings emitted on clang code base.

[scan-build] fix dead store warnings emitted on clang code base

May 2 2016, 11:40 PM
apelete added a comment to D19831: [scan-build] fix dead store warnings emitted on clang code base.

Sorry, I meant remove the /store/, if it's dead. The do/while loop
overwrites the store immediately, so just remove the assignment to Record?

May 2 2016, 11:37 PM
apelete added a comment to D19831: [scan-build] fix dead store warnings emitted on clang code base.

Any reason not to remove the story instead?

May 2 2016, 2:59 PM
apelete retitled D19834: [scan-build] fix dead store warnings emitted on llvm-objdump code base from to [scan-build] fix dead store warnings emitted on llvm-objdump code base.
May 2 2016, 1:48 PM
apelete retitled D19833: [scan-build] fix dead store warnings emitted on LLVM AMDGPU code base from to [scan-build] fix dead store warnings emitted on LLVM AMDGPU code base.
May 2 2016, 1:44 PM
apelete retitled D19831: [scan-build] fix dead store warnings emitted on clang code base from to [scan-build] fix dead store warnings emitted on clang code base.
May 2 2016, 1:36 PM
apelete retitled D19830: [scan-build] fix dead store warnings emitted on clang code base from to [scan-build] fix dead store warnings emitted on clang code base.
May 2 2016, 1:32 PM
apelete retitled D19829: [scan-build] fix dead store warnings emitted on Clang Sema code base from to [scan-build] fix dead store warnings emitted on clang code base.
May 2 2016, 1:27 PM
apelete updated the diff for D19410: [scan-build] fix warnings emitted on LLVM ARM code base.

[scan-build] fix logic error warnings emitted on llvm code base

May 2 2016, 9:35 AM
apelete retitled D19810: [scan-build] fix logic error warning in LLVM AMDGPU target code base from to [scan-build] fix logic error warning in LLVM AMDGPU target code base.
May 2 2016, 9:32 AM
apelete added a comment to D19410: [scan-build] fix warnings emitted on LLVM ARM code base.

The AMDGPU changes look OK to me. If you want to commit those in a separate patch, that's fine with me.

May 2 2016, 9:29 AM

May 1 2016

apelete updated the diff for D19385: [scan-build] fix warnings emitted on Clang Format code base.

[scan-build] fix logic error warnings emitted on clang code base

May 1 2016, 1:03 PM
apelete added a comment to D19627: [scan-build] fix logic error warning emitted on compiler-rt code base.
In D19627#417229, @kcc wrote:

LGTM

May 1 2016, 10:11 AM
apelete added a comment to D19632: [scan-build] fix logic error warnings emitted on llvm code base.

Waiting for review, could someone please have a look at this one ?

May 1 2016, 10:08 AM
apelete added a reviewer for D19498: [scan-build] fix logic error warnings emitted on llvm code base: resistor.

Waiting for review, could someone please have a look at this one ?

May 1 2016, 10:08 AM
apelete added a comment to D19410: [scan-build] fix warnings emitted on LLVM ARM code base.

Waiting for review, could someone please have a look at this one ?

May 1 2016, 10:06 AM
apelete added a comment to D19385: [scan-build] fix warnings emitted on Clang Format code base.

Waiting for review, could someone please have a look at this one ?

May 1 2016, 10:05 AM
apelete added a reviewer for D19278: [scan-build] fix warnings emitted on Clang Sema code base: pcc.

Waiting for review, could someone please have a look at this one ?

May 1 2016, 10:03 AM
apelete added a comment to D19086: [clang-analyzer] fix warnings emitted on lldb code base.

Waiting for review, could someone please have a look at this one ?

May 1 2016, 9:57 AM
apelete added a reviewer for D19084: [scan-build] fix warnings emitted on Clang AST code base: rjmccall.

Waiting for review, could someone please have a look at this one ?

May 1 2016, 9:56 AM
apelete added a comment to D19083: [scan-build] fix warnings emitted on LLVM CodeGen code base.

Waiting for review, could someone please have a look at this one ?

May 1 2016, 9:53 AM