Page MenuHomePhabricator

export additional header modules from xmmintrin
ClosedPublic

Authored by jtsoftware on Mar 21 2016, 12:53 PM.

Details

Reviewers
rsmith
Summary

If someone only includes xmmintrin.h, but references any definitions from stdlib.h (included via mm_malloc.h), if module are enabled it will fail, but if modules are not enable, it will not fail to compile. This will fix this (if STDC_HOSTED is defined).

Diff Detail

Event Timeline

jtsoftware retitled this revision from to export additional header modules from xmmintrin.
jtsoftware updated this object.
jtsoftware added reviewers: silvas, probinson.
jtsoftware added a subscriber: cfe-commits.
rsmith added a subscriber: rsmith.Mar 21 2016, 5:49 PM
rsmith added inline comments.
lib/Headers/module.modulemap
48

Did you intentionally remove this comment?

56–58

You shouldn't need to add anything here. sse2 exports sse, which in turn exports mm_malloc and mmx, so users of sse2 get mm_malloc and mmx whether or not sse2 lists them. It's better for it to not do so, as they aren't direct dependencies.

jtsoftware edited reviewers, added: rsmith; removed: probinson, silvas.

Right. Also undoing moving stuff around. How about this? Thanks.

rsmith accepted this revision.Mar 22 2016, 12:51 PM
rsmith edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 22 2016, 12:51 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r264092.