Page MenuHomePhabricator

jtsoftware (John Thompson)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 12 2013, 11:34 AM (371 w, 23 h)

Recent Activity

Mar 22 2016

jtsoftware committed rL264092: D18325: Added mm_malloc module export..
D18325: Added mm_malloc module export.
Mar 22 2016, 2:03 PM
jtsoftware updated the diff for D18325: export additional header modules from xmmintrin.

Right. Also undoing moving stuff around. How about this? Thanks.

Mar 22 2016, 11:41 AM

Mar 21 2016

jtsoftware committed rL264001: Fixed some cases in the modularize assistant mode where header file names….
Fixed some cases in the modularize assistant mode where header file names…
Mar 21 2016, 4:10 PM
jtsoftware abandoned D9557: Remove duplicate type definitions from f16cintrin.h.

It looks like this has already been addressed.

Mar 21 2016, 1:11 PM
jtsoftware retitled D18325: export additional header modules from xmmintrin from to export additional header modules from xmmintrin.
Mar 21 2016, 12:53 PM

Dec 9 2015

jtsoftware committed rL255199: There were problems if a relative path is used for an include path, the path….
There were problems if a relative path is used for an include path, the path…
Dec 9 2015, 5:36 PM

Dec 4 2015

jtsoftware committed rL254785: Added coverage check for extensionless headers, and exclude hidden dot….
Added coverage check for extensionless headers, and exclude hidden dot…
Dec 4 2015, 2:45 PM
jtsoftware committed rL254756: Backing out 254635 until I have a good workaround and test case..
Backing out 254635 until I have a good workaround and test case.
Dec 4 2015, 11:47 AM

Dec 3 2015

jtsoftware committed rL254635: Fixed header determination logic. Was missing extensionless headers in….
Fixed header determination logic. Was missing extensionless headers in…
Dec 3 2015, 11:23 AM

Sep 2 2015

jtsoftware accepted D12539: Fix SEGV in InlineAsm::ConstraintInfo::Parse..

LGTM. Thanks!

Sep 2 2015, 5:04 PM

Jul 9 2015

jtsoftware committed rL241880: Added mechanism to modularize for doing a compilation precheck.
Added mechanism to modularize for doing a compilation precheck
Jul 9 2015, 5:37 PM

Jul 8 2015

jtsoftware committed rL241744: Fixed line-endings..
Fixed line-endings.
Jul 8 2015, 3:01 PM
jtsoftware committed rL241726: Fixed erroneous comments..
Fixed erroneous comments.
Jul 8 2015, 2:06 PM
jtsoftware committed rL241724: Fixed erroneous comment..
Fixed erroneous comment.
Jul 8 2015, 1:57 PM

Jun 24 2015

jtsoftware added a comment to D9929: Add missing modules/header - stage 1.

Could someone take a look at this please? Thanks.

Jun 24 2015, 11:56 AM

Jun 4 2015

jtsoftware committed rL239122: Fixed modularize to warn about missing headers referenced in a module map..
Fixed modularize to warn about missing headers referenced in a module map.
Jun 4 2015, 4:39 PM

Jun 3 2015

jtsoftware committed rL238998: Fixed option description. '=' is required..
Fixed option description. '=' is required.
Jun 3 2015, 6:16 PM
jtsoftware committed rL238997: Fixed option comment. '=' is required..
Fixed option comment. '=' is required.
Jun 3 2015, 6:14 PM

May 27 2015

jtsoftware committed rL238345: It appears these exports are needed, as wmmintrin.h includes them..
It appears these exports are needed, as wmmintrin.h includes them.
May 27 2015, 11:30 AM

May 26 2015

jtsoftware added a comment to D9557: Remove duplicate type definitions from f16cintrin.h.

If we want individual headers to be independent, we probably need a new header called something like. _intrinsic_types.h, as there are a few definitions like m256, m256d, and __m256i scattered among multiple headers. But actually, it seems to be the case that headers like f16cintrin.h are private headers under x86intrin.h, as indicated in the #error directive (#error "Never use <f16cintrin.h> directly; include <x86intrin.h> instead."), hence the need to be independent could be considered relaxed. If gnu is like this, it might be a good reason not to stray too far.

May 26 2015, 12:25 PM
jtsoftware added a comment to D9929: Add missing modules/header - stage 1.

Modularize catches this. I also forgot to mention that I only added some of the missing files in this patch, to get closer to Sony's version, to facilitate "cherry-picking", hence the "stage 1" in the title. The final (stage 2) will be to add the rest of the missing modules shortly thereafter.

May 26 2015, 11:58 AM

May 21 2015

jtsoftware edited reviewers for D9842: Added missing exports, added: ygao, probinson; removed: rsmith.
May 21 2015, 6:16 PM
jtsoftware retitled D9929: Add missing modules/header - stage 1 from to Add missing modules/header - stage 1.
May 21 2015, 6:15 PM
jtsoftware updated the diff for D9842: Added missing exports.

It turns out that these are the exports needed, since the wmmintrin.h file includes the aes and pclmul headers.

May 21 2015, 6:03 PM

May 18 2015

jtsoftware retitled D9842: Added missing exports from to Added missing exports.
May 18 2015, 6:09 PM

May 7 2015

jtsoftware updated subscribers of D9557: Remove duplicate type definitions from f16cintrin.h.
May 7 2015, 6:02 AM
jtsoftware retitled D9557: Remove duplicate type definitions from f16cintrin.h from to Remove duplicate type definitions from f16cintrin.h.
May 7 2015, 6:02 AM

May 6 2015

jtsoftware committed rL236625: Changed option processing to implicitly use -x c++ if no other -x option….
Changed option processing to implicitly use -x c++ if no other -x option…
May 6 2015, 11:46 AM
jtsoftware committed rL236624: Fixed infinite recursion bug..
Fixed infinite recursion bug.
May 6 2015, 11:42 AM

May 4 2015

jtsoftware abandoned D9229: [PATCH] clang internal library headers changes for C++ modules.

Turns out we don't need this after all. Sorry.

May 4 2015, 6:34 PM

Apr 24 2015

jtsoftware added a comment to D9229: [PATCH] clang internal library headers changes for C++ modules.

Our process for trying to get the SDK headers in shape for modules with
respect to duplicate definitions was to mechanically break out the
definition into a separate file and include that file in the affected
header. This was done without really contemplating why there were
duplicate definitions in the fist place. In this case, the _gnuc_va_list
symbol was defined in both BSD's machine/_types.h and Eli Friedman's
stdarg.h header, and the modularize tool flagged this.

Apr 24 2015, 6:47 PM
jtsoftware updated the diff for D9229: [PATCH] clang internal library headers changes for C++ modules.

Hi, we've decided to back out the changes to pmmintrin.h and xmmintrin.h and not create _denormals.h.

Apr 24 2015, 10:25 AM

Apr 23 2015

jtsoftware retitled D9229: [PATCH] clang internal library headers changes for C++ modules from to [PATCH] clang internal library headers changes for C++ modules.
Apr 23 2015, 12:09 PM

Mar 5 2015

jtsoftware committed rL231440: Renamed function to avoid confusion about purpose..
Renamed function to avoid confusion about purpose.
Mar 5 2015, 4:42 PM

Feb 26 2015

jtsoftware committed rL230665: Fixed canonical path function..
Fixed canonical path function.
Feb 26 2015, 11:33 AM

Feb 20 2015

jtsoftware committed rL230014: Deleted module-map-checker, as it's been folded into modularize..
Deleted module-map-checker, as it's been folded into modularize.
Feb 20 2015, 6:30 AM

Feb 19 2015

jtsoftware committed rL229869: Added module map coverage support, extracted from module-map-checker..
Added module map coverage support, extracted from module-map-checker.
Feb 19 2015, 8:49 AM
jtsoftware committed rL229855: Pruned some unneeded code and comments..
Pruned some unneeded code and comments.
Feb 19 2015, 6:34 AM

Feb 18 2015

jtsoftware committed rL229699: Fixed missing checkins..
Fixed missing checkins.
Feb 18 2015, 9:10 AM
jtsoftware committed rL229692: Added support for extracting headers from module maps as a source for the….
Added support for extracting headers from module maps as a source for the…
Feb 18 2015, 8:16 AM
jtsoftware committed rL229690: Temporary hack to avoid false errors. Real fix comming..
Temporary hack to avoid false errors. Real fix comming.
Feb 18 2015, 8:14 AM
jtsoftware committed rL229677: Updated file comment on modularize usage, as it was out-of-date..
Updated file comment on modularize usage, as it was out-of-date.
Feb 18 2015, 7:13 AM

Feb 17 2015

jtsoftware committed rL229540: Add canonical path conversion function and use it so paths are consistent..
Add canonical path conversion function and use it so paths are consistent.
Feb 17 2015, 12:46 PM

Feb 13 2015

jtsoftware committed rL229187: Fix broken logic for include in block check..
Fix broken logic for include in block check.
Feb 13 2015, 3:34 PM
jtsoftware committed rL229108: Moved header list loading to new class. This is staging for adding module map….
Moved header list loading to new class. This is staging for adding module map…
Feb 13 2015, 6:31 AM

Feb 12 2015

jtsoftware committed rL228941: Fix broken test in separate build tree..
Fix broken test in separate build tree.
Feb 12 2015, 9:54 AM
jtsoftware committed rL228935: Added support for multiple header list files, as a precursor for when we need….
Added support for multiple header list files, as a precursor for when we need…
Feb 12 2015, 8:24 AM
jtsoftware committed rL228929: Fixed incorrect header inclusion tracking resulting in false error reports..
Fixed incorrect header inclusion tracking resulting in false error reports.
Feb 12 2015, 7:28 AM

Feb 11 2015

jtsoftware committed rL228846: Added -block-check-header-list-only option. This is a work-around for private….
Added -block-check-header-list-only option. This is a work-around for private…
Feb 11 2015, 9:00 AM
jtsoftware committed rL228845: Centralize canonical path conversion..
Centralize canonical path conversion.
Feb 11 2015, 8:47 AM

Feb 10 2015

jtsoftware committed rL228695: Fixed module-map-checker to recurse umbrella dirs when collecting headers..
Fixed module-map-checker to recurse umbrella dirs when collecting headers.
Feb 10 2015, 7:00 AM
jtsoftware committed rL228693: Renamed module.map to module.modulemap (modularize)..
Renamed module.map to module.modulemap (modularize).
Feb 10 2015, 6:47 AM
jtsoftware committed rL228692: Renamed module.map to module.modulemap..
Renamed module.map to module.modulemap.
Feb 10 2015, 6:31 AM
jtsoftware committed rL228689: The -I option needs a space, apparently, from the actual implementation..
The -I option needs a space, apparently, from the actual implementation.
Feb 10 2015, 5:53 AM
jtsoftware abandoned D7475: merge module-map-checker into modularize.

Got. Thanks.

Feb 10 2015, 5:22 AM

Feb 6 2015

jtsoftware added a comment to D7475: merge module-map-checker into modularize.

The change for adding the recursion was a 4-line change:

Feb 6 2015, 5:54 PM
jtsoftware updated subscribers of D7475: merge module-map-checker into modularize.
Feb 6 2015, 2:47 PM
jtsoftware retitled D7475: merge module-map-checker into modularize from to merge module-map-checker into modularize.
Feb 6 2015, 2:47 PM

Nov 24 2014

jtsoftware updated the diff for D6324: pr21217 - -fmodule-map-file should warn on non-existent file.

Sorry, I missed the hard tab, braces, and etc. However, if I remove the clearing of the ModuleMapFiles member, one of the tests, Modules/modular_maps.cpp segfaults deep in some AST code, but only on running the test on Linux, so it's kind of hard to debug, not being much of a Linux/gdb guy. Did I put this code in the right place? I was kind of uncomfortable putting it in the HeaderSearch constructor, but it is a convenient place, since HeaderSearch has convenient members. I don't see any other references to the ModuleMapFiles member, so I'm not sure what triggers the segfault only on Linux, unless it's some memory-stomping or post-free-write issue somewhere.

Nov 24 2014, 6:00 PM

Nov 21 2014

jtsoftware updated the diff for D6324: pr21217 - -fmodule-map-file should warn on non-existent file.

Moved loading of -fmodule-map-file files to HeaderSearch initialization in Preprocessor initialization.
Changed diagnostic to an error.

Nov 21 2014, 2:54 PM

Nov 20 2014

jtsoftware updated the diff for D6324: pr21217 - -fmodule-map-file should warn on non-existent file.

Sean, thanks for adding Daniel.

Nov 20 2014, 12:17 PM

Nov 19 2014

jtsoftware updated D6324: pr21217 - -fmodule-map-file should warn on non-existent file.
Nov 19 2014, 12:33 PM
jtsoftware added a reviewer for D6324: pr21217 - -fmodule-map-file should warn on non-existent file: rsmith.
Nov 19 2014, 11:01 AM
jtsoftware retitled D6324: pr21217 - -fmodule-map-file should warn on non-existent file from to pr21217 - -fmodule-map-file should warn on non-existent file.
Nov 19 2014, 11:00 AM

May 7 2014

jtsoftware added a comment to D2671: preview patch for fixit for finding modules needing import/inclusion.

Sorry, I was too aggressive in cleaning out my Phabricator list, and closed this one by mistake. Though I did an initial check-in of it, I'm still working on a couple of the review issues Richard said could be postponed to a later check-in.

May 7 2014, 12:20 PM

May 5 2014

jtsoftware resigned from D2021: stdint.h should use the target's types, cleanup the targets.

Sorry, I don't feel qualified to review it.

May 5 2014, 6:51 PM
jtsoftware abandoned D1368: [PATCH] Repost of ArgumentsAdjuster change (part 2).

I handled it a different way.

May 5 2014, 6:48 PM
jtsoftware abandoned D1367: [PATCH] Repost using Phabricator of ArgumentsAdjuster change (part 1).

I handled it a different way.

May 5 2014, 6:47 PM
jtsoftware abandoned D1966: PPCallbacksTest expansion - part 1.

I created the tool pptrace as a basis for doing these kinds of tests instead.

May 5 2014, 6:22 PM
jtsoftware abandoned D2536: Fix failure to find header in module build.

Richard Smith already fixed it.

May 5 2014, 6:18 PM
jtsoftware closed D2671: preview patch for fixit for finding modules needing import/inclusion.

Committed in r206977 (plus fixes r206981 r207011).

May 5 2014, 6:14 PM
jtsoftware added a reviewer for D2671: preview patch for fixit for finding modules needing import/inclusion: jtsoftware.

Committed in r206977 (plus fixes r206981 r207011).

May 5 2014, 6:14 PM
jtsoftware closed D1474: modularize - header dependencies - version 2.

Committed in r189837 (and fixes r189983 r189984).

May 5 2014, 6:11 PM
jtsoftware closed D1648: modularize - Add checks for #include in 'extern "C/C++" {}' or 'namespace (name) {}' blocks.

Committed in r190950.

May 5 2014, 6:09 PM
jtsoftware closed D1891: Modularize assistant mode.

Committed in r191211 (docs in r192703).

May 5 2014, 6:07 PM
jtsoftware closed D2020: [extra] pptrace - preprocessor tracing and testing tool.

Committed in r193743 (and later fixes in r194440 r194422 r194081 r194079 r193842 r193841 r193746).

May 5 2014, 6:05 PM
jtsoftware closed D2443: [clang-tools-extra] module-map-checker - new tool for checking module.map coverage.

Committed in r198693.

May 5 2014, 6:00 PM