This patch adds a new expectedFailureArmLinux which marks arm-linux tests as xfails.
Also marked a couple of failing tests to use expectedFailureArmLinux decorator.
Paths
| Differential D15893
Adds expectedFailureArmLinux test decorator ClosedPublic Authored by omjavaid on Jan 5 2016, 9:23 AM.
Details Summary This patch adds a new expectedFailureArmLinux which marks arm-linux tests as xfails. Also marked a couple of failing tests to use expectedFailureArmLinux decorator.
Diff Detail Event Timelineomjavaid updated this object. clayborg edited edge metadata. Comment ActionsSeems like it would be better to mimic how @expectedFailureAndroid works. See inlined comments.
This revision now requires changes to proceed.Jan 5 2016, 10:10 AM Comment Actions Yes, please don't insert new decorators, we have enough as it is. You can achieve the behavior you want with the correct arguments to expectedFailureAll decorator. omjavaid edited edge metadata. Comment ActionsRemoved expectedFailureArmLinux and updated expectedFailureLinux decorator to reflect architecture if needed. Marked some triaged failures as xfails on arm with updated expectedFailureLinux decorator. LGTM? This revision is now accepted and ready to land.Jan 11 2016, 2:12 PM Closed by commit rL257405: Xfail some Arm-Linux specific failures (authored by omjavaid). · Explain WhyJan 11 2016, 2:56 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 44550 packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py
packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_set_command/TestWatchLocationWithWatchSet.py
packages/Python/lldbsuite/test/lldbtest.py
|
Seems like it would be better to do things like @expectedFailureAndroid that is just above:
I would like to avoid having new variants of the @expectedFailure that contain the architecture in the name.