Add 64/128 bit arm neon register definitions on linux
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Seems legit, but @omjavaid can probably better verify the relationships among these registers. However, I would like to request some tests for this. AFAIK, we don't have a lot of (if any) arm-specific register tests. E.g. TestRegisters is skipped for non-x86 arches, so we could use this opportunity to add some arm-specific tests there.
source/Plugins/Process/Utility/RegisterInfos_arm.h | ||
---|---|---|
41 ↗ | (On Diff #41134) | Was removing DBG_OFFSET intentional? |
Some minor typos inline comments.
I havnt applied nd tested this patch. Are you able to read these registers, i guess you need to generate neon or vfp code to test all registers properly.
There no arm register test to my knowledge currently in testsuite we can put this as a future todo to verify we are writing and reading properly.
source/Plugins/Process/Utility/RegisterInfos_arm.h | ||
---|---|---|
316 ↗ | (On Diff #41134) | here fpu_s24 is being repeated twice instead of fpu_s26. |
317 ↗ | (On Diff #41134) | here fpu_s28 is being repeated twice instead of fpu_s30. |
I made some of the tests in TestRegisters.py arm compatible (see D15010) and we also test register read/write in some extent with the gdb remote protocol tests (they caught several issues while I was doing this patch)
source/Plugins/Process/Utility/RegisterInfos_arm.h | ||
---|---|---|
41 ↗ | (On Diff #41134) | Yes because we don't use it in this file |
316 ↗ | (On Diff #41134) | Nice catch |
317 ↗ | (On Diff #41134) | Nice catch |