This is an archive of the discontinued LLVM Phabricator instance.

Run tests with dwo symbol files
ClosedPublic

Authored by tberghammer on Sep 30 2015, 11:46 AM.

Details

Summary

Run tests with dwo symbol file

dwo symbol files are generated when code compiled with the "-gsplit-dwarf" command option (https://gcc.gnu.org/wiki/DebugFission). This CL modifies the test system to run tests with inferiors compile with the "-gsplit-dwarf"

I tested "-gsplit-dwarf" on OSX, Linux and Android and there are no regression on these platform, for other platforms I have no access to at the moment but all recent compiler should support split dwarf (gcc 4.7+, clang 3.5+). If somebody know about configurations where split dwarf test should be disabled then please let me know, or disable them after commit by setting dont_do_dwo_test in dotest.py (see setting of dont_do_dsym_test in line 1520)

Diff Detail

Event Timeline

tberghammer retitled this revision from to Run tests with dwo symbol files.
tberghammer updated this object.
tberghammer added a subscriber: lldb-commits.
labath edited edge metadata.Oct 1 2015, 1:14 AM

Only small comments from me.

test/dotest_args.py
63

This help string sounds like it needs updating.

test/functionalities/dead-strip/TestDeadStrip.py
16

Could you file a bug about this?

clayborg accepted this revision.Oct 5 2015, 12:57 PM
clayborg edited edge metadata.

Back from vacation, sorry for the delay. Looks good.

This revision is now accepted and ready to land.Oct 5 2015, 12:57 PM
This revision was automatically updated to reflect the committed changes.

I committed in this CL in its current state (with fixing the issues raised by Pavel).

If you see any of the newly added dwo test failing on your platform then please skip/xfail them accordingly or let me know so I can take a look.

If you have to disable the running of all dwo related tests on a platform then you can do it with setting dont_do_dwo_test to True with the correct condition (see the setting of dont_do_dsym_test in dotest.py:1520)