Page MenuHomePhabricator

[GreedyRA ORE] Add function level spill/reloads stats
ClosedPublic

Authored by skatkov on Tue, Apr 6, 9:37 PM.

Diff Detail

Event Timeline

skatkov created this revision.Tue, Apr 6, 9:37 PM
skatkov requested review of this revision.Tue, Apr 6, 9:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Apr 6, 9:37 PM
thegameg accepted this revision.Tue, Apr 6, 9:51 PM
thegameg added a subscriber: thegameg.

This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.

This revision is now accepted and ready to land.Tue, Apr 6, 9:51 PM

This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.

Sure, I plan to upload all patches for reviewers to see the end point and then will add tests...

reames accepted this revision.Wed, Apr 7, 8:26 PM

This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.

Sure, I plan to upload all patches for reviewers to see the end point and then will add tests...

Meta: Please don't do this. Each patch should stand on it's own with the tests which are needed to motivate this patch.

Also LGTM contingent on a test being added before landing.

skatkov updated this revision to Diff 336035.Thu, Apr 8, 2:13 AM

Test updated.

This revision was landed with ongoing or failed builds.Thu, Apr 8, 2:56 AM
This revision was automatically updated to reflect the committed changes.