Page MenuHomePhabricator

skatkov (Serguei Katkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 25 2017, 1:38 AM (208 w, 1 d)

Recent Activity

Tue, Jan 19

skatkov accepted D94995: Loop peeling: check that latch is conditional branch.
Tue, Jan 19, 6:52 PM · Restricted Project

Wed, Jan 13

skatkov committed rG8f8c207b8f2e: [Verifier] Add tied-ness verification to statepoint intsruction (authored by skatkov).
[Verifier] Add tied-ness verification to statepoint intsruction
Wed, Jan 13, 12:12 AM
skatkov closed D94483: [Verifier] Add tied-ness verification to statepoint intsruction.
Wed, Jan 13, 12:12 AM · Restricted Project
skatkov updated the diff for D94483: [Verifier] Add tied-ness verification to statepoint intsruction.

Update before landing:
Upper bound check is added
verifier test is added

Wed, Jan 13, 12:03 AM · Restricted Project

Tue, Jan 12

skatkov committed rGfba9805ba349: [Verifier] Extend statepoint verifier to cover more constants (authored by skatkov).
[Verifier] Extend statepoint verifier to cover more constants
Tue, Jan 12, 9:01 PM
skatkov closed D94482: [Verifier] Extend statepoint verifier to cover more constants.
Tue, Jan 12, 9:00 PM · Restricted Project
skatkov committed rG157efd84abf8: [Statepoint Lowering] Add an option to allow use gc values in regs for landing… (authored by skatkov).
[Statepoint Lowering] Add an option to allow use gc values in regs for landing…
Tue, Jan 12, 8:49 PM
skatkov closed D94469: [Statepoint Lowering] Add an option to allow use gc values in regs for landing pad.
Tue, Jan 12, 8:48 PM · Restricted Project
skatkov committed rGf454c9f102a7: [InlineSpiller] Re-tie operands if folding failed (authored by skatkov).
[InlineSpiller] Re-tie operands if folding failed
Tue, Jan 12, 7:41 PM
skatkov closed D94389: [InlineSpiller]Re-tie operands if folding failed.
Tue, Jan 12, 7:40 PM · Restricted Project
skatkov requested review of D94483: [Verifier] Add tied-ness verification to statepoint intsruction.
Tue, Jan 12, 3:04 AM · Restricted Project
skatkov requested review of D94482: [Verifier] Extend statepoint verifier to cover more constants.
Tue, Jan 12, 2:46 AM · Restricted Project

Mon, Jan 11

skatkov requested review of D94469: [Statepoint Lowering] Add an option to allow use gc values in regs for landing pad.
Mon, Jan 11, 9:39 PM · Restricted Project
skatkov requested review of D94389: [InlineSpiller]Re-tie operands if folding failed.
Mon, Jan 11, 8:43 PM · Restricted Project
skatkov updated the diff for D94389: [InlineSpiller]Re-tie operands if folding failed.

Ok, I modified the patch to re-tie operands in case of folding failure.

Mon, Jan 11, 8:43 PM · Restricted Project
skatkov requested review of D94389: [InlineSpiller]Re-tie operands if folding failed.
Mon, Jan 11, 12:44 AM · Restricted Project

Sun, Jan 10

skatkov committed rG7f69860243e8: [LoopUnroll] Fix a crash (authored by skatkov).
[LoopUnroll] Fix a crash
Sun, Jan 10, 7:31 PM
skatkov closed D93686: [LoopUnroll] Fix a crash.
Sun, Jan 10, 7:30 PM · Restricted Project

Mon, Dec 28

skatkov updated the diff for D93686: [LoopUnroll] Fix a crash.

requested assert is added

Mon, Dec 28, 7:52 PM · Restricted Project

Wed, Dec 23

skatkov added inline comments to D93686: [LoopUnroll] Fix a crash.
Wed, Dec 23, 11:18 PM · Restricted Project
skatkov updated the diff for D93686: [LoopUnroll] Fix a crash.

Test is updated.

Wed, Dec 23, 10:26 PM · Restricted Project

Tue, Dec 22

skatkov added inline comments to D93686: [LoopUnroll] Fix a crash.
Tue, Dec 22, 6:59 PM · Restricted Project
skatkov updated the diff for D93686: [LoopUnroll] Fix a crash.

Handled comments,

Tue, Dec 22, 6:58 PM · Restricted Project

Dec 22 2020

skatkov requested review of D93686: [LoopUnroll] Fix a crash.
Dec 22 2020, 3:39 AM · Restricted Project

Dec 21 2020

skatkov added a comment to D86452: [LV] Fix scalar cost for tail predicated loops.

Will do. I expected some fallout from this one.

Thanks for the report. Ill try and take a look.

Dec 21 2020, 2:52 AM · Restricted Project
skatkov added a comment to D86452: [LV] Fix scalar cost for tail predicated loops.

@dmgreen While I'm not sure this patch is a real root cause of the loop vectorizer crash https://bugs.llvm.org/show_bug.cgi?id=48564 but revert of this patch eliminates the crash.
I would appreciate if you could look into the bug.

Dec 21 2020, 2:46 AM · Restricted Project

Dec 18 2020

skatkov accepted D93521: [IndVars] A test for adding trunc instructions to unwind blocks.
Dec 18 2020, 1:25 AM · Restricted Project

Dec 17 2020

skatkov accepted D93449: [Statepoints] Disable VReg lowering for values used on exception path of invoke..

lgtm

Dec 17 2020, 11:01 PM · Restricted Project
skatkov accepted D93509: [IndVars] Fix adding trunc instructions for unwind blocks.

Good catch!

Dec 17 2020, 8:32 PM · Restricted Project

Dec 7 2020

skatkov added a comment to D92743: [ScalarizeMaskedMemIntrin] Add new PM support.

Oh and add a -passes=scalarize-masked-mem-intrin RUN line to one of the tests just to make sure it works

Dec 7 2020, 9:43 PM · Restricted Project
skatkov accepted D92743: [ScalarizeMaskedMemIntrin] Add new PM support.

Please consider separate renaming to Legacy to NFC patch.

I thought about it and saw that the renaming was done as part of same patch for new PM support for other passes as well (and I think it was intentional, in showing the need for the name update). :) If you feel strongly about it, I can do so.

Dec 7 2020, 7:26 PM · Restricted Project
skatkov accepted D92407: [ScalarizeMaskedMemIntrinsic] Move from CodeGen into Transforms.

lgtm.

Dec 7 2020, 7:22 PM · Restricted Project

Dec 6 2020

skatkov added a comment to D92743: [ScalarizeMaskedMemIntrin] Add new PM support.

Please consider separate renaming to Legacy to NFC patch.

Dec 6 2020, 8:17 PM · Restricted Project
skatkov added inline comments to D92743: [ScalarizeMaskedMemIntrin] Add new PM support.
Dec 6 2020, 8:15 PM · Restricted Project

Nov 25 2020

skatkov accepted D92152: [SCEV] Use isKnownPredicateAt in isLoopBackedgeGuardedByCond.
Nov 25 2020, 10:02 PM · Restricted Project

Nov 23 2020

skatkov accepted D90456: [IndVars] Use more precise context when eliminating narrowing.

It is pity that we did not introduce an useful utility function.

Nov 23 2020, 10:27 PM · Restricted Project

Nov 22 2020

skatkov added inline comments to D91767: [DomTree][NFC] Introduce function that finds common dom of multiple instructions.
Nov 22 2020, 10:37 PM · Restricted Project
skatkov added inline comments to D91767: [DomTree][NFC] Introduce function that finds common dom of multiple instructions.
Nov 22 2020, 10:29 PM · Restricted Project

Nov 19 2020

skatkov accepted D91593: [IndVars] LCSSA Phi users should not prevent widening.

lgtm

Nov 19 2020, 7:03 PM · Restricted Project
skatkov accepted D91767: [DomTree][NFC] Introduce function that finds common dom of multiple instructions.

Probably it makes sense to wait a bit for @kuhar review as @asbirlea requested.

Nov 19 2020, 6:38 PM · Restricted Project
skatkov added inline comments to D91767: [DomTree][NFC] Introduce function that finds common dom of multiple instructions.
Nov 19 2020, 2:48 AM · Restricted Project
skatkov accepted D90456: [IndVars] Use more precise context when eliminating narrowing.
Nov 19 2020, 1:47 AM · Restricted Project
skatkov added inline comments to D90456: [IndVars] Use more precise context when eliminating narrowing.
Nov 19 2020, 12:51 AM · Restricted Project

Nov 18 2020

skatkov accepted D91535: [IndVars] Use isLoopBackedgeGuardedByCond for last iteration check.
Nov 18 2020, 8:14 PM · Restricted Project
skatkov added inline comments to D91535: [IndVars] Use isLoopBackedgeGuardedByCond for last iteration check.
Nov 18 2020, 1:13 AM · Restricted Project
skatkov accepted D88528: [IndVars] Support different types of ExitCount when optimizing exit conds.

lgtm

Nov 18 2020, 12:48 AM · Restricted Project

Nov 17 2020

skatkov added inline comments to D90456: [IndVars] Use more precise context when eliminating narrowing.
Nov 17 2020, 11:02 PM · Restricted Project
skatkov added inline comments to D91327: [NewPM] Redesign of PreserveCFG Checker.
Nov 17 2020, 10:43 PM · Restricted Project, Restricted Project
skatkov added a comment to D91324: [NewPM] Disable PreserveCFGChecker and add regression unit tests.

I do not mind.

Nov 17 2020, 8:27 AM · Restricted Project

Nov 16 2020

skatkov accepted D91324: [NewPM] Disable PreserveCFGChecker and add regression unit tests.

Do I understand correctly that with -verify-cfg-preserved=true all new tests fail?

Nov 16 2020, 8:23 PM · Restricted Project

Nov 15 2020

skatkov committed rG400f6edce754: [IRCE] Use the same min runtime iteration threshold for BPI and BFI checks (authored by skatkov).
[IRCE] Use the same min runtime iteration threshold for BPI and BFI checks
Nov 15 2020, 6:54 PM
skatkov closed D91230: [IRCE] Use the same min runtime iteration threshold for BPI and BFI checks.
Nov 15 2020, 6:54 PM · Restricted Project

Nov 12 2020

skatkov updated the diff for D91230: [IRCE] Use the same min runtime iteration threshold for BPI and BFI checks.
Nov 12 2020, 1:40 AM · Restricted Project

Nov 11 2020

skatkov accepted D88527: [IndVars] Replace checks with invariants if we cannot remove them.

lgtm with Anna's nit + please do a rebase.

Nov 11 2020, 9:28 PM · Restricted Project
skatkov added inline comments to D88527: [IndVars] Replace checks with invariants if we cannot remove them.
Nov 11 2020, 9:09 PM · Restricted Project
skatkov accepted D89550: [IndVars] Recognize 'sub nuw' expressed as 'add' for widening.

lgtm

Nov 11 2020, 2:28 AM · Restricted Project

Nov 10 2020

skatkov added a comment to D91230: [IRCE] Use the same min runtime iteration threshold for BPI and BFI checks.

It looks like the threshold 10 you are referring is coming from some option. Can we use the same option in both places instead?

Nov 10 2020, 11:24 PM · Restricted Project
skatkov requested review of D91230: [IRCE] Use the same min runtime iteration threshold for BPI and BFI checks.
Nov 10 2020, 8:48 PM · Restricted Project

Oct 26 2020

skatkov committed rGb69919b537ff: [GVN LoadPRE] Add an option to disable splitting backedge (authored by skatkov).
[GVN LoadPRE] Add an option to disable splitting backedge
Oct 26 2020, 10:32 PM
skatkov closed D89854: [GVN LoadPRE] Add an option to disable splitting backedge.
Oct 26 2020, 10:32 PM · Restricted Project
skatkov added a comment to D89854: [GVN LoadPRE] Add an option to disable splitting backedge.

Fine by me, but please wait some time in case anyone has cons.

Oct 26 2020, 8:04 PM · Restricted Project

Oct 21 2020

skatkov committed rG75d0e0cd5f4c: [IRCE] consolidate profitability check (authored by skatkov).
[IRCE] consolidate profitability check
Oct 21 2020, 9:46 PM
skatkov closed D89773: [IRCE] consolidate profitability check.
Oct 21 2020, 9:45 PM · Restricted Project
skatkov added a comment to D89854: [GVN LoadPRE] Add an option to disable splitting backedge.

This seems reasonable. Do you plan to use this option in the default pipeline/do you think there are any benefits for the regular pipeline?

Oct 21 2020, 9:21 PM · Restricted Project
skatkov updated the diff for D89854: [GVN LoadPRE] Add an option to disable splitting backedge.

handled nit

Oct 21 2020, 9:16 PM · Restricted Project
skatkov accepted D88861: GC-parseable element atomic memcpy/memmove.

ok, this looks good to me. Please wait 1-2 days before landing to give a last call to others.

Oct 21 2020, 9:12 PM · Restricted Project
skatkov added a comment to D89773: [IRCE] consolidate profitability check.

This is a promised follow-up after D89451.

Is this a typo?

Oct 21 2020, 7:54 PM · Restricted Project
skatkov updated the summary of D89773: [IRCE] consolidate profitability check.
Oct 21 2020, 7:53 PM · Restricted Project
skatkov added inline comments to D88861: GC-parseable element atomic memcpy/memmove.
Oct 21 2020, 3:47 AM · Restricted Project

Oct 20 2020

skatkov requested review of D89854: [GVN LoadPRE] Add an option to disable splitting backedge.
Oct 20 2020, 11:52 PM · Restricted Project
skatkov updated the diff for D89773: [IRCE] consolidate profitability check.

Please take a look.

Oct 20 2020, 3:31 AM · Restricted Project
skatkov requested review of D89773: [IRCE] consolidate profitability check.
Oct 20 2020, 2:05 AM · Restricted Project

Oct 19 2020

skatkov committed rG38799975ceb2: [IRCE] Do not transform if loop has small number of iterations (authored by skatkov).
[IRCE] Do not transform if loop has small number of iterations
Oct 19 2020, 8:42 PM
skatkov closed D89541: [IRCE] Do not transform is loop has small number of iterations.
Oct 19 2020, 8:42 PM · Restricted Project
skatkov added inline comments to D89541: [IRCE] Do not transform is loop has small number of iterations.
Oct 19 2020, 8:02 PM · Restricted Project
skatkov updated the diff for D89541: [IRCE] Do not transform is loop has small number of iterations.

Handled Max's comments.

Oct 19 2020, 2:44 AM · Restricted Project
skatkov added inline comments to D89541: [IRCE] Do not transform is loop has small number of iterations.
Oct 19 2020, 2:43 AM · Restricted Project

Oct 18 2020

skatkov added inline comments to D89541: [IRCE] Do not transform is loop has small number of iterations.
Oct 18 2020, 9:36 PM · Restricted Project

Oct 16 2020

skatkov requested review of D89541: [IRCE] Do not transform is loop has small number of iterations.
Oct 16 2020, 4:23 AM · Restricted Project

Oct 9 2020

skatkov accepted D87915: [Statepoints] Unlimited tied operands..
Oct 9 2020, 7:56 AM · Restricted Project

Oct 8 2020

skatkov accepted D88999: [Statepoints] Allow deopt GC pointer on VReg if gc-live bundle is empty..
Oct 8 2020, 11:49 PM · Restricted Project
skatkov added inline comments to D87915: [Statepoints] Unlimited tied operands..
Oct 8 2020, 11:39 PM · Restricted Project

Oct 5 2020

skatkov committed rGb9888980132e: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety… (authored by skatkov).
[GVN LoadPRE] Extend the scope of optimization by using context to prove safety…
Oct 5 2020, 7:27 PM
skatkov closed D88725: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety of speculation.
Oct 5 2020, 7:27 PM · Restricted Project

Oct 4 2020

skatkov updated the diff for D88725: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety of speculation.

Handled comments. Will wait for a day to give a chance for Roman, Philip and Max to take a look one more time.

Oct 4 2020, 9:41 PM · Restricted Project
skatkov added inline comments to D88725: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety of speculation.
Oct 4 2020, 7:28 PM · Restricted Project

Oct 2 2020

skatkov updated the diff for D88725: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety of speculation.

test is precomitted.

Oct 2 2020, 4:01 AM · Restricted Project
skatkov added inline comments to D88725: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety of speculation.
Oct 2 2020, 3:59 AM · Restricted Project
skatkov committed rG8ae1369f794c: [GVN LoadPRE] Add test to show an opportunty. (authored by skatkov).
[GVN LoadPRE] Add test to show an opportunty.
Oct 2 2020, 3:54 AM
skatkov requested review of D88725: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety of speculation.
Oct 2 2020, 3:09 AM · Restricted Project

Oct 1 2020

skatkov accepted D87154: [Statepoints] Change statepoint machine instr format to better suit VReg lowering..

Please wait for 1-2 days in case Philip wants to look at this patch.

Oct 1 2020, 3:01 AM · Restricted Project

Sep 30 2020

skatkov added inline comments to D87154: [Statepoints] Change statepoint machine instr format to better suit VReg lowering..
Sep 30 2020, 7:52 PM · Restricted Project

Sep 29 2020

skatkov added inline comments to D87154: [Statepoints] Change statepoint machine instr format to better suit VReg lowering..
Sep 29 2020, 11:22 PM · Restricted Project
skatkov committed rG297ec6113046: [IsKnownNonZero] Handle the case with non-constant phi nodes (authored by skatkov).
[IsKnownNonZero] Handle the case with non-constant phi nodes
Sep 29 2020, 1:22 AM
skatkov closed D88276: [IsKnownNonZero] Handle the case with non-constant phi nodes.
Sep 29 2020, 1:22 AM · Restricted Project

Sep 28 2020

skatkov updated the diff for D88276: [IsKnownNonZero] Handle the case with non-constant phi nodes.

git rid of additional check for context instruction.

Sep 28 2020, 8:21 PM · Restricted Project
skatkov added inline comments to D88276: [IsKnownNonZero] Handle the case with non-constant phi nodes.
Sep 28 2020, 4:49 AM · Restricted Project

Sep 27 2020

skatkov added a comment to D88276: [IsKnownNonZero] Handle the case with non-constant phi nodes.

Nit: consider Q.getWithInstruction, no strong feelings.

Q is not SimplifyQuery here, how I could take a getWithInstruction then?

You won't, just ignore that part ;)

Sep 27 2020, 11:00 PM · Restricted Project
skatkov updated the summary of D88276: [IsKnownNonZero] Handle the case with non-constant phi nodes.
Sep 27 2020, 11:00 PM · Restricted Project
skatkov added a comment to D88276: [IsKnownNonZero] Handle the case with non-constant phi nodes.

Nit: consider Q.getWithInstruction, no strong feelings.

Q is not SimplifyQuery here, how I could take a getWithInstruction then?

Sep 27 2020, 10:51 PM · Restricted Project