[GreedyRA ORE] Add function level spill/reloads stats

[thegameg]

This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.

[skatkov]

In D100014#2673150, @thegameg wrote:

This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.

Sure, I plan to upload all patches for reviewers to see the end point and then will add tests...

[reames]

In D100014#2673174, @skatkov wrote:

In D100014#2673150, @thegameg wrote:

This looks good too, thanks! Please add a test or extend the ones in llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll.

Sure, I plan to upload all patches for reviewers to see the end point and then will add tests...

Meta: Please don't do this. Each patch should stand on it's own with the tests which are needed to motivate this patch.

Also LGTM contingent on a test being added before landing.

[skatkov]

Test updated.

llvm/lib/CodeGen/RegAllocGreedy.cpp

if (!Stats.isEmpty()) {
     });
   }
   return Stats;
 }
 
 void RAGreedy::reportNumberOfSplillsReloads() {
   if (!ORE->allowExtraAnalysis(DEBUG_TYPE))
     return;
+  RAGreedyStats Stats;
   for (MachineLoop *L : *Loops)
-    reportNumberOfSplillsReloads(L);
+    Stats.add(reportNumberOfSplillsReloads(L));
+  // Process non-loop blocks.
+  for (MachineBasicBlock &MBB : *MF)
+    if (!Loops->getLoopFor(&MBB))
+      Stats.add(computeNumberOfSplillsReloads(MBB));
+  if (!Stats.isEmpty()) {
+    using namespace ore;
+
+    ORE->emit([&]() {
+      MachineOptimizationRemarkMissed R(DEBUG_TYPE, "SpillReload", DebugLoc(),
+                                        &MF->front());
+      Stats.report(R);
+      R << "generated in function";
+      return R;
+    });
+  }
 }
 
 bool RAGreedy::runOnMachineFunction(MachineFunction &mf) {
   LLVM_DEBUG(dbgs() << "********** GREEDY REGISTER ALLOCATION **********\n"
                     << "********** Function: " << mf.getName() << '\n');
 
   MF = &mf;
   TRI = MF->getSubtarget().getRegisterInfo();

llvm/test/CodeGen/AArch64/arm64-spill-remarks.ll

 ; then reloaded.
 
 ; (loop3:)
 ; REMARK: remark: /tmp/kk.c:3:20: 1 spills 1 reloads generated in loop{{$}}
 ; (loop2:)
 ; REMARK: remark: /tmp/kk.c:2:20: 1 spills 1 reloads generated in loop{{$}}
 ; (loop:)
 ; REMARK: remark: /tmp/kk.c:1:20: 2 spills 2 reloads generated in loop{{$}}
+; (func:)
+; REMARK: remark: <unknown>:0:0: 3 spills 3 reloads generated in function{{$}}
 
 ; (loop3:)
 ; HOTNESS: remark: /tmp/kk.c:3:20: 1 spills 1 reloads generated in loop (hotness: 300)
 ; (loop2:)
 ; HOTNESS: remark: /tmp/kk.c:2:20: 1 spills 1 reloads generated in loop (hotness: 30000)
 ; (loop:)
 ; HOTNESS: remark: /tmp/kk.c:1:20: 2 spills 2 reloads generated in loop (hotness: 300)
 

 ; YAML: Hotness:         300
 ; YAML: Args:
 ; YAML:   - NumSpills:       '2'
 ; YAML:   - String:          ' spills '
 ; YAML:   - NumReloads:      '2'
 ; YAML:   - String:          ' reloads '
 ; YAML:   - String:          generated in loop
 ; YAML: ...
+; YAML: --- !Missed
+; YAML: Pass:            regalloc
+; YAML: Name:            SpillReload
+; YAML: Function:        fpr128
+; YAML: Hotness:         3
+; YAML: Args:
+; YAML:   - NumSpills:       '3'
+; YAML:   - String:          ' spills '
+; YAML:   - NumReloads:      '3'
+; YAML:   - String:          ' reloads '
+; YAML:   - String:          generated in function
+; YAML: ...
 
 ; THRESHOLD_YAML-NOT: Hotness:         300{{$}}
 ; THRESHOLD_YAML: --- !Missed
 ; THRESHOLD_YAML: Pass:            regalloc
 ; THRESHOLD_YAML: Name:            LoopSpillReload
 ; THRESHOLD_YAML: DebugLoc:        { File: '/tmp/kk.c', Line: 2, Column: 20 }
 ; THRESHOLD_YAML: Function:        fpr128
 ; THRESHOLD_YAML: Hotness:         30000