[GreedyRA ORE] Extract computeNumberOfSplillsReloads to use in different places. NFC.

[skatkov]

Summary

Extract one basic block handling to introduce stat computation for method scope.

[thegameg]

llvm/lib/CodeGen/RegAllocGreedy.cpp

576

[reames]

LGTM w/comment fixed.

llvm/lib/CodeGen/RegAllocGreedy.cpp

void add(RAGreedyStats other) {
       FoldedReloads += other.FoldedReloads;
       Spills += other.Spills;
       FoldedSpills += other.FoldedSpills;
     }
 
     void report(MachineOptimizationRemarkMissed &R);
   };
 
-  /// Compute and report the number of spills and reloads for a loop.
+  /// Compute the number of spills and reloads for a basic block.
+  RAGreedyStats computeNumberOfSplillsReloads(MachineBasicBlock &MBB);
+
+  /// Compute and report the number of spills through a remark.
   RAGreedyStats reportNumberOfSplillsReloads(MachineLoop *L);
 
   /// Report the number of spills and reloads for each loop.
   void reportNumberOfSplillsReloads();
 };
 
 } // end anonymous namespace
 
 char RAGreedy::ID = 0;
 char &llvm::RAGreedyID = RAGreedy::ID;
 
void RAGreedy::RAGreedyStats::report(MachineOptimizationRemarkMissed &R) {
   if (FoldedSpills)
     R << NV("NumFoldedSpills", FoldedSpills) << " folded spills ";
   if (Reloads)
     R << NV("NumReloads", Reloads) << " reloads ";
   if (FoldedReloads)
     R << NV("NumFoldedReloads", FoldedReloads) << " folded reloads ";
 }
 
-RAGreedy::RAGreedyStats RAGreedy::reportNumberOfSplillsReloads(MachineLoop *L) {
+RAGreedy::RAGreedyStats
+RAGreedy::computeNumberOfSplillsReloads(MachineBasicBlock &MBB) {
   RAGreedyStats Stats;
-
-  // Sum up the spill and reloads in subloops.
-  for (MachineLoop *SubLoop : *L)
-    Stats.add(reportNumberOfSplillsReloads(SubLoop));
-
   const MachineFrameInfo &MFI = MF->getFrameInfo();
   int FI;
 
-  for (MachineBasicBlock *MBB : L->getBlocks())
-    // Handle blocks that were not included in subloops.
-    if (Loops->getLoopFor(MBB) == L)
-      for (MachineInstr &MI : *MBB) {
-        SmallVector<const MachineMemOperand *, 2> Accesses;
-        auto isSpillSlotAccess = [&MFI](const MachineMemOperand *A) {
-          return MFI.isSpillSlotObjectIndex(
-              cast<FixedStackPseudoSourceValue>(A->getPseudoValue())
-                  ->getFrameIndex());
-        };
+  for (MachineInstr &MI : MBB) {
+      return MFI.isSpillSlotObjectIndex(cast<FixedStackPseudoSourceValue>(
+          A->getPseudoValue())->getFrameIndex());
 
-        if (TII->isLoadFromStackSlot(MI, FI) && MFI.isSpillSlotObjectIndex(FI))
-          ++Stats.Reloads;
-        else if (TII->hasLoadFromStackSlot(MI, Accesses) &&
-                 llvm::any_of(Accesses, isSpillSlotAccess))
-          ++Stats.FoldedReloads;
-        else if (TII->isStoreToStackSlot(MI, FI) &&
-                 MFI.isSpillSlotObjectIndex(FI))
-          ++Stats.Spills;
-        else if (TII->hasStoreToStackSlot(MI, Accesses) &&
-                 llvm::any_of(Accesses, isSpillSlotAccess))
-          ++Stats.FoldedSpills;
-      }
+    else if (TII->isStoreToStackSlot(MI, FI) && MFI.isSpillSlotObjectIndex(FI))
+  return Stats;
+}
+
+RAGreedy::RAGreedyStats RAGreedy::reportNumberOfSplillsReloads(MachineLoop *L) {
+  RAGreedyStats Stats;
+
+  // Sum up the spill and reloads in subloops.
+  for (MachineLoop *SubLoop : *L)
+    Stats.add(reportNumberOfSplillsReloads(SubLoop));
+
+  for (MachineBasicBlock *MBB : L->getBlocks())
+    // Handle blocks that were not included in subloops.
+    if (Loops->getLoopFor(MBB) == L)
+      Stats.add(computeNumberOfSplillsReloads(*MBB));
 
   if (!Stats.isEmpty()) {
     using namespace ore;
 
     ORE->emit([&]() {
       MachineOptimizationRemarkMissed R(DEBUG_TYPE, "LoopSpillReload",
                                         L->getStartLoc(), L->getHeader());
       Stats.report(R);