Page MenuHomePhabricator

[Orc][examples] Add lit ToolSubst for LLJITWithRemoteDebugging example
ClosedPublic

Authored by sgraenitz on Apr 6 2021, 1:54 AM.

Details

Summary

The test case added in 258f055ed936 was lacking two important details for the test infrastructure. ae217bf1f327 added the executable to LLVM_TEST_DEPENDS in CMake to make sure the exectubale gets built before we run the test suite. This patch adds a ToolSubst for the executable in LIT, which replaces the tool invokation in the RUN line with an absolute path. It makes sure we don't run accidentally run some other tool from the user's PATH. The test works without it in case LLVM's main binary directory happens to be the working directory (which is default apparently). Configurations that don't build the examples ignore failures for this ToolSubst (and won't run the test).

Diff Detail

Event Timeline

sgraenitz requested review of this revision.Apr 6 2021, 1:54 AM
sgraenitz created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2021, 1:54 AM
echristo accepted this revision.Apr 6 2021, 8:35 AM
This revision is now accepted and ready to land.Apr 6 2021, 8:35 AM
This revision was landed with ongoing or failed builds.Apr 7 2021, 12:47 AM
This revision was automatically updated to reflect the committed changes.