This is an archive of the discontinued LLVM Phabricator instance.

[lld-macho][nfc] POC for 32 bit support
AbandonedPublic

Authored by tschuett on Apr 3 2021, 10:54 AM.

Details

Reviewers
int3
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

tschuett created this revision.Apr 3 2021, 10:54 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
tschuett requested review of this revision.Apr 3 2021, 10:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2021, 10:54 AM
tschuett updated this revision to Diff 335094.Apr 3 2021, 11:29 AM

less hacky

tschuett updated this revision to Diff 335095.Apr 3 2021, 11:37 AM

minimize diff

tschuett updated this revision to Diff 335096.Apr 3 2021, 11:41 AM

even smaller diff

Harbormaster completed remote builds in B97002: Diff 335095.
int3 added a comment.Apr 3 2021, 2:10 PM

I'm not really seeing how this is better than the current implementation. Could you explain?

Nope is fine. But it keeps the section and section_64 instead of the offset in getEmbeddedAddend.

lld/MachO/Target.h
32

This template hack is gone now.

int3 added a comment.Apr 4 2021, 11:51 PM

Yeah I'm not a fan of this. I think passing the offset is fine: we call it in exactly one place in the code, so there's little risk of confusion. And LLD-ELF has a similar design.

tschuett abandoned this revision.Apr 5 2021, 12:01 AM

No problem.