This is an archive of the discontinued LLVM Phabricator instance.

[Windows] Turn off text mode correctly in Rewriter to stop CRLF translation
ClosedPublic

Authored by abhina.sreeskantharajan on Apr 3 2021, 5:20 AM.

Details

Summary

I incorrectly changed the RewriteTestAction::ExecuteAction's file to binary instead of the proper RewriteIncludesAction::BeginSourceFileAction in https://reviews.llvm.org/rGbc5d4bcc2deb71ab647270c9754a83484b3d6f87. In the original commit, I actually changed RewriteIncludesAction::BeginSourceFileAction in https://reviews.llvm.org/rGfdb640ea30d416368b76b68b106deda580c6aced. This should fix the issue @aganea is facing.

Diff Detail