Page MenuHomePhabricator

[HIP] remove overloaded abs in header
ClosedPublic

Authored by yaxunl on Apr 1 2021, 8:57 AM.

Details

Summary

This function seems to be introduced by accident by https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1

Such overloaded abs function did not exist before the refactoring, and does not exist in https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/__clang_cuda_cmath.h

Conceptually it also does not make sense, since it adds something like

double abs(int x) {

return ::abs((double)x);

}

It caused regressions in CuPy.

Diff Detail

Event Timeline

yaxunl requested review of this revision.Apr 1 2021, 8:57 AM
yaxunl created this revision.

I have tested removing this did not cause regressions in our CI.

ashi1 accepted this revision.Apr 1 2021, 9:00 AM

LGTM, thank you.

This revision is now accepted and ready to land.Apr 1 2021, 9:00 AM
tra accepted this revision.Apr 1 2021, 9:12 AM
This revision was landed with ongoing or failed builds.Apr 1 2021, 9:26 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2021, 9:26 AM