[HIP] remove overloaded abs in header

[yaxunl]

Summary

This function seems to be introduced by accident by https://github.com/llvm/llvm-project/commit/aa2b593f1495a972a4a592952760ec9d5f7c01f1

Such overloaded abs function did not exist before the refactoring, and does not exist in https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/__clang_cuda_cmath.h

Conceptually it also does not make sense, since it adds something like

double abs(int x) {

return ::abs((double)x);

}

It caused regressions in CuPy.

[yaxunl]

I have tested removing this did not cause regressions in our CI.

[ashi1]

LGTM, thank you.

clang/lib/Headers/__clang_hip_cmath.h

__DEVICE__                                                                   \
       typename __hip_enable_if<std::numeric_limits<__T1>::is_specialized &&    \
                                    std::numeric_limits<__T2>::is_specialized,  \
                                __retty>::type                                  \
       __fn(__T1 __x, __T2 __y) {                                               \
     return __fn((double)__x, (double)__y);                                     \
   }
 #endif
 
-__HIP_OVERLOAD1(double, abs)
 __HIP_OVERLOAD1(double, acos)
 __HIP_OVERLOAD1(double, acosh)
 __HIP_OVERLOAD1(double, asin)
 __HIP_OVERLOAD1(double, asinh)
 __HIP_OVERLOAD1(double, atan)
 __HIP_OVERLOAD2(double, atan2)
 __HIP_OVERLOAD1(double, atanh)
 __HIP_OVERLOAD1(double, cbrt)