Page MenuHomePhabricator

Send email notification for failures on lldb android builder
ClosedPublic

Authored by chying on May 22 2015, 6:24 PM.

Details

Summary
  • Send email notification to lldb "duty rotation alias" for any failures
  • Ignore test failures on android-arm and android-aarch64

Diff Detail

Repository
rL LLVM

Event Timeline

chying updated this revision to Diff 26366.May 22 2015, 6:24 PM
chying retitled this revision from to Send email notification for failures on lldb android builder.
chying updated this object.
chying edited the test plan for this revision. (Show Details)
chying added reviewers: sivachandra, vharron.
chying added a subscriber: Unknown Object (MLST).
vharron requested changes to this revision.May 25 2015, 8:17 PM
vharron edited edge metadata.
vharron added inline comments.
zorg/buildbot/builders/LLDBBuilder.py
287 ↗(On Diff #26366)

I recommend something like:

flunkTestFailure = arch in ('arm', 'aarch64'):

That way, if we add more archs (x86_64 for example) after arm/arm64, it can be set back to true.

This revision now requires changes to proceed.May 25 2015, 8:17 PM
vharron added a comment.EditedMay 25 2015, 8:19 PM

Sorry, I mean

# i386/x86_64 are the only android arch that are expected to pass currently
flunkTestFailure = arch in ('i386', 'x86_64'):

I think the logic will be the same for x86_64, if it's added later, flunkTestFailure will have its initial value True in the original code.
I agree that the if statement could be eliminated.

chying updated this revision to Diff 26527.May 26 2015, 11:20 AM
chying edited edge metadata.

Simply code based on review feedback

sivachandra accepted this revision.May 29 2015, 12:35 PM
sivachandra edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.