[OCaml][Test] Fix and enable debuginfo.ml test.

[vaivaswatha]

Summary

get_or_create_type_array was used on a non-type MDNode.
Add interface for get_or_create_array and use that instead.

[jberdine]

LGTM

llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml

262

I wonder if this diff indicates that this data label ought to be e.g. types instead, to help avoid similar mistakes in the future? A counter-argument is that the LLVM-C header uses Data.

llvm/bindings/ocaml/debuginfo/debuginfo_ocaml.c

 |*                                                                            *|
 |* Note that these functions intentionally take liberties with the CAMLparamX *|
 |* macros, since most of the parameters are not GC heap objects.              *|
 |*                                                                            *|
 \*===----------------------------------------------------------------------===*/
 
 #include <string.h>
 
 #include "caml/memory.h"
 #include "caml/mlvalues.h"
 #include "llvm-c/Core.h"
 #include "llvm-c/DebugInfo.h"
 #include "llvm-c/Support.h"
 
 #include "llvm_ocaml.h"
 
 // This is identical to the definition in llvm_debuginfo.ml:DIFlag.t

 CAMLprim LLVMMetadataRef llvm_dibuild_get_or_create_type_array(value Builder,
                                                                value Data) {
 
   return LLVMDIBuilderGetOrCreateTypeArray(DIBuilder_val(Builder),
                                            (LLVMMetadataRef *)Op_val(Data),
                                            Wosize_val(Data));
 }
 
+CAMLprim LLVMMetadataRef llvm_dibuild_get_or_create_array(value Builder,
+                                                          value Data) {
+
+  return LLVMDIBuilderGetOrCreateArray(DIBuilder_val(Builder),
+                                       (LLVMMetadataRef *)Op_val(Data),
+                                       Wosize_val(Data));
+}
+
 CAMLprim LLVMMetadataRef llvm_dibuild_create_subroutine_type(
     value Builder, LLVMMetadataRef File, value ParameterTypes, value Flags) {
 
   return LLVMDIBuilderCreateSubroutineType(
       DIBuilder_val(Builder), File, (LLVMMetadataRef *)Op_val(ParameterTypes),
       Wosize_val(ParameterTypes), DIFlags_val(Flags));
 }
 

llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml

 
 external di_file_get_filename : file:Llvm.llmetadata -> string
   = "llvm_di_file_get_filename"
 
 external di_file_get_source : file:Llvm.llmetadata -> string
   = "llvm_di_file_get_source"
 
 external dibuild_get_or_create_type_array :
   lldibuilder -> data:Llvm.llmetadata array -> Llvm.llmetadata
   = "llvm_dibuild_get_or_create_type_array"
 
+external dibuild_get_or_create_array :
+  lldibuilder -> data:Llvm.llmetadata array -> Llvm.llmetadata
+  = "llvm_dibuild_get_or_create_array"
+
 external dibuild_create_subroutine_type :
   lldibuilder ->
   file:Llvm.llmetadata ->
   param_types:Llvm.llmetadata array ->
   lldiflags ->
   Llvm.llmetadata = "llvm_dibuild_create_subroutine_type"
 
 external dibuild_create_enumerator :

llvm/bindings/ocaml/debuginfo/llvm_debuginfo.mli

 val di_file_get_source : file:Llvm.llmetadata -> string
 (** [di_file_get_source f] Get the source of file [f]. *)
 
 val dibuild_get_or_create_type_array :
   lldibuilder -> data:Llvm.llmetadata array -> Llvm.llmetadata
 (** [dibuild_get_or_create_type_array] Create a type array.
     See LLVMDIBuilderGetOrCreateTypeArray. *)
 
+val dibuild_get_or_create_array :
+  lldibuilder -> data:Llvm.llmetadata array -> Llvm.llmetadata
+(** [dibuild_get_or_create_array] Create an array of DI Nodes.
+    See LLVMDIBuilderGetOrCreateArray. *)
+
 val dibuild_create_constant_value_expression :
   lldibuilder -> int -> Llvm.llmetadata
 (** [dibuild_create_constant_value_expression] Create a new descriptor for
     the specified variable that does not have an address, but does have
     a constant value. See LLVMDIBuilderCreateConstantValueExpression. *)
 
 val dibuild_create_global_variable_expression :
   lldibuilder ->

llvm/test/Bindings/OCaml/debuginfo.ml

let test_types dibuilder file_di m_di =
    *)
   let elements = [| enumerator1; enumerator2; enumerator3 |] in
   let enumeration_ty_di =
     Llvm_debuginfo.dibuild_create_enumeration_type dibuilder ~scope:namespace_di
       ~name:"EnumTest" ~file:file_di ~line_number:1 ~size_in_bits:64
       ~align_in_bits:0 ~elements ~class_ty:int64_ty_di
   in
   let elements_arr =
-    Llvm_debuginfo.dibuild_get_or_create_type_array dibuilder ~data:elements
+    Llvm_debuginfo.dibuild_get_or_create_array dibuilder ~data:elements
   in
   stdout_metadata elements_arr;
   (* CHECK: [[ELEMENTS_PTR:<0x[0-9a-f]*>]] = !{[[ENUMERATOR1_PTR]], [[ENUMERATOR2_PTR]], [[ENUMERATOR3_PTR]]}
    *)
   stdout_metadata enumeration_ty_di;
   (* CHECK: [[ENUMERATION_PTR:<0x[0-9a-f]*>]] = !DICompositeType(tag: DW_TAG_enumeration_type, name: "EnumTest", scope: [[NAMESPACE_PTR]], file: [[FILE_PTR]], line: 1, baseType: [[INT64TY_PTR]], size: 64, elements: [[ELEMENTS_PTR]])
    *)
   insist