Page MenuHomePhabricator

[OCaml][Test] Fix and enable debuginfo.ml test.
ClosedPublic

Authored by vaivaswatha on Mar 26 2021, 7:10 PM.

Details

Summary

get_or_create_type_array was used on a non-type MDNode.
Add interface for get_or_create_array and use that instead.

Diff Detail

Event Timeline

vaivaswatha created this revision.Mar 26 2021, 7:10 PM
vaivaswatha requested review of this revision.Mar 26 2021, 7:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 7:10 PM
musstudxxx changed the visibility from "Public (No Login Required)" to "musstudxxx (josh Jackson)".Mar 26 2021, 9:17 PM
musstudxxx removed a project: Restricted Project.
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 9:17 PM
vaivaswatha set the repository for this revision to rG LLVM Github Monorepo.Mar 26 2021, 9:29 PM
vaivaswatha changed the visibility from "musstudxxx (josh Jackson)" to "Public (No Login Required)".
jberdine accepted this revision.Mar 27 2021, 3:18 AM

LGTM

llvm/bindings/ocaml/debuginfo/llvm_debuginfo.ml
262

I wonder if this diff indicates that this data label ought to be e.g. types instead, to help avoid similar mistakes in the future? A counter-argument is that the LLVM-C header uses Data.

This revision is now accepted and ready to land.Mar 27 2021, 3:18 AM
This revision was landed with ongoing or failed builds.Mar 27 2021, 6:13 PM
This revision was automatically updated to reflect the committed changes.