This is an archive of the discontinued LLVM Phabricator instance.

[OCaml][DebugInfo] Add tests for the recently added debug info API

Authored by vaivaswatha on Mar 26 2021, 2:18 AM.



In the process of adding the tests, several bugs were found in the implementation and interface of the API and they were fixed.

Some utilities from the core tests ( were moved into a separate file for reuse.

The following new functions have been added: dibuild_create_global_variable_expression, dibuild_create_constant_value_expression and llmetadata_null. The third one already existed but is now exposed publicly.


Diff Detail

Event Timeline

vaivaswatha created this revision.Mar 26 2021, 2:18 AM
vaivaswatha requested review of this revision.Mar 26 2021, 2:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 2:18 AM

Remove #include <stdio.h> that was inadvertently added.

vaivaswatha edited the summary of this revision. (Show Details)Mar 26 2021, 2:28 AM
jberdine accepted this revision.Mar 26 2021, 9:26 AM

LGTM, thanks!

This revision is now accepted and ready to land.Mar 26 2021, 9:26 AM
This revision was landed with ongoing or failed builds.Mar 26 2021, 9:55 AM
This revision was automatically updated to reflect the committed changes.

Option seems to not work on the buildbot machines. So I ended up replacing that with a match Tagging @jberdine for a post-commit review of it.

I looked over the new commit and it is good. Personally I prefer the new style anyhow. :-)