This is an archive of the discontinued LLVM Phabricator instance.

Differential D99094

[libcxx] [test] Remove a couple outdated XFAIL LIBCXX-WINDOWS-FIXME
ClosedPublic

Authored by mstorsjo on Mar 22 2021, 10:47 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG247f8f6719bc: [libcxx] [test] Remove a couple outdated XFAIL LIBCXX-WINDOWS-FIXME
Summary

With current versions of MSVC, these tests do succeed.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Mar 22 2021, 10:47 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2021, 10:47 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Mar 22 2021, 12:15 PM
This revision is now accepted and ready to land.Mar 22 2021, 12:15 PM
This revision was landed with ongoing or failed builds.Mar 22 2021, 2:41 PM
Closed by commit rG247f8f6719bc: [libcxx] [test] Remove a couple outdated XFAIL LIBCXX-WINDOWS-FIXME (authored by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG247f8f6719bc: [libcxx] [test] Remove a couple outdated XFAIL LIBCXX-WINDOWS-FIXME.
Harbormaster completed remote builds in B95041: Diff 332360.Mar 22 2021, 3:17 PM

Revision Contents

PathSize
libcxx/
test/
std/
language.support/
support.dynamic/
new.delete/
new.delete.array/
5 lines
new.delete.single/
5 lines

Diff 332360

libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp

Show All 14 Lines
// UNSUPPORTED: apple-clang-9, apple-clang-10 // UNSUPPORTED: apple-clang-9, apple-clang-10
// UNSUPPORTED: clang-5, clang-6, clang-7 // UNSUPPORTED: clang-5, clang-6, clang-7
// XFAIL: with_system_cxx_lib=macosx10.13 // XFAIL: with_system_cxx_lib=macosx10.13
// XFAIL: with_system_cxx_lib=macosx10.12 // XFAIL: with_system_cxx_lib=macosx10.12
// XFAIL: with_system_cxx_lib=macosx10.11 // XFAIL: with_system_cxx_lib=macosx10.11
// XFAIL: with_system_cxx_lib=macosx10.10 // XFAIL: with_system_cxx_lib=macosx10.10
// XFAIL: with_system_cxx_lib=macosx10.9 // XFAIL: with_system_cxx_lib=macosx10.9
// On Windows libc++ doesn't provide its own definitions for new/delete
// but instead depends on the ones in VCRuntime. However VCRuntime does not
// yet provide aligned new/delete definitions so this test fails.
// XFAIL: LIBCXX-WINDOWS-FIXME
// test operator new nothrow by replacing only operator new // test operator new nothrow by replacing only operator new
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#include <cassert> #include <cassert>
#include <limits> #include <limits>
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines

libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp

Show All 14 Lines
// UNSUPPORTED: apple-clang-9, apple-clang-10 // UNSUPPORTED: apple-clang-9, apple-clang-10
// UNSUPPORTED: clang-5, clang-6, clang-7 // UNSUPPORTED: clang-5, clang-6, clang-7
// XFAIL: with_system_cxx_lib=macosx10.13 // XFAIL: with_system_cxx_lib=macosx10.13
// XFAIL: with_system_cxx_lib=macosx10.12 // XFAIL: with_system_cxx_lib=macosx10.12
// XFAIL: with_system_cxx_lib=macosx10.11 // XFAIL: with_system_cxx_lib=macosx10.11
// XFAIL: with_system_cxx_lib=macosx10.10 // XFAIL: with_system_cxx_lib=macosx10.10
// XFAIL: with_system_cxx_lib=macosx10.9 // XFAIL: with_system_cxx_lib=macosx10.9
// On Windows libc++ doesn't provide its own definitions for new/delete
// but instead depends on the ones in VCRuntime. However VCRuntime does not
// yet provide aligned new/delete definitions so this test fails.
// XFAIL: LIBCXX-WINDOWS-FIXME
// test operator new nothrow by replacing only operator new // test operator new nothrow by replacing only operator new
#include <new> #include <new>
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#include <cassert> #include <cassert>
#include <limits> #include <limits>
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines