This is an archive of the discontinued LLVM Phabricator instance.

Differential D99089

[libc++] Include <__config> first in all standard headers.
ClosedPublic

Authored by • Quuxplusone on Mar 22 2021, 10:14 AM.

Details

Reviewers
EricWF
ldionne
Group Reviewers
Restricted Project
Commits
rG43aaf87173ac: [libc++] Include <__config> first in all standard headers.
Summary

Mostly, *don't* include <experimental/__config> from C++17 <any>,
because that doesn't make any sense. I think it was just a cut-and-paste
typo when this header moved from experimental/.

Diff Detail

Event Timeline

• Quuxplusone requested review of this revision.Mar 22 2021, 10:14 AM
• Quuxplusone created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 22 2021, 10:14 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B95030: Diff 332347.Mar 22 2021, 12:46 PM
ldionne accepted this revision.Mar 22 2021, 1:41 PM
This revision is now accepted and ready to land.Mar 22 2021, 1:41 PM
Closed by commit rG43aaf87173ac: [libc++] Include <__config> first in all standard headers. (authored by • arthur.j.odwyer). · Explain WhyMar 22 2021, 4:02 PM
This revision was automatically updated to reflect the committed changes.
• arthur.j.odwyer added a commit: rG43aaf87173ac: [libc++] Include <__config> first in all standard headers..

Revision Contents

PathSize
libcxx/
include/
2 lines
5 lines

Diff 332462

libcxx/include/any

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines template<class ValueType>
const ValueType* any_cast(const any* operand) noexcept; const ValueType* any_cast(const any* operand) noexcept;
template<class ValueType> template<class ValueType>
ValueType* any_cast(any* operand) noexcept; ValueType* any_cast(any* operand) noexcept;
} // namespace std } // namespace std
*/ */
#include <experimental/__config> #include <__config>
#include <__availability> #include <__availability>
#include <memory> #include <memory>
#include <typeinfo> #include <typeinfo>
#include <type_traits> #include <type_traits>
#include <cstdlib> #include <cstdlib>
#include <version> #include <version>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
▲ Show 20 Lines • Show All 594 Lines • Show Last 20 Lines

libcxx/include/system_error

Show First 20 Lines • Show All 136 Lines • ▼ Show 20 Lines
template <> struct hash<std::error_code>; template <> struct hash<std::error_code>;
template <> struct hash<std::error_condition>; template <> struct hash<std::error_condition>;
} // std } // std
*/ */
#include <__config>
#include <__errc> #include <__errc>
#include <type_traits> #include <__functional_base> // unary_function
#include <stdexcept> #include <stdexcept>
#include <__functional_base>
#include <string> #include <string>
#include <type_traits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
#pragma GCC system_header #pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
// is_error_code_enum // is_error_code_enum
▲ Show 20 Lines • Show All 330 Lines • Show Last 20 Lines