This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Future-proof generate_feature_test_macro_components.py against long names
ClosedPublic

Authored by Quuxplusone on Mar 18 2021, 7:35 AM.

Details

Summary

The proposed-for-C++2b __cpp_lib_default_template_type_for_algorithm_values is 52 characters long, which is enough to reduce the multiplier to less-than-zero, producing an empty string between the name of the macro and its numeric value. Ensure there's always a space between the name of the macro and its value.

When run, this produces no diffs in the generated headers/tests.

Diff Detail

Event Timeline

Quuxplusone requested review of this revision.Mar 18 2021, 7:35 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 18 2021, 7:35 AM
ldionne accepted this revision.Mar 18 2021, 10:02 AM
This revision is now accepted and ready to land.Mar 18 2021, 10:02 AM
This revision was landed with ongoing or failed builds.Mar 18 2021, 10:35 AM
This revision was automatically updated to reflect the committed changes.