This is an archive of the discontinued LLVM Phabricator instance.

Differential D98661

[M68k] Fixed incorrect `extract-section` command substitution
ClosedPublic

Authored by myhsu on Mar 15 2021, 2:00 PM.

Details

Reviewers
RKSimon
Commits
rG340d558c7789: [M68k] Fixed incorrect `extract-section` command substitution
Summary

Fix Bug 49485 (https://bugs.llvm.org/show_bug.cgi?id=49485). Which was caused by incorrect invocation of extract-section.py on Windows.
Replacing it with more general python script invocation.

Diff Detail

Event Timeline

myhsu requested review of this revision.Mar 15 2021, 2:00 PM
myhsu created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2021, 2:00 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B93912: Diff 330799.Mar 15 2021, 4:23 PM
RKSimon accepted this revision.Mar 16 2021, 1:02 PM

LGTM - this fixes windows builds (haven't tested it on anything else), cheers.

This revision is now accepted and ready to land.Mar 16 2021, 1:02 PM
Closed by commit rG340d558c7789: [M68k] Fixed incorrect `extract-section` command substitution (authored by myhsu). · Explain WhyMar 16 2021, 1:39 PM
This revision was automatically updated to reflect the committed changes.
myhsu added a commit: rG340d558c7789: [M68k] Fixed incorrect `extract-section` command substitution.

Revision Contents

PathSize
llvm/
test/
CodeGen/
M68k/
3 lines

Diff 331097

llvm/test/CodeGen/M68k/lit.local.cfg

import os import os
config.suffixes = ['.ll', '.mir', '.test', '.txt'] config.suffixes = ['.ll', '.mir', '.test', '.txt']
extract_section_path = os.path.join(config.llvm_src_root, extract_section_path = os.path.join(config.llvm_src_root,
'utils', 'extract-section.py') 'utils', 'extract-section.py')
config.substitutions.append(('extract-section', config.substitutions.append(('extract-section',
extract_section_path + ' --byte-indicator --hex-width=2')) "'%s' %s %s" % (config.python_executable,
extract_section_path, '--byte-indicator --hex-width=2')))
if not 'M68k' in config.root.targets: if not 'M68k' in config.root.targets:
config.unsupported = True config.unsupported = True