This is an archive of the discontinued LLVM Phabricator instance.

Remove trailing slash from dumping directory FileSpec.
ClosedPublic

Authored by chaoren on May 19 2015, 1:59 PM.

Reviewers

ovyalov
domipheus

Commits

chaoren retitled this revision from to Remove trailing slash from dumping directory FileSpec..

chaoren updated this object.

chaoren edited the test plan for this revision. (Show Details)

chaoren added a subscriber: Unknown Object (MLST).

Some things depend on Dump having the trailing slash.

Looks good.

This revision is now accepted and ready to land.May 19 2015, 4:07 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

Host/

common/

2 lines

	Show First 20 Lines • Show All 608 Lines • ▼ Show 20 Lines
	// directory delimiter, and the filename.			// directory delimiter, and the filename.
	//------------------------------------------------------------------			//------------------------------------------------------------------
	void			void
	FileSpec::Dump(Stream *s) const			FileSpec::Dump(Stream *s) const
	{			{
	if (s)			if (s)
	{			{
	m_directory.Dump(s);			m_directory.Dump(s);
	if (m_directory && m_directory.GetStringRef().back() != '/')			if (m_filename && m_directory.GetStringRef().endswith("/"))
	s->PutChar('/');			s->PutChar('/');
	m_filename.Dump(s);			m_filename.Dump(s);
	}			}
	}			}

	//------------------------------------------------------------------			//------------------------------------------------------------------
	// Returns true if the file exists.			// Returns true if the file exists.
	//------------------------------------------------------------------			//------------------------------------------------------------------
	▲ Show 20 Lines • Show All 787 Lines • Show Last 20 Lines